Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5338727rwd; Tue, 23 May 2023 23:40:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ42SsoqX1Rjiyjodt2EUZ6Dkj5ztipJNQLqAJXXTga2OX4i1Ya/KiGl3k7fq1RDwwWi+wLl X-Received: by 2002:a17:902:b787:b0:1ae:7812:2fc0 with SMTP id e7-20020a170902b78700b001ae78122fc0mr16261631pls.4.1684910400144; Tue, 23 May 2023 23:40:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684910400; cv=none; d=google.com; s=arc-20160816; b=V1q3tkkR/ls8+Z39Rhek+kw+x4wCZwPdvmjzNqjP5caFi2WkABaAYE3a3VQSpCfkSl dV6cR2nsxPP/9UBW9ttMRa5QCOlUOqkFSxDESXrIl8f2cxM2EAYLZrE6R5DyDc7IjUn0 q4fYrVd8AN9GVOI9aOyrdg6wFbzFRpTGShv2vQmqXEYTze0XHJ73VZOWxwFZ0VxANQTR 98qLIg1dqoFRmNhxXijGjaWqzawjvUmWDiviEWRRhS89HyFU7uvGzK/1+frFDWgOjtw1 17m1vjB4CvejA0t6m8qwSJy0hofLOZPRfJeLpTWbpTKlQGfUw+d7ps6ZzKq1mr3wQgQZ CVHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=BaVpF3CLGGYHSCXFratbLIUUoGbTJdfV4r1ZDWs4/a4=; b=bf5R8qchSqmIw3oLm6SgBu19PdPu5W8iKfbkpSpczkzue1YdpN3iXiBbGOP2LHQknO 2CLq+jDzOWFJD+zuWfbh/OVYC9/auLrfOPOyyEV6WqVtdJzPiWhp1vuY8YPA3Zfub2nZ bBdvAU6PaCg+CxENbNvcMa/D2VAEMyyIAzfbW7lNIJSBO8DsRMVpUpvyvKWUFwYrPn2+ YZXX0zrAmFKpIpm2nJHgvfCXVuL+OxDv2yrykPGFpaz6GgrX7NU3D9MMb4PYuMJUshrK GkUTzpCNXVnfamCx+xri3MU2xj+J9mUsKo/40v5EFKLqtTBX0FThO6ixwZ1eRGwr0waY ZG6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020a170903018700b001ac59bc1c20si2111612plg.47.2023.05.23.23.39.46; Tue, 23 May 2023 23:40:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239638AbjEXGIu (ORCPT + 99 others); Wed, 24 May 2023 02:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235788AbjEXGIt (ORCPT ); Wed, 24 May 2023 02:08:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18447132; Tue, 23 May 2023 23:08:49 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4CF6E68CFE; Wed, 24 May 2023 08:08:45 +0200 (CEST) Date: Wed, 24 May 2023 08:08:44 +0200 From: Christoph Hellwig To: Randy Dunlap Cc: Christoph Hellwig , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Mike Snitzer , Joern Engel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Pavel Machek , dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 15/24] block: move the code to do early boot lookup of block devices to block/ Message-ID: <20230524060844.GC19611@lst.de> References: <20230523074535.249802-1-hch@lst.de> <20230523074535.249802-16-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2023 at 09:59:50PM -0700, Randy Dunlap wrote: > >> root= [KNL] Root filesystem > >> - See early_lookup_bdev comment in init/do_mounts.c. > >> + See early_lookup_bdev comment in block/early-lookup.c > > > > Patch 13 does this: > > > > root= [KNL] Root filesystem > > - See name_to_dev_t comment in init/do_mounts.c. > > + See early_lookup_bdev comment in init/do_mounts.c. > > > > Should this latter chunk be dropped? > > > > Oh, oops, reverse order of patches? Patch 13 renames the function, this patch moves it. So I think this correct, but feel free to double check my foggy brain :)