Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230523214127.4006891-1-pranavpp@google.com> <20230523214127.4006891-3-pranavpp@google.com>
In-Reply-To: <20230523214127.4006891-3-pranavpp@google.com>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Wed, 24 May 2023 08:37:37 +0200
Message-ID: <CAMGffEkCgnUXZAhctgfuqZ-VssQ81h5RXDqJOG-RXD4T1Ui5TQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] scsi: pm80xx: Add fatal error check for pm8001_lu_reset()
To:     Pranav Prasad <pranavpp@google.com>
Cc:     Jack Wang <jinpu.wang@cloud.ionos.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Igor Pylypiv <ipylypiv@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 23, 2023 at 11:41=E2=80=AFPM Pranav Prasad <pranavpp@google.com=
> wrote:
>
> From: Igor Pylypiv <ipylypiv@google.com>
>
> This patch adds a fatal error check for pm8001_lu_reset().
>
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> Signed-off-by: Pranav Prasad <pranavpp@google.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/scsi/pm8001/pm8001_sas.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm800=
1_sas.c
> index b153f0966e5d..e302d5879bb7 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -918,6 +918,16 @@ int pm8001_lu_reset(struct domain_device *dev, u8 *l=
un)
>         struct pm8001_device *pm8001_dev =3D dev->lldd_dev;
>         struct pm8001_hba_info *pm8001_ha =3D pm8001_find_ha_by_dev(dev);
>         DECLARE_COMPLETION_ONSTACK(completion_setstate);
> +
> +       if (PM8001_CHIP_DISP->fatal_errors(pm8001_ha)) {
> +               /* If the controller is in fatal error state,
> +                * we will not get a response from the controller
> +                */
> +               pm8001_dbg(pm8001_ha, FAIL,
> +                               "LUN reset failed due to fatal errors\n")=
;
> +               return rc;
> +       }
> +
>         if (dev_is_sata(dev)) {
>                 struct sas_phy *phy =3D sas_get_local_phy(dev);
>                 sas_execute_internal_abort_dev(dev, 0, NULL);
> --
> 2.40.1.698.g37aff9b760-goog
>