Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd
Mime-Version: 1.0
Message-Id: <b8166ed7-2d3b-4bdd-b597-f0aeddb7ecdc@app.fastmail.com>
In-Reply-To: <20230523212829.2539417-1-otavio@ossystems.com.br>
References: <20230523212829.2539417-1-otavio@ossystems.com.br>
Date:   Wed, 24 May 2023 08:48:26 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Otavio Salvador" <otavio@ossystems.com.br>,
        "Shawn Guo" <shawnguo@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org,
        "Alistair Francis" <alistair@alistair23.me>,
        "Fabio Estevam" <festevam@gmail.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        "Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Michael Ellerman" <mpe@ellerman.id.au>,
        "NXP Linux Team" <linux-imx@nxp.com>,
        "Pengutronix Kernel Team" <kernel@pengutronix.de>,
        "Russell King" <linux@armlinux.org.uk>,
        "Sascha Hauer" <s.hauer@pengutronix.de>,
        "Stefan Hansson" <newbie13xd@gmail.com>,
        "Stefan Wahren" <stefan.wahren@chargebyte.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config
Content-Type: text/plain
Precedence: bulk

On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote:
> The KERNEL_GZIP is used in most config and is the default, there is no
> clear reason to diverge so let default be used.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

I don't mind that change, but it seems odd to single this one out, as
there are many other options in that particular defconfig that
stick out more, picking LZO seems like a reasonable choice for slightly
faster booting, though ZSTD would be the more modern choice.

If you are looking into cleaning up this file, maybe see if we can
kill off these options:

CONFIG_EXPERT=y
CONFIG_ARCH_FORCE_MAX_ORDER=13
CONFIG_CMDLINE="noinitrd console=ttymxc0,115200"
CONFIG_CS89x0_PLATFORM=y # none of these four are in dts files
CONFIG_SMC91X=y
CONFIG_SMC911X=y
CONFIG_SMSC911X=y
CONFIG_STAGING=y
CONFIG_STAGING_MEDIA=y
CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years
CONFIG_EXT2_FS=y
CONFIG_EXT3_FS=y # select EXT4 instead
CONFIG_ISO9660_FS=m

I have not investigated why any of them were added originally,
so it's likely that some are actually needed.

     Arnd