Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 07:56:25 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Justin Chen <justin.chen@broadcom.com>
CC:     Conor Dooley <conor@kernel.org>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>,
        <bcm-kernel-feedback-list@broadcom.com>, <justinpopo6@gmail.com>,
        <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <opendmb@gmail.com>, <andrew@lunn.ch>, <hkallweit1@gmail.com>,
        <linux@armlinux.org.uk>, <richardcochran@gmail.com>,
        <sumit.semwal@linaro.org>, <christian.koenig@amd.com>,
        <simon.horman@corigine.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>
Subject: Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet
 controller
Message-ID: <20230524-resample-dingbat-8a9f09ba76a5@wendy>
References: <1684878827-40672-1-git-send-email-justin.chen@broadcom.com>
 <1684878827-40672-3-git-send-email-justin.chen@broadcom.com>
 <20230523-unfailing-twisting-9cb092b14f6f@spud>
 <CALSSxFYMm5NYw41ERr1Ah-bejDgf9EdJd1dGNL9_sKVVmrpg3g@mail.gmail.com>
 <20230524-scientist-enviable-7bfff99431cc@wendy>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="oixSSIk8//11vX0i"
Content-Disposition: inline
In-Reply-To: <20230524-scientist-enviable-7bfff99431cc@wendy>
Precedence: bulk

--oixSSIk8//11vX0i
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 24, 2023 at 07:51:07AM +0100, Conor Dooley wrote:
> Hey Justin,
> On Tue, May 23, 2023 at 04:27:12PM -0700, Justin Chen wrote:
> > On Tue, May 23, 2023 at 3:55=E2=80=AFPM Conor Dooley <conor@kernel.org>=
 wrote:
> > > On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote:
> > >
> > > > +  compatible:
> > > > +    enum:
> > > > +      - brcm,asp-v2.0
> > > > +      - brcm,bcm72165-asp
> > > > +      - brcm,asp-v2.1
> > > > +      - brcm,bcm74165-asp
> > >
> > > > +        compatible =3D "brcm,bcm72165-asp", "brcm,asp-v2.0";
> > >
> > > You can't do this, as Rob's bot has pointed out. Please test the
> > > bindings :( You need one of these type of constructs:
> > >
> > > compatible:
> > >   oneOf:
> > >     - items:
> > >         - const: brcm,bcm72165-asp
> > >         - const: brcm,asp-v2.0
> > >     - items:
> > >         - const: brcm,bcm74165-asp
> > >         - const: brcm,asp-v2.1
> > >
> > > Although, given either you or Florian said there are likely to be
> > > multiple parts, going for an enum, rather than const for the brcm,bcm=
=2E.
> > > entry will prevent some churn. Up to you.
> > >
> > Urg so close. Thought it was a trivial change, so didn't bother
> > retesting the binding. I think I have it right now...
> >=20
> >   compatible:
> >     oneOf:
> >       - items:
> >           - enum:
> >               - brcm,bcm72165-asp
> >               - brcm,bcm74165-asp
> >           - enum:
> >               - brcm,asp-v2.0
> >               - brcm,asp-v2.1
> >=20
> > Something like this look good?
>=20
> I am still caffeine-less, but this implies that both of
> "brcm,bcm72165-asp", "brcm,asp-v2.0"
> _and_
> "brcm,bcm72165-asp", "brcm,asp-v2.1"
> are. I suspect that that is not the case, unless "brcm,asp-v2.0" is a

I a word. s/are/are valid/

> valid fallback for "brcm,asp-v2.1"?
> The oneOf: also becomes redundant since you only have one items:.
>=20
> > Will submit a v5 tomorrow.
>=20
> BTW, when you do, could you use the address listed in MAINTAINERS rather
> than the one you used for this version?
>=20
> Cheers,
> Conor.

--oixSSIk8//11vX0i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZG21GQAKCRB4tDGHoIJi
0sO/AP9cRQ7+VO/SYpcRQ4CrYP3yQKQE6FbJdUJJekywN8ZxsQD/YqL7dDng/AoJ
XO0iNPz9c8Ma+pbj6hsXOiqs/AvLHQI=
=/k6/
-----END PGP SIGNATURE-----

--oixSSIk8//11vX0i--