Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 09:03:59 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Shradha Gupta <shradhagupta@linux.microsoft.com>
Cc:     linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] hv_netvsc: Allocate rx indirection table size dynamically
Message-ID: <ZG2236VbHkOpjau2@corigine.com>
References: <1684907844-23224-1-git-send-email-shradhagupta@linux.microsoft.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1684907844-23224-1-git-send-email-shradhagupta@linux.microsoft.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BPucOg8INLBhWCX71smmaN7Ei/tcIkWE0pXDLRyhVYaAnn6j2OGkKQVEPtLn?=
 =?us-ascii?Q?jo8Q8IcjdIyJCCG8QDiniScHiI+Red2QKXiD4f2NVPyGjt5ujhXTQZeat5lw?=
 =?us-ascii?Q?SjrlUb7r9v5D/mDxErYoKRMLyqPUFq6eRlMTfH+SEaaJjdXg+lGuDAmjguzl?=
 =?us-ascii?Q?qvIBNsAZkREUmf7NkhJuX5M/FfUNH7Kzr5ifpWQtBYqy8OX7oCbUdDW9wS1O?=
 =?us-ascii?Q?4kcI7E7BrjmJyS9vmM9kchKq/abqBpDIuSDYLrgZsDOdSmPOiaDTJ+vgqOsg?=
 =?us-ascii?Q?i+6hmAjP5uPeRpHgyephqqbwWiNNu1z8CkluIJQa8KJLHeIIbq8TlFPqQ/S4?=
 =?us-ascii?Q?sX5CE97epUWg/h6RIXbh8jbvwdk30nPLOeFa31qwx+vqVOixWj3ZnHlBjtLG?=
 =?us-ascii?Q?zEaD8ZC233+W72crGUQSAggFD1KXPfTknsf9x2DEFKG7kIhN0mMvogDLfjg8?=
 =?us-ascii?Q?64PilqtwvcZzp0E9/KTbjFqzppXBnDpK295ULZ+pkeQrtnsfslYcPTbeCPJx?=
 =?us-ascii?Q?HP+TFE8sTJihiagSprveO3s8iEKdoUkBZKYlUOmYiYuVOnwqYtMpUMnXyUyU?=
 =?us-ascii?Q?7Z67vEqmfsvhyo7arReAIH1DCVTZqmVRRsuIlSqKJrPx0s/1awhrPRdGRQHs?=
 =?us-ascii?Q?O87s6QDAFiuU2/tpC1Hal5jjeITqmNGbu5r4PC7I47/xXFObMM+VPHSH9nAB?=
 =?us-ascii?Q?4Fq7ifTOXwKfIsSADmOa/US6/53sEjFELyhIDwxiYgsPK+ixtLwsfKzRYpii?=
 =?us-ascii?Q?Tz6IJ387/+r6DkfFvMmkX62zN8hh+yHUxVLpsQ6V20EuddNl0WZkJKRroYN0?=
 =?us-ascii?Q?1EOOXZnKsLAXqrkk8LM3X8okz1M3mwajrPFeoovZDudxCp1kgjUP+YJHOF3W?=
 =?us-ascii?Q?hwbVNGYJZPS9OIz+QGYMiIZC8BeInqXEjfuD5eJ9hxgeS49epso5rfTIKg3l?=
 =?us-ascii?Q?urKuV+jL5cVfV4LFbBbt96DAF13s3KtRZ+CcXlbZf+eBfHN+s/qsSR0VeGtP?=
 =?us-ascii?Q?iWnexIktqqJm9+8vU0OTPSeNxbbIZj4nQhS2a+iUMGJ4wsrpLPxEajOCdCxz?=
 =?us-ascii?Q?p/XhWjeosE/p3/Dk13lTaa8WEJxK5+CF0NW3M2ODqb6q0pqXrZRw6v8nkDQ8?=
 =?us-ascii?Q?Yl2AoNwhlS95In7Xv9XWMrjvnlgOxQZYAJWD2TrhT2WI5JMjkKLvijcgYSEM?=
 =?us-ascii?Q?aL+FSWUSD8RFU4ehYm8ziWS32gSwR7jEK1CNV2eFQvd7jEGkf+Uf/NYa03yB?=
 =?us-ascii?Q?JWknh5W6JMxjXGU9lMq2pMN9YpjmQGa8qu1YmwNS6hMcNmHscPCiUgp1Ghwb?=
 =?us-ascii?Q?lwYdBhkaYBD5wXLHUOixMd4q88YPfDYe/2Cb9wYgMEYqFwJFAkddJA1iqfnN?=
 =?us-ascii?Q?Yt0qc8+MHGKqSMzOV9S6ftbY4uyZwtuiEgAtdPmdfj5uZHuSRa884cgTU7FX?=
 =?us-ascii?Q?mCmLByBaVln6+C9jhHZgdmrQVHRBIyV/4savjBl9I2nSnUsUsVFGVYva9TJU?=
 =?us-ascii?Q?q7RtJ3/gczmGuPZZpS7O9fX7vM1n68h6m9SxNA11pye9icNKwAvRq2rMZQrJ?=
 =?us-ascii?Q?GTuoGU3U1rirSw5F1kJBdzLFYPbVYR+rjBNHwRP+0UFMr+jte6ovoeDVC1bl?=
 =?us-ascii?Q?Avpoo64HmKXcZzQCYufyvMOPzO4CxC/QSnt9CVCxZuvbqSDSYKUaTXlGrzP0?=
 =?us-ascii?Q?4CH1FQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6aeff96e-e486-4df8-aff4-08db5c25111a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 07:04:07.6400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QPioUT8bZytTPm6LWbKoQuN+ZIXGt1QPUUKcubymVBUXDE/QaCxnIWDEUxWZQYW132W8NPN+wzt/4TY5KVJHUFmGxeWS2mMht19u8yyGIPg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR13MB6324
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 23, 2023 at 10:57:24PM -0700, Shradha Gupta wrote:
> Allocate the size of rx indirection table dynamically in netvsc
> from the value of size provided by OID_GEN_RECEIVE_SCALE_CAPABILITIES
> query instead of using a constant value of ITAB_NUM.
> 
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>

Hi Shradha,

thanks for your patch.

> @@ -1548,6 +1548,21 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
>  	if (ret || rsscap.num_recv_que < 2)
>  		goto out;
>  
> +	if (rsscap.num_indirect_tabent &&
> +		rsscap.num_indirect_tabent <= ITAB_NUM_MAX) {

nit: the line above is not indented correctly,
     it should line up with the inside of the opening parentheses
     on the preceding line.

     Also, I don't think the curly-brackets are needed.

	if (rsscap.num_indirect_tabent &&
	    rsscap.num_indirect_tabent <= ITAB_NUM_MAX) {

> +		ndc->rx_table_sz = rsscap.num_indirect_tabent;
> +	} else {
> +		ndc->rx_table_sz = ITAB_NUM;
> +	}
> +
> +	ndc->rx_table = kzalloc(sizeof(u16) * ndc->rx_table_sz,
> +				GFP_KERNEL);
> +	if (ndc->rx_table) {

More importantly, it looks like the condition is inverted here.
Which seems unlikely to lead to anything good happening.

	if (!ndc->rx_table) {

> +		netdev_err(net, "Error in allocating rx indirection table of size %d\n",
> +				ndc->rx_table_sz);
> +		goto out;
> +	}
> +
>  	/* This guarantees that num_possible_rss_qs <= num_online_cpus */
>  	num_possible_rss_qs = min_t(u32, num_online_cpus(),
>  				    rsscap.num_recv_que);
> @@ -1558,7 +1573,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
>  	net_device->num_chn = min(net_device->max_chn, device_info->num_chn);
>  
>  	if (!netif_is_rxfh_configured(net)) {
> -		for (i = 0; i < ITAB_NUM; i++)
> +		for (i = 0; i < ndc->rx_table_sz; i++)
>  			ndc->rx_table[i] = ethtool_rxfh_indir_default(
>  						i, net_device->num_chn);
>  	}

-- 
pw-bot: cr