Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 15:06:35 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Yang Weijiang <weijiang.yang@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <binbin.wu@linux.intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH v3 06/21] KVM:x86: Report XSS as to-be-saved if there are
 supported features
Message-ID: <ZG23e/zYAiRlfrk9@chao-email>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <20230511040857.6094-7-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230511040857.6094-7-weijiang.yang@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UmLTF8JLgPFomMQ8jAHafk3R+p4784gA0TDMvzwlDzCjCfZkwHdvPTvsnpHF?=
 =?us-ascii?Q?4Wsan5baj0Afl090n2G2Xdsa2ywFnte2UhIxB360OLSd/ydR3ywoYHFk1So9?=
 =?us-ascii?Q?huVh+jzN9AdPKZKBQw/mh1hRA0EipHepskeiYCLQARXAFKFl/sKta9yxiHmD?=
 =?us-ascii?Q?hR+CChoibrnG4LPg7YvlV5r/MkZbXSniU1fSfklx1YtJhTWJ2EO+CdagUhvX?=
 =?us-ascii?Q?hBvbRGMAF9sO/+rsaxSNM7AmLapIHR0wAfaRTYno3eJjzj3e727KTmouuTOP?=
 =?us-ascii?Q?coDYZl5loM/Yiteo+kFPtK9Fx5fdAuvSgJfQmsk4+o2lHVf8rRXYM6WceWMx?=
 =?us-ascii?Q?tPyIWXwAhKLwefFg6rwSC9ph6waGvqzFTRU80eArHufWMtrdaeEzR2Phmue8?=
 =?us-ascii?Q?UBSAvl1VqoUhmOuuIS6DAYWgCSzTn67GrlpilkIPBCs4hZEPnTzgJMDi6pzG?=
 =?us-ascii?Q?/xF+EyoVeTZ3bGsX+jqUP2sF9l6fEK6lZvZOR7RU1VAW8fbHU668B6CNUl0W?=
 =?us-ascii?Q?wTOOETtb0yTlH1DJG311sSThUducAUHeDvp81xGd7IsXMAXM6bQFPjNyoMX0?=
 =?us-ascii?Q?IzIE57Lj5hwUYMRTT09pTH9WhrQEzm4WlcMEtdoCAlSDGQukb6uzCW19bWZR?=
 =?us-ascii?Q?+Yj23MsqD282Hu4vAw+wNxgbuypoQMnIsePaL03VqMvWAEgqi88mf5Z5ykeN?=
 =?us-ascii?Q?n0nWeiZUbdYxciryfm2nEGgrsCgSabYml46boJHAGqdONTsmEKrqouIKWdzS?=
 =?us-ascii?Q?66HKzYJ2qoIvdBd3COd/Y+PlCnZRZ4cfF/H8FNAtiimyQ8s9KsXqTkB0AivY?=
 =?us-ascii?Q?hoaFGFlSp6XIgb5QjLOblDFcRLLYRTSopaLoWWFwNljaAwRP2DwJSrPKD1nC?=
 =?us-ascii?Q?BBlmHFnairLRH/885N2eEx1Mz92h5Rr6XlQIUbHinbhnrAwrnw1S66OYlkMb?=
 =?us-ascii?Q?6Tm68CdFupbZRrLwSYhDpEwEnXKthxaXvkwXmcJkotNWKTU/7OAbHc94V7R7?=
 =?us-ascii?Q?tZ3cr0eocw8iW4mraZv0cAvdfaBB/m7CvmGcJoUlHk5vnXgZcLZzyiZeilBt?=
 =?us-ascii?Q?c8s0VY6RkOxbsjfyL+2d+GXEZoKpskIPhh1meV050pzyqtQa3CjRUTCHxmR7?=
 =?us-ascii?Q?/KI/uqwlhCwLedocHkOF1ZJ4W0SP1hRJLaU6NfSEmlDq54CHfF++HCrvFM9f?=
 =?us-ascii?Q?b3Y3g/qyrJKPXHxT1qhFqzu2Q2DyzaN5oJSrFyYXmkMMbA5tcg+QKSUXNHjY?=
 =?us-ascii?Q?Ql9koEbRLzcpAcUBZYv7vfJfvxMhRFP8ML2lWasC5EVqVML+d9wH89PXiGz6?=
 =?us-ascii?Q?LhxBe/dYNXg4jBUqv6aeRTHulZAWiKm5i5GPACYLGOoeWcUDBvD1Twgh3Ssm?=
 =?us-ascii?Q?T1GrJAEqdq1/n9dNt554JwspOM63TJifq7EBMb2re+hzJ8R5hLhS/jgh3Tlf?=
 =?us-ascii?Q?HaeE/n7h2cHoq+/4b+89+CxQjqjoVg1wGYHJ9jymFlL6l4Do7U563N9ZRNJj?=
 =?us-ascii?Q?o26JlPdgPeaU4v9J5YxUPS4qPN4j5ZCfFbh8YwgVtaSD6KMKHcF1VtbVTLeN?=
 =?us-ascii?Q?l/KHf6ym/NS/OWXl8OMSKO30URsF9mQhxVhxbaYC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02401978-9410-4d4e-f059-08db5c25700e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 07:06:46.8696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9NZPgA16SgBxO9wDjGheu09LYbjWygKyaEiU+1qE0QQXpDneOAFDqden9c8b9XpBdBI0hkhTd4LQCDvW5ZGITQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6125
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 11, 2023 at 12:08:42AM -0400, Yang Weijiang wrote:
>From: Sean Christopherson <sean.j.christopherson@intel.com>
>
>Add MSR_IA32_XSS to the list of MSRs reported to userspace if
>supported_xss is non-zero, i.e. KVM supports at least one XSS based
>feature.

The changelog doesn't match what the patch does.

Do you need to check if supported_xss is non-zero in kvm_probe_msr_to_save(),
e.g.,
        case MSR_IA32_XSS:
                if (!kvm_caps.supported_xss)
                        return;
                break;

>
>Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>---
> arch/x86/kvm/x86.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>index e7f78fe79b32..33a780fe820b 100644
>--- a/arch/x86/kvm/x86.c
>+++ b/arch/x86/kvm/x86.c
>@@ -1454,6 +1454,7 @@ static const u32 msrs_to_save_base[] = {
> 	MSR_IA32_UMWAIT_CONTROL,
> 
> 	MSR_IA32_XFD, MSR_IA32_XFD_ERR,
>+	MSR_IA32_XSS,
> };
> 
> static const u32 msrs_to_save_pmu[] = {
>-- 
>2.27.0
>