Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 09:35:30 +0200
From:   Willy Tarreau <w@1wt.eu>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Zhangjin Wu <falcon@tinylab.org>
Subject: Re: [PATCH 0/3] tools/nolibc: stack protector compatibility fixes
Message-ID: <ZG2+QuD/tVDqyMyb@1wt.eu>
References: <20230523-nolibc-stackprotector-gcc9-v1-0-3e4804235d50@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230523-nolibc-stackprotector-gcc9-v1-0-3e4804235d50@weissschuh.net>
Precedence: bulk

Hi Thomas,

On Wed, May 24, 2023 at 08:44:41AM +0200, Thomas Wei?schuh wrote:
> Two fixes for nolibc to
> * allow users to explicitly disable (or theoretically enable) when
>   building the tests
> * fix stackprotectors on GCC < 10.

Nice, thank you. Just tested with gcc 9.5, works both with and without
stkp. Now pushed to branch 20230524-nolibc-rv32+stkp4. I've dropped my
exp patch and the associated revert. I think your two patches that clean
up the makefile options and the new one here that restores the cflags
should be squashed since the latter just partially reverts the former,
and that way the series remains bisectable. Just let me know if you're
OK, I can just to that and re-push.

Have a nice day!
Willy