Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   xu xin <xu.xin.sc@gmail.com>
To:     david@redhat.com
Cc:     akpm@linux-foundation.org, imbrenda@linux.ibm.com,
        jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com,
        xu.xin16@zte.com.cn, yang.yang29@zte.com.cn
Subject: Re: [PATCH v9 2/5] ksm: count all zero pages placed by KSM
Date:   Wed, 24 May 2023 15:55:39 +0800
Message-Id: <20230524075539.20844-1-xu.xin16@zte.com.cn>
In-Reply-To: <52bfd744-3086-a22a-e2e7-8b64d5fccfcc@redhat.com>
References: <52bfd744-3086-a22a-e2e7-8b64d5fccfcc@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

>> +extern unsigned long ksm_zero_pages;
>> +
>> +static inline void ksm_notify_unmap_zero_page(pte_t pte)
>> +{
>> +	if (is_ksm_zero_pte(pte))
>> +		ksm_zero_pages--;
>> +}
>> +
>>   static inline int ksm_fork(struct mm_struct *mm, struct mm_struct *oldmm)
>>   {
>>   	int ret;
>> @@ -103,6 +111,10 @@ static inline void ksm_exit(struct mm_struct *mm)
>>   
>>   #define is_ksm_zero_pte(pte)	0
>>   
>> +static inline void ksm_notify_unmap_zero_page(pte_t pte)
>> +{
>> +}
>> +
>
>Having proposed that name ... I realize that we call this function 
>whenever there might be a zeropage mapped (when we have !page after 
>vm_normal_page()) -- but it could also not be the zeropage.
>
>Not really able to come up with a better name :)
>
>ksm_notify_maybe_unmap_zero_page ?
>
>ksm_maybe_unmap_zero_page ?
>

Analogous to the existing name of ksm_might_need_to_copy, so maybe we can use
'ksm_might_unmap_zero_page', 

>
>Maybe someone else reading along has a better idea. In any case, the 
>logic itself LGTM