Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9bb5c5cd-e9e7-5390-7bd7-fac882aaa0d0@linux.intel.com>
Date:   Wed, 24 May 2023 11:55:15 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only
Content-Language: en-US
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        l.sanfilippo@kunbus.com, jsnitsel@redhat.com
References: <20230524055815.10165-1-peter.ujfalusi@linux.intel.com>
 <a1030692-e80f-a785-2e90-238d5f00a181@molgen.mpg.de>
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>
In-Reply-To: <a1030692-e80f-a785-2e90-238d5f00a181@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Paul,

On 24/05/2023 11:43, Paul Menzel wrote:
> Dear Peter,
> 
> 
> Thank you for your patch.
> 
> Am 24.05.23 um 07:58 schrieb Peter Ujfalusi:
>> The original patch which added the quirk would apply to all AAEON
>> machines,
>> which might or might not be valid.
>>
>> The issue was discovered on UPX-i11 (TigerLake), it is not known if the
>> i12 (AlderLake) version is affected.
>> UP2 (ApolloLake) does not even have TMP module (no TPM drivers probing
> 
> s/TMP/TPM/

I will fix it in v2.

> 
>> and confirmed by dmidecode).
> 
> Another nit, the official spelling of the SOC names is with a space, for
> example, Tiger Lake [1].

I will correct this and the ADL, APL spelling also.

> 
>> Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.
>>
>> Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")
>> Suggested-by: Jerry Snitselaar <jsnitsel@redhat.com>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>> ---
>> Hi Jarkko,
>>
>> the patch is generated on top of your
>> git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git :
>> irq-storm
>>
>> Regards,
>> Peter
>>
>>   drivers/char/tpm/tpm_tis.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
>> index 7db3593941ea..4357d4ba8f9e 100644
>> --- a/drivers/char/tpm/tpm_tis.c
>> +++ b/drivers/char/tpm/tpm_tis.c
>> @@ -143,6 +143,7 @@ static const struct dmi_system_id
>> tpm_tis_dmi_table[] = {
>>           .ident = "UPX-TGL",
>>           .matches = {
>>               DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
>> +            DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
>>           },
>>       },
>>       {}
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>

And I will pick your tag as well to v2,

Thank you for the review and comments!

-- 
Péter