Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 11:12:01 +0200
From:   Christian Brauner <brauner@kernel.org>
To:     Ziqi Zhao <astrajoan@yahoo.com>
Cc:     skhan@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [Linux-kernel-mentorship] [PATCH] selftest: pidfd: Omit long and
 repeating outputs
Message-ID: <20230524-tausend-erlitt-b3163dd1dd05@brauner>
References: <20230523232207.363136-1-astrajoan.ref@yahoo.com>
 <20230523232207.363136-1-astrajoan@yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230523232207.363136-1-astrajoan@yahoo.com>
Precedence: bulk

On Tue, May 23, 2023 at 11:22:07PM +0000, Ziqi Zhao wrote:
> An output message:
> 
> > # # waitpid WEXITSTATUS=0
> 
> will be printed for 30,000+ times in the `pidfd_test` selftest, which
> does not seem ideal. This patch removes the print logic in the
> `wait_for_pid` function, so each call to this function does not output
> a line by default. Any existing call sites where the extra line might
> be beneficial have been modified to include extra print statements
> outside of the function calls.
> 
> Signed-off-by: Ziqi Zhao <astrajoan@yahoo.com>
> ---

Fine by me,
Reviewed-by: Christian Brauner <brauner@kernel.org>