Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5497317rwd; Wed, 24 May 2023 02:39:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jggtLWK/Io8GQ2FiZbUEiKGTeuSy0YIO1tFI5YFpp8ZL0O+VXVy4Wd3xKIVd49FbOBn84 X-Received: by 2002:a05:6a00:b50:b0:64f:35c8:8584 with SMTP id p16-20020a056a000b5000b0064f35c88584mr2518386pfo.18.1684921159617; Wed, 24 May 2023 02:39:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684921159; cv=none; d=google.com; s=arc-20160816; b=ZwDTHPBvswceFMgIuBUfQ2VMfFQeZTEuxQ4aoBNfyWCq5VTIBSxgvRZi4OZ5y8ddzl bSs39WJWa5ZW78S0kFG/Q4dyIgwJYlqqDyOsl1Qp/6h4hw587HfDmo6+FKOA+q/q8uwC gb321Sd9EaP6DYUj/OuD+rbu+rDnePtTMZvmosm74+leCMwVJs+uEKa55GJ01qglekif 5p4/FrRwv4yt92rJjhs6N5OnT6jiwgUk/c9D214vs1HDFIM2VsBsFmg/9iU3d0oVeOjm l0jpy583yS3qFb99IyM6qFd6YjMEIvPFw4waVb6Xheaad1GO3LaM4o/z+QgBn5lwNyNv pc0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=H04SfkLVT+Iu5PXOCCRindsA0egkTBUvmOhcrJZkV2A=; b=lERzrwDAmgJMO/C4HWjoudaRqRci/8M7qM3Dhh4UnGah6zMkdniCduWjRuWDTtqdgG TnA1NcT2YW9XNOcJ0du5bxtVnsZ/gAXwwBFh9pTnUNWipvaasfIVfHSUtfkn9lpvgoAe WheUWz4A3aGIbqQHTvrCfGeROUSHXU3Mr0YZRrvntlLiHZZ+UvSBnSChpeKWKe7HkkVm RnGc2AFIyqI4yE1Ac7vvYlmWhWhOUkzBC77lE0ZFByUVitgHtRR2T0WI2hfj6452ZQQd QByeQ6Z/eFGIGUTBYje+d/OkAWylKQUsU9X385y8XdhiLB+SMIS5Frn4ZaaeW3Crd15i K7/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p123-20020a622981000000b0063ab35b9d75si1258036pfp.162.2023.05.24.02.39.06; Wed, 24 May 2023 02:39:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240703AbjEXJ2M (ORCPT + 99 others); Wed, 24 May 2023 05:28:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240717AbjEXJ2J (ORCPT ); Wed, 24 May 2023 05:28:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61873130; Wed, 24 May 2023 02:28:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB94763B4B; Wed, 24 May 2023 09:28:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD8B2C433D2; Wed, 24 May 2023 09:28:00 +0000 (UTC) Message-ID: Date: Wed, 24 May 2023 11:27:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7,0/2] media: mediatek: vcodec: add hevc stateless decoder driver in MT8195 Content-Language: en-US To: Yunfei Dong , Chen-Yu Tsai , Nicolas Dufresne , AngeloGioacchino Del Regno , Benjamin Gaignard , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , Nathan Hebert Cc: Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230524080739.17264-1-yunfei.dong@mediatek.com> From: Hans Verkuil In-Reply-To: <20230524080739.17264-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yunfei, On 24/05/2023 10:07, Yunfei Dong wrote: > Add hevc stateless decoder driver to support hardware decode in MT8195, and the driver > need num_delta_pocs_of_ref_rps_idx value to parse slice header short_term_ref_pic_set(). > > patch 1 add num_delta_pocs_of_ref_rps_idx field. > patch 2 add hevc stateless decoder driver. This series clashes with this older series from you: https://patchwork.linuxtv.org/project/linux-media/cover/20230424060130.18395-1-yunfei.dong@mediatek.com/ Can you post a v8 that sits on top of that older series? Regards, Hans > --- > Changed from v6: > - fix AngeloGioacchino's suggestion. > > Changed from v5: > - checkpatch/kernel-doc pass/build pass. > - fix warning: struct vdec_av1_slice_fb -> struct vdec_hevc_slice_fb. > - fix warning: remove unused comment for param "trans_start" and "trans_end" > > Changed from v4: > - fix some comments according to Nathan's suggestion. > > Changed from v3: > - add the dependency patch to this patch series for patch 1. > > Changed from v2: > - fix one build warning. > - add the dependency patch link. > > Changed from v1: > - fix build error when build 32bit system. > - hevc fluster test result: 132/147 (not support: 10bit => 11 and resolution => 4). > --- > Benjamin Gaignard (1): > media: uapi: HEVC: Add num_delta_pocs_of_ref_rps_idx field > > Yunfei Dong (1): > media: mediatek: vcodec: support stateless hevc decoder > > .../media/v4l/ext-ctrls-codec-stateless.rst | 7 + > .../media/platform/mediatek/vcodec/Makefile | 1 + > .../vcodec/mtk_vcodec_dec_stateless.c | 59 +- > .../platform/mediatek/vcodec/mtk_vcodec_drv.h | 1 + > .../vcodec/vdec/vdec_hevc_req_multi_if.c | 1097 +++++++++++++++++ > .../platform/mediatek/vcodec/vdec_drv_if.c | 4 + > .../platform/mediatek/vcodec/vdec_drv_if.h | 1 + > include/uapi/linux/v4l2-controls.h | 6 +- > 8 files changed, 1174 insertions(+), 2 deletions(-) > create mode 100644 drivers/media/platform/mediatek/vcodec/vdec/vdec_hevc_req_multi_if.c >