Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8cc00e92-512a-f65e-ef4a-4ea859ee3e31@kontron.de>
Date:   Wed, 24 May 2023 11:47:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v6 2/5] spi: spi-imx: add support for SPI_MOSI_IDLE_LOW
 mode bit
Content-Language: en-US, de-DE
To:     Boerge Struempfel <boerge.struempfel@gmail.com>
Cc:     bstruempfel@ultratronik.de, andy.shevchenko@gmail.com,
        festevam@gmail.com, amit.kumar-mahapatra@amd.com,
        broonie@kernel.org, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230524091948.41779-1-boerge.struempfel@gmail.com>
 <20230524091948.41779-3-boerge.struempfel@gmail.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20230524091948.41779-3-boerge.struempfel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmxPQzRFNUFJbzhmbTZua0JKaEhjWEhYeDB3dUZScmRETk5zYVdJam80Nm92?=
 =?utf-8?B?ZjZwLyt3eFZaZzljWDNqamdadzd5cXZOWTMvS0EwZDhFMWlQUkZSTnk0MThX?=
 =?utf-8?B?ZTFXblZ0dThObXBrV3NKTTB0aktqMUgwN3FFVFIyV0hwZmphb2luTGJibmcx?=
 =?utf-8?B?dHUxUkd0QjFuMXdCTFVhcmhsMjJ0TGZ4NGx6b0c5MTdCU0Njd0hQMFpDM1hE?=
 =?utf-8?B?SnhvSXBpejlNZWw5dzJURW0ySi9jUXlFcDdjQjhUbnlwZHNhMnVEZ0JCb21S?=
 =?utf-8?B?eHVmYklyV0ptT2o2THoza3VJWkN1TE5sRVdlam9RUUQ2SWNNVXNRZFY1NDcw?=
 =?utf-8?B?Z3QvS2JWUm1Ibk91ZnU2VFI3QS81ZmtUeWZuTitrZ2RmZkhRU0xqQ2h2ZDRG?=
 =?utf-8?B?dGxnaDlxMTZvTzNjQU9Ta3lOZy9iNmh6MWg5TkpJQlhkY2d5Qi9RbGZMTVN1?=
 =?utf-8?B?T2VjZVVVZ3k0a2dNbkZyZUdHRkoxaGF2amFDajUzOWZzdUZEVDloeGdQbU9P?=
 =?utf-8?B?WHRNYkFKTGFablRKdXNIT1l3VnBTaGoza0Q2b0p1d0hFZGFHS09TS01xazln?=
 =?utf-8?B?TkFIdmFlL3dXM0w4dlZMRk4yamJmbWowT0V2UmZmZkltblJUdnExWFpZSTE3?=
 =?utf-8?B?eHpvNlJETlA4OWg0YmpPOGFLdEJCVTZHYUd0VDIrV2JwYWtHMktOQ3l2cCtw?=
 =?utf-8?B?ek5SL2pHUmZubFpGb25kWUxGUEsyNlV0U214VFl3M0NGeC9UVkg5VGh1ODlo?=
 =?utf-8?B?c2JJdndsK0pZekptem55YXgvZGFRYklvdU9NYlNxQy81eC8wQlFkeFp6Nmdm?=
 =?utf-8?B?alI2TWg5cFo4aEVMUlZPZVNOelBENmcvdFlUNEZpUEZFS2tZaWNObXJ4SW44?=
 =?utf-8?B?dnh3ODgvZ1FqSDc5UGNlbzhkUFhVWDNtcXg2NGQ1ZE1aZE1LNVA3WDV4TUg5?=
 =?utf-8?B?RDVrdmZkUUxFc3ZJWmNpOEl3OUtkSFM3R1V0MGF1RUhaYXNBelhRSktFYzcz?=
 =?utf-8?B?SXlDS2NtL1F0RUxHMUJYTDcyYWJmVW85dEQ3b0ZWTWlTMDlyUjE3SnA1ZEFq?=
 =?utf-8?B?VXlTQklqTTN2bWZJU2NYWWxXR3V4L2tYWVFnVkdnN3UySTAzUnlkOGRGT3Jk?=
 =?utf-8?B?QVh2N3RHY1N0WDdtL25wNVlhTzFtTUFQazhVWVg1RzZzakczNEJwcVpWZ0w1?=
 =?utf-8?B?MUkySjlVbU05bnp0Wnoyd0hHdTdXTC9EUXI0d1hxamIySnVyV05QcTRmUmRj?=
 =?utf-8?B?NS9pb25sdVQ3VnB6WmZZR1NWM3VZdFlPUVVHbFR0azBhKzNzZGtGM25kaFlm?=
 =?utf-8?B?OWFmWnFOa21leWFyWGZwVVo0ZUpBYnpteXBROGl4SHZsODFYaXZoVnZIWDRx?=
 =?utf-8?B?cGZpRUlIbXVBZldIWW5yNHVTOFM5M3dobEhQblZQUFhDbVFFcFBGc0hKb1A5?=
 =?utf-8?B?ZXJ4S1Nod2hYVkFoK2VzN1hJN3daamxTN1VvNkNpRkwvaHV5RmlTVjVNdC9m?=
 =?utf-8?B?Z2s0VE5RK3dlb2pKUVp4dFNBZjk2N0FJWkxXTzBqMDZkaW04NW9hSmlZMnJV?=
 =?utf-8?B?c3NiY1dIekR4Zy90S3gxRkNBUCtiQ29nMDNsS3pBQkRqVVZtR3NjZG85Q2NW?=
 =?utf-8?B?SklTQjg2ZnJqTFNEb3cyVUduOXZjZGdETUE2Sy92dmo2Ni9VSUt6bkdmeGZP?=
 =?utf-8?B?YVlodUZDVndoR0ROWWo0UTIwK0VBVG9WMXlSeVQvS3lOaEUyaXZRSTNTaGJ4?=
 =?utf-8?B?amRENWVlRXBpbDBWM3RPWm9oZDJrSk9LQXpnUjZrbHkwSURRSE9SbngxVGgw?=
 =?utf-8?B?VlVWeTQzalp1TW10MXc3K2ZKcU80amdWMW5XcHYwRUxoZ09nc0RRYmlva1Fi?=
 =?utf-8?B?VkFXMGxraUI2bFAxV1hWYUI4a1QrL2lncVZsbkpsZkVVUGg1SStYTTFrek1E?=
 =?utf-8?B?RHEyMlRmdEVCdk1SZHFoYTRQN0E2a3FxYkZuU0ZZRVBmWm1tazJoeXk5NXcy?=
 =?utf-8?B?RmdWazZ0VVJwRlhRQlpmcEFBcnNmSXFYZlF6WlVBbmtHNThiK1BRZHpnNXRU?=
 =?utf-8?B?Q1VpWTBUR3ZvNUJpZTJIRGxnU3BOSGxLaWxhVFhSQU80MVZVem53Qm9PenRN?=
 =?utf-8?B?SFVXWjJvMXF3M3B5S0xROUttNnU4UllCMy9SeVpsWUZ3czhaSFNpNm5jYlBn?=
 =?utf-8?B?Z0E9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bac0e46-9548-458e-0af5-08db5c3bd722
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 09:47:08.6771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7IqhiOL7f/vtn3vTH5ovRtSGitcAfFY8NFtIkf0EI9mJtJzMvhAXsxUEy3rdAH4BCJRG5Kg6UAyIaI5UGgjpYGnIalJQf/k26jbdFJW+m6A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3645
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.05.23 11:19, Boerge Struempfel wrote:
> By default, the spi-imx controller pulls the mosi line high, whenever it
> is idle. This behaviour can be inverted per CS by setting the
> corresponding DATA_CTL bit in the config register of the controller.
> 
> Also, since the controller mode-bits have to be touched anyways, the
> SPI_CPOL and SPI_CPHA are replaced by the combined SPI_MODE_X_MASK flag.
> 
> Signed-off-by: Boerge Struempfel <boerge.struempfel@gmail.com>

Thanks for working on this! We used a similar downstream patch for
driving NeoPixels with i.MX. I'm happy to see a proper upstream solution.

I also have this Python module [1] around for using spidev to drive the
LEDs. It would be nice to see support for SPI_MOSI_IDLE_LOW in py-spidev
[2] so we could use it there. Though the latter looks a bit like it is
not properly maintained anymore.

[1] https://github.com/fschrempf/py-neopixel-spidev
[2] https://github.com/doceme/py-spidev

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>