Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Date:   Wed, 24 May 2023 11:49:22 +0200
From:   Robert Richter <rrichter@amd.com>
To:     kernel test robot <lkp@intel.com>
CC:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>, <oe-kbuild-all@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: Re: [PATCH v4 13/23] cxl/hdm: Use stored Component Register mappings
 to map HDM decoder capability
Message-ID: <ZG3cpEj9k8S9DMAA@rric.localdomain>
References: <20230523232214.55282-14-terry.bowman@amd.com>
 <202305240842.zr8PTfcu-lkp@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <202305240842.zr8PTfcu-lkp@intel.com>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 09:49:28.2490
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 626655b5-32ed-4395-eb76-08db5c3c2a71
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT106.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7159
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.05.23 09:12:24, kernel test robot wrote:

> >> drivers/cxl/core/hdm.c:128:26: warning: no previous prototype for 'cxl_port_get_comp_map' [-Wmissing-prototypes]
>      128 | struct cxl_register_map *cxl_port_get_comp_map(struct cxl_port *port)
>          |                          ^~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/cxl_port_get_comp_map +128 drivers/cxl/core/hdm.c
> 
>    127	
>  > 128	struct cxl_register_map *cxl_port_get_comp_map(struct cxl_port *port)

This should have been 'static' and also solves the warning then. Will
change.

-Robert

>    129	{
>    130		/*
>    131		 * HDM capability applies to Endpoints, USPs and VH Host
>    132		 * Bridges. The Endpoint's component register mappings are
>    133		 * located in the cxlds.
>    134		 */
>    135		if (is_cxl_endpoint(port)) {
>    136			struct cxl_memdev *memdev = to_cxl_memdev(port->uport);
>    137	
>    138			return &memdev->cxlds->comp_map;
>    139		}
>    140	
>    141		return &port->comp_map;
>    142	}
>    143