Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aee8ff85-5716-424e-3773-33700fd90dc2@linux.intel.com>
Date:   Wed, 24 May 2023 19:52:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] serial: 8250_pci: remove unreachable code for ASIX
 devices
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230510142855.256658-1-jiaqing.zhao@linux.intel.com>
 <2023051343-cringing-junction-54f7@gregkh>
 <188db6e4-d1de-6643-f6e1-5cb3807b28ee@linux.intel.com>
 <2023051533-harmonize-ozone-bc72@gregkh>
Content-Language: en-US
From:   Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
In-Reply-To: <2023051533-harmonize-ozone-bc72@gregkh>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023-05-15 11:49, Greg Kroah-Hartman wrote:
> On Mon, May 15, 2023 at 10:36:30AM +0800, Jiaqing Zhao wrote:
>>
>>
>> On 2023-05-13 18:28, Greg Kroah-Hartman wrote:
>>> On Wed, May 10, 2023 at 02:28:56PM +0000, Jiaqing Zhao wrote:
>>>> PCI_VENDOR_ID_ASIX (0x9710) is the same as PCI_VENDOR_ID_NETMOS. In
>>>> pci_serial_quirks array, the NetMos entry always takes precedence over
>>>> the ASIX entry. So the code for ASIX devices is always unreachable,
>>>> even when it was initially merged. Since the NetMos vendor driver
>>>> doesn't mention such FIFO bug, it's safe to remove the code.
>>>>
>>>> This reverts commit eb26dfe8aa7e ("8250: add support for ASIX devices
>>>> with a FIFO bug").
>>>>
>>>> Signed-off-by: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
>>>
>>> Please follow the documented Intel kernel developer requirements before
>>> you submit this again, based on the changes that process will require.
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Sorry I am unable to find this "Intel kernel developer requirements". Is
>> there any link or contact where I can find this information? Thank you.
> 
> Contact the Intel Linux developer team and they will point you at them.
> This is a company-wide requirement, it is odd that your normal "Here is
> how you can contribute to Linux!" training at Intel did not cover it?
> 
> thanks,
> 
> greg k-h

I contacted them and there is no reply so far. Could you please tell me if
there is any general available docs about this or point out what I'm doing
wrong in this patch? Thank you very much.