Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 09:07:38 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH v4 00/10] Clean ups for maple tree
Message-ID: <20230524130738.xdhtdvpyvbxedk4n@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230524031247.65949-1-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230524031247.65949-1-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JWdtWLSitBIHANc2YhWQs71+LWH77x1KnLDCIcB+u85c6mUH15aFcJgYwrs+?=
 =?us-ascii?Q?hy2NedtMciT+BjaOTd91z25ErxF7CyRE8/rInbnaosmm4QqMDH/i+NunVA7+?=
 =?us-ascii?Q?PEVf6OzVQ3ez25vBt+TP2B50QzH5hYWV8BhP1lMJZxAUzCtys4CHXrZX/k17?=
 =?us-ascii?Q?pSa7gVa8qIvYPNcekHanwgXqIKO7XIYw8FCBTZm2PEpCYGGLV7eQv3QAh/oL?=
 =?us-ascii?Q?suLgpqR9o/YAufKaOCpjqYdhWdIB9yU2HpFzb2WO1/VQTrhcfJlyMZqYZYv/?=
 =?us-ascii?Q?6rBd62h9IYI7EI6n/lHrvYEt3+klcLWgHzJqWn32BwmJCWGOR2pRhePwifnM?=
 =?us-ascii?Q?G4uZvaYZFVncOoyetwZCZvhMBnLihgu1GZcJQPhUf6D0pYgQfvXVTpGYCcJj?=
 =?us-ascii?Q?WPGwkuWgx1ifuJtdL/F2xrLgzCRkln/Bf6GX5iJrW3birMZfkX1bDuEnVcba?=
 =?us-ascii?Q?EHiJ/tFxkWHBqQD8gGlyMNbGeVJmUxSQPS+Ind/s3d7EGPYLbuLiN06bV19C?=
 =?us-ascii?Q?Flb6cJqNfA+EgqIdWvtrGtU5p2MjkcbQVl8sDowAc/Wk9/qy859GPjjg2JmM?=
 =?us-ascii?Q?4VlX0WWDBKE509tCfkNvV7V0ENsIjQXBBDnymznoI5zVFn26FNvuEMTSWwN3?=
 =?us-ascii?Q?HjWVRyqhTd0XhM4mOkbB0Wjqonz1wpP8tIoS7jPj1D3anK85Z99JBuNrLmYI?=
 =?us-ascii?Q?mH/tpOjgwlI+yGmuY371PeBHWsGEHafyUfElvSazYAuqqMlL1JfNgpr39zWe?=
 =?us-ascii?Q?7wYtyJa3rKkOHc7Kb1GdCcrhjElB0eGSwXVgSOJk40XVyC5eFqUICKFMS3Ed?=
 =?us-ascii?Q?uCSGApxO7RbZEwIHzQFsYF6euk4bW3FnWz6erEbZE1kXY4U3rUoVyEVAhdyp?=
 =?us-ascii?Q?4gNxbDSccG657UxV4lwEM3HVOTUMjHiseWhGl3/iqSSYUC8sEa+IUw1IKyFf?=
 =?us-ascii?Q?8EgH8OvaJ4PyCY7fZGL7f6uYa0dd/6IUegCIIKn4RLWXQrzQF1y94kb8g7dZ?=
 =?us-ascii?Q?rX2SsgZajm1DgbKCZxzoGP/rSFXBCvNYU5JU2RQDoeWN/EThBWLdv+mhZBFB?=
 =?us-ascii?Q?+UKAyXeuWw+j/YWHvNNo9anLuC2aBilaOTwvihCo7GpfivvPwlnBKU9E/H9+?=
 =?us-ascii?Q?5mcCG+I62pM5VZ11FepnKBLR45z3aaZ/MKGxPDOuJDdwy/za1+cHb1NvabY1?=
 =?us-ascii?Q?dakGIeOITFfdBVJwr30aO3UGOzYTUhinyTmp3yXyoLIoftx5Lg140rRvScUg?=
 =?us-ascii?Q?94wXwuvd+VSUUYzLdpTZwFovRLyxe3iw0LJQ2cDc5sOCh/2khWSc0jQYca6Y?=
 =?us-ascii?Q?jHB5DMjIkMi9V5NRuJV24Oz+TRtbz8aRY74MQLjJfxJAw74+7QB5f4+v/3P1?=
 =?us-ascii?Q?y0PoLaiYeKbwZQBEWnWekfNrxQC9yQ30NzUBQwSeecnhysIsOP4NHbhLO9mY?=
 =?us-ascii?Q?FWU7TWqIiyC0f5GurjUnCTdiy/mkwnOf/L38aZrLWq+nCA6zJvpSarHpZLWB?=
 =?us-ascii?Q?krKxq2VVyemyQtpaednnbicheXaPNL+v8Y+wavk6bsNo0zpweulhwsOD+xXi?=
 =?us-ascii?Q?aaG2cxcgTgSZuJVg07RYT/c+uiEFoilEcZnQNA4TErm/xBDMc8Qqh7iBLfry?=
 =?us-ascii?Q?Iw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?9MBq9WSSMbk71Kkf8+dIL1008+6F9ZIq89aQD2GmUDhWebFPaFzruGQPV1ek?=
 =?us-ascii?Q?5Qi4av/iiDNU6IzWPa6iLvHAm2eTnlv7gy8s2VV4coi77Nc/LaTF+Y5tcJqm?=
 =?us-ascii?Q?WI1sxuH4HyBiPumQUetrol45q3Khmdn8CURwEOy6Fl8/4ufcjKrsXgl8+RNw?=
 =?us-ascii?Q?Upac0cjI3wCnAa9MwtNLiZOb54kjQnmn1EtdhpkNtdqwEcsli4YRhd1rlfuj?=
 =?us-ascii?Q?/uedcXaqee4hUnBOB1odNxpWj/ztBf33KszAhEd7Aqu1083b7aPGcQfOSY0F?=
 =?us-ascii?Q?c75rEKwEIMcj4q6OJkFkAvQ+t/0caznzVb2LjDkkp5OamAPKzcbDn6C1PwSn?=
 =?us-ascii?Q?M8spqZ8xaJp31QxhOgEI5Qot8GaQBgkLvbw6IbQpAHqvFpZ0MPggQlN72Xon?=
 =?us-ascii?Q?1g0+hxJy5C63TqGXMbfGk5NIFjWmpk5zatA4dkYN2CdgczuAz2KtRD9Sj+0E?=
 =?us-ascii?Q?+hFuBAw2azBP2WinaHOkCH4gzvR3I1MZERCv8Oq5NM2ChhfOlwnINEu1SejE?=
 =?us-ascii?Q?LWQGOrz2vIBEVBuB2TNWRLl9crX/lQ+B4ZRtbp3CvSU7Mo7xWF7+h9NA9pZQ?=
 =?us-ascii?Q?nNyIGdet8W9KzTMVDUJy7eDQysj6KBR4gvFcs6XqYTr150Gcp/UZOcAI5SgU?=
 =?us-ascii?Q?065SKwjJ8PHMgD/4vPdAzWLyHbvuUIKpmM8KA2wstDals/GIygU39DV+Snpd?=
 =?us-ascii?Q?tyYHL5fTJ4WVmAGRLAr3htSa0VTy4Eqc7wGIH+FzPoI2VluwbyjJBcCR+PGy?=
 =?us-ascii?Q?BjTebjWAddTVAhwg/u6YwU9dCDJ4+M/rw1Xc8eHgW/8GLlHv2OppzY/KWeM/?=
 =?us-ascii?Q?IupllqY6uW/u+XzwTu3ufXy3U0snFpIEXayAfK6squiEso5nusD7kxjpqk2K?=
 =?us-ascii?Q?wVrlQuRZBSd/VT8KtVfAXb8tIJscUPn8AyrPNTEty2JpWviq+WamcC25urje?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7db32fbd-24aa-43b7-9b52-08db5c57dad2
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 13:07:40.7185
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b7/dTR0kxjbllArhkmyVSy0MB9KCljRCJw/JkIsCJ/nVnO50++Z44EGw+ZnIt7HQ5SzVFuD2CsKiJi7Job5hOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7105
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-24_08,2023-05-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=573 phishscore=0
 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305240108
X-Proofpoint-GUID: WLxILtf0Qe-FSElYt-Vsb3JC41qFuDif
X-Proofpoint-ORIG-GUID: WLxILtf0Qe-FSElYt-Vsb3JC41qFuDif
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230523 23:13]:
> Some clean ups, mainly to make the code of maple tree more concise.
> This patchset has passed the self-test.

Thanks, this is a nice clean up.

Andrew, Please add these to your list of patches, they all have review
tags in the commits.

> 
> Thanks Liam for the review.
> 
> Changes since v3:
>  - Modify the commit log [02/10] [08/10]
>  - Remove some comments [04/10]
> 
> v1: https://lore.kernel.org/lkml/20230515131757.60035-1-zhangpeng.00@bytedance.com/
> v2: https://lore.kernel.org/lkml/20230517085809.86522-1-zhangpeng.00@bytedance.com/
> v3: https://lore.kernel.org/lkml/20230522050656.96215-1-zhangpeng.00@bytedance.com/
> 
> Peng Zhang (10):
>   maple_tree: Rework mtree_alloc_{range,rrange}()
>   maple_tree: Drop mas_{rev_}alloc() and mas_fill_gap()
>   maple_tree: Fix the arguments to __must_hold()
>   maple_tree: Simplify mas_is_span_wr()
>   maple_tree: Make the code symmetrical in mas_wr_extend_null()
>   maple_tree: Add mas_wr_new_end() to calculate new_end accurately
>   maple_tree: Add comments and some minor cleanups to mas_wr_append()
>   maple_tree: Rework mas_wr_slot_store() to be cleaner and more
>     efficient.
>   maple_tree: Simplify and clean up mas_wr_node_store()
>   maple_tree: Relocate the declaration of mas_empty_area_rev().
> 
>  include/linux/maple_tree.h |  12 +-
>  lib/maple_tree.c           | 450 +++++++++++++------------------------
>  2 files changed, 156 insertions(+), 306 deletions(-)
> 
> -- 
> 2.20.1
>