Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 19:51:20 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Francesco Dolcini <francesco@dolcini.it>,
        Andrew Lunn <andrew@lunn.ch>,
        Praneeth Bajjuri <praneeth@ti.com>,
        Geet Modi <geet.modi@ti.com>,
        "David S. Miller" <davem@davemloft.net>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Dan Murphy <dmurphy@ti.com>
Subject: Re: DP83867 ethernet PHY regression
Message-ID: <ZG4ISE3WXlTM3H54@debian.me>
References: <ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="G6zBKAl4QuB1XUdm"
Content-Disposition: inline
In-Reply-To: <ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com>
Precedence: bulk


--G6zBKAl4QuB1XUdm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 22, 2023 at 04:58:46PM +0200, Francesco Dolcini wrote:
> Hello all,
> commit da9ef50f545f ("net: phy: dp83867: perform soft reset and retain
> established link") introduces a regression on my TI AM62 based board.
>=20
> I have a working DTS with Linux TI 5.10 downstream kernel branch, while
> testing the DTS with v6.4-rc in preparation of sending it to the mailing
> list I noticed that ethernet is working only on a cold poweron.
>=20
> With da9ef50f545f reverted it always works.
>=20
> Here the DTS snippet for reference:
>=20
> &cpsw_port1 {
> 	phy-handle =3D <&cpsw3g_phy0>;
> 	phy-mode =3D "rgmii-rxid";
> };
>=20
> &cpsw3g_mdio {
> 	assigned-clocks =3D <&k3_clks 157 20>;
> 	assigned-clock-parents =3D <&k3_clks 157 22>;
> 	assigned-clock-rates =3D <25000000>;
>=20
> 	cpsw3g_phy0: ethernet-phy@0 {
> 		compatible =3D "ethernet-phy-id2000.a231";
> 		reg =3D <0>;
> 		interrupt-parent =3D <&main_gpio0>;
> 		interrupts =3D <25 IRQ_TYPE_EDGE_FALLING>;
> 		reset-gpios =3D <&main_gpio0 17 GPIO_ACTIVE_LOW>;
> 		reset-assert-us =3D <10>;
> 		reset-deassert-us =3D <1000>;
> 		ti,fifo-depth =3D <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> 		ti,rx-internal-delay =3D <DP83867_RGMIIDCTL_2_00_NS>;
> 	};
> };
>=20

Thanks for the regression report. I'm adding it to regzbot:

#regzbot ^introduced: da9ef50f545f86
#regzbot title: TI AM62 DTS regression due to dp83867 soft reset

--=20
An old man doll... just what I always wanted! - Clara

--G6zBKAl4QuB1XUdm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZG4IRAAKCRD2uYlJVVFO
o5qfAQDwUI5i8vhNfuMRPTkr53hzcc3BMXEOS2dbl0R+Acl0NAD/Us8OljgaYCr2
IRxQ5ohMdzwq4B8pLzs3Fl4LanHLHQY=
=T8Bf
-----END PGP SIGNATURE-----

--G6zBKAl4QuB1XUdm--