Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31f2a49f-bc48-d502-df31-667ef1a83fab@axentia.se>
Date:   Wed, 24 May 2023 14:49:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] mux: mmio: select REGMAP as the code has that dependency
Content-Language: sv-SE
To:     Philipp Zabel <p.zabel@pengutronix.de>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <64cf625b-2495-2382-0331-519d1cab0adf@infradead.org>
 <d1a3d8dd-213b-3772-17a7-c08e06cab837@axentia.se>
 <89199aca-5b57-e8df-03ca-b2658ee9d8b3@axentia.se>
 <20230210115625.GA30942@pengutronix.de>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20230210115625.GA30942@pengutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlhaOGM4eVhhbGN2ZnpwbzYxNUh6aURpM2NVV0V1aGthbXNHQ1BEdkd6VGZi?=
 =?utf-8?B?a2tCVWEyVWlDMytudDIvSkdFYmZVSko4NW8yZXVNLzNnUzZDOUR3TURkR3hy?=
 =?utf-8?B?dE5DR3g2UUduT0MwOWkyb2w3dnNrdnZNMlR4QkRFK1lVSlpTZUlOeEw3ZkhE?=
 =?utf-8?B?RFZMK1JTZmFIK0xnaElJZStDNEFBcit6Kzh5MFNkOWlFcHlEdm54S3ZsVUV2?=
 =?utf-8?B?ZXFvcVhOZ0Y4Wnk3bHdWbWlpZWc4U24wM3I3alVkVzd6V25qSFVyY1piZTlk?=
 =?utf-8?B?Qk5MeU1qNUVsSEhGUWlpOUM4UndnbzZyRi9MSXhmMHJwUEYxSElTaWY3Um5l?=
 =?utf-8?B?b3haZmltNlRTT0t5Skk5bDFTR3YyK20xQ2VIYkpuRElxaDhqN3lpMFQ2L1N2?=
 =?utf-8?B?eUZIb3dLS08xdDlNalZWSmlTWW5EUTRFNE9CMnQ5c0dXZ1V0S2JyQ1pqdjdm?=
 =?utf-8?B?Tkdnd0tyUGJWQ2tMZjJVMEc2bWUyaXRidE9Ea1FKRHZuMnFCS2NJeCtSdHQ1?=
 =?utf-8?B?czQ1YXpGY01zWFpLOWxXN21VSDl4VWtTM2hLRU81SDZ1dmNmWWdlQ1pmOVUz?=
 =?utf-8?B?bXBySEhkRktIYmVCU3VQdTE1dE5xWmxtU0RVclRRR3lIelBoUE85T2pSYjd6?=
 =?utf-8?B?RmhlY3V2U3ByTXZ6Z0gyaDhDRUMvLzVHMWQ3Sk5QMnRERUJQUUZzc2o3eEVj?=
 =?utf-8?B?UzllelA0eUpHTUdmd3Qvcmp2aHIvS2dPNjhOYktwYk1LRDNRbjZGYTc2MEpO?=
 =?utf-8?B?L3ppRWJFMk1Gb0haa01tOGYzSlUwWm9URytiTm16N3A2TnE0MXhYM0ltWFYv?=
 =?utf-8?B?WG45RURLd2tSRnNUaTB5NnFsb3VoL2dxbTRrbHJaakFNQ0JEbDRkeDd4MU45?=
 =?utf-8?B?Z3BaYjVxT0Q3QWE5ZEY5OHJmaVNJcGFvT05IYXR2SStidDlkeXdtdE94UVlx?=
 =?utf-8?B?T3ZkNEpLcjFmRHg2K0d0SUd0bU5vYkYraUo0RDhTQ3ZPMlcrR1IwY083OHI1?=
 =?utf-8?B?UHFnSmU5aXBPOEJIa2VnWlpXRU1MMDRJclZYWkJReDNEUXNkOW9sOWVoTnRW?=
 =?utf-8?B?M1o4djIvUnNsZ2dNREtrWXJBY0FHdTBiL28wZWVaTEZtb2tzekRVMUFxd2kv?=
 =?utf-8?B?QkQwb1Rscm5ESFhvR3JRSVgxU21OVzlCY09uOE5MYkRHRDJMeWsxaE9lemM2?=
 =?utf-8?B?NXdxNTBZWDlBL0FKY0tsSjByUWp2b2g0RG9VcGJacU8rUmFsODRURDNVTWx6?=
 =?utf-8?B?RFJGcFFxZ0hBaGMyaXFnU0R1bFdRbHlDOTJYNWZmdUVZUFo0Z2h2b3JiU1hy?=
 =?utf-8?B?ajZPVmErL0Jzd0pQZE53SzR5aGgvaFB5dytqVWZvbG0wRVNxcFFFcmJtRHl1?=
 =?utf-8?B?emRoK2ltN2x0b2RSU3dwbXJzUFpoSXlUb2p6S2Q4NEkzODNBZk9MbHkwczhO?=
 =?utf-8?B?bmk1SSt0c0NFVVQ3QmFtdURZZTNNR0JKbVZWV1dPOTM0UXMvMlRYVkNFbEho?=
 =?utf-8?B?RmpaYXNDQWE1ZXk0NVJSYnlsNjVlS0NtNDZxS0NJZVBaclc1dGh3Y0xqRUox?=
 =?utf-8?B?ZmJqZFp3RXQvM3JLNldUMXNwTnF0YTZkZFROMXl4dUdQWnRzWGFnVmpnaFNH?=
 =?utf-8?B?TjlHbUwrakFWUDZsZEVuM3VNSG5JMGpuYjkwUzlKWTVEOXVQU3cyOWllWFY3?=
 =?utf-8?B?ZkdhSHcvV1NxYVU0OWNyK0V4Mnc4K2tuV2ZoOUdZNTk1L3lSYUN6cnpTV3lZ?=
 =?utf-8?B?QTZmcVhXRzFkQzVXcXgvRzFRZFRwVmQ4TjBLaHNBUldsMUVUdmdrdmdKeTFB?=
 =?utf-8?B?eUtTLzNwcGloRmp0WmtqWHd3dXNuUEdwc0hsZDMzcDh4ZWo1b2tuK1RjRHVm?=
 =?utf-8?B?VmtuRmozRzVPOVpUbXVUVjA0dDZiNS8wcFc2MFlkeWZnUVV1RVpjR0xqRnE1?=
 =?utf-8?B?N2hnZFVRTnIwdHh4S1piQWpVOEhRZFNDZjc2eDR0QjR6NUZXTDBRWmxubDNM?=
 =?utf-8?B?d3ljVEJnQlh3NXBmNXlNMGt5RmpBVXUzZzBtZFVBS2orK3JOeVF0MlZYcWVs?=
 =?utf-8?B?UnkwKzRySnBLNjJJM3NSTitEck1XejVwWVZOcEZiTHpyM2h4ajczcFE5R2dq?=
 =?utf-8?Q?YnnDV5UJCRGYkDojOlI50Rr0A?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 91933d6e-36ff-4783-739a-08db5c554637
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 12:49:12.6578
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pjYDDJX8acyHPHWbINDRcD3wI/YI/nQm6Nzo6GrsB95wFtW1v2Eje91GXJoxd7Gr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR02MB9229
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

[sorry about the delay, busy-busy]

2023-02-10 at 12:56, Philipp Zabel wrote:
> On Fri, Feb 10, 2023 at 11:46:42AM +0100, Peter Rosin wrote:
>> If CONFIG_REGMAP is not active, the build errors out like this:
> 
> The driver used to have an indirect dependency on CONFIG_REGMAP via
> CONFIG_MFD_SYSCON -> CONFIG_REGMAP_MMIO -> CONFIG_REGMAP until
> commit 8ecfaca7926f ("mux: mmio: add generic regmap bitfield-based
> multiplexer").
> 
>> ../drivers/mux/mmio.c: In function ‘mux_mmio_probe’:
>> ../drivers/mux/mmio.c:76:34: error: storage size of ‘field’ isn’t known
>>    76 |                 struct reg_field field;
>>       |                                  ^~~~~
>> In file included from ../include/linux/bits.h:21,
>>                  from ../include/linux/bitops.h:6,
>>                  from ../drivers/mux/mmio.c:8:
>> ../include/linux/bits.h:23:28: error: first argument to ‘__builtin_choose_expr’ not a constant
>>    23 |         (BUILD_BUG_ON_ZERO(__builtin_choose_expr( \
>>       |                            ^~~~~~~~~~~~~~~~~~~~~
>> ../include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’
>>    16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
>>       |                                                              ^
>> ../include/linux/bits.h:37:10: note: in expansion of macro ‘GENMASK_INPUT_CHECK’
>>    37 |         (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
>>       |          ^~~~~~~~~~~~~~~~~~~
>> ../drivers/mux/mmio.c:96:29: note: in expansion of macro ‘GENMASK’
>>    96 |                 if (mask != GENMASK(field.msb, field.lsb)) {
>>       |                             ^~~~~~~
>> ../include/linux/build_bug.h:16:51: error: bit-field ‘<anonymous>’ width not an integer constant
>>    16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
>>       |                                                   ^
>> ../include/linux/bits.h:23:10: note: in expansion of macro ‘BUILD_BUG_ON_ZERO’
>>    23 |         (BUILD_BUG_ON_ZERO(__builtin_choose_expr( \
>>       |          ^~~~~~~~~~~~~~~~~
>> ../include/linux/bits.h:37:10: note: in expansion of macro ‘GENMASK_INPUT_CHECK’
>>    37 |         (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
>>       |          ^~~~~~~~~~~~~~~~~~~
>> ../drivers/mux/mmio.c:96:29: note: in expansion of macro ‘GENMASK’
>>    96 |                 if (mask != GENMASK(field.msb, field.lsb)) {
>>       |                             ^~~~~~~
>> ../drivers/mux/mmio.c:102:29: error: implicit declaration of function ‘devm_regmap_field_alloc’ [-Werror=implicit-function-declaration]
>>   102 |                 fields[i] = devm_regmap_field_alloc(dev, regmap, field);
>>       |                             ^~~~~~~~~~~~~~~~~~~~~~~
>> ../drivers/mux/mmio.c:76:34: warning: unused variable ‘field’ [-Wunused-variable]
>>    76 |                 struct reg_field field;
>>       |                                  ^~~~~
>>
> 
> Fixes: 8ecfaca7926f ("mux: mmio: add generic regmap bitfield-based multiplexer")

Right, I'll add that.

>> Reported by: Randy Dunlap <rdunlap@infradead.org>
>> Link: https://lore.kernel.org/lkml/64cf625b-2495-2382-0331-519d1cab0adf@infradead.org/
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>>  drivers/mux/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> Note, there is a patch in linux-next that removes "|| COMPILE_TEST" from depends.

Still true, haven't gotten around to pushing that upstream. Sorry. Busy-busy...

>>
>> Cheers,
>> Peter
>>
>> diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
>> index 80f015cf6e54..9234f8c400ca 100644
>> --- a/drivers/mux/Kconfig
>> +++ b/drivers/mux/Kconfig
>> @@ -48,6 +48,7 @@ config MUX_GPIO
>>  config MUX_MMIO
>>  	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
>>  	depends on OF
>> +	select REGMAP
> 
> I get a dependency loop with this:
> 
> drivers/net/ethernet/arc/Kconfig:19:error: recursive dependency detected!
> drivers/net/ethernet/arc/Kconfig:19:symbol ARC_EMAC_CORE is selected by ARC_EMAC
> drivers/net/ethernet/arc/Kconfig:26:symbol ARC_EMAC depends on OF_IRQ
> drivers/of/Kconfig:69:symbol OF_IRQ depends on IRQ_DOMAIN
> kernel/irq/Kconfig:60:symbol IRQ_DOMAIN is selected by REGMAP
> drivers/base/regmap/Kconfig:6:symbol REGMAP is selected by MUX_MMIO
> drivers/mux/Kconfig:48:symbol MUX_MMIO depends on MULTIPLEXER
> drivers/mux/Kconfig:6:symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER
> drivers/net/mdio/Kconfig:261:symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_DEVICE
> drivers/net/mdio/Kconfig:6:symbol MDIO_DEVICE is selected by PHYLIB
> drivers/net/phy/Kconfig:16:symbol PHYLIB is selected by ARC_EMAC_CORE
> 
> (on next-20230210).

Right. It seemed so obvious that I failed to even compile test before
sending the patch. LART applied to self. Sorry.

I'll follow up with a v2 shortly.

Cheers,
Peter