Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5813927rwd; Wed, 24 May 2023 07:09:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ65U38riP5yBpehZbKVAJb58IHX1wndL1xF7Z5uJGvseLV9opwFE0Z80IIbVBG8HyJ75gV2 X-Received: by 2002:a05:6a20:a10c:b0:105:23cf:747d with SMTP id q12-20020a056a20a10c00b0010523cf747dmr18254750pzk.5.1684937353831; Wed, 24 May 2023 07:09:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684937353; cv=none; d=google.com; s=arc-20160816; b=pQkCkZvpaDjLTNTlCwT65Qc9cOU2GojGQEdGwi9nQh/eXzFwYmrr/GLXTfcptaLPvi Hcgsc4wR0wCkV+N74eeWa6GqPIcSmH768oqUUxEEDIucmgYG461kQJC3tVBBnZ3vRQ8r 36r/4c9ADciMhR61ClrcLQTGV8LNvLvXKKRqM/ThQb05AZlhPoAp+nTXixZ+H1y7JMM7 aB7PXeucFYPEO9iWFORBPzj5cxplnOtncCI9stntkT59go+uSboHiAQBY7omeMEeM0GH zQID/OJKxxWmaf0dg0x9WhWkxeM6ddkW/iEGZ5h3wSbrMVEtGBA1S4URSIfPGii62Lvo z0Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=RAAm+AX0qyb+kRbhxWkN1xkrpeGaJzZQEwR5kRwe2Nw=; b=iawAw84wfCWzhnwIwZCsKoRfJI0InVHX8YcLwXr1m7p3ypO/3/j4yqntdC5vzH+v8s Us5/vbZhn8l6BRVN1HsjCVmfBlX618ge6gQUyfkrFOMlAMgCBViVZAWsCrlfRgXsp/O6 /Yr1FOlO5KQu9+8KkOuBs18mIicRM8jM4DZ+7xQjZjgBTaGv1O4HYJpII9C/Zdpi5gwr vi7yfveFym6MisOS2LekDL5mTxBeZP/3xTZXq0QCwVdwmWQmS739cexHz07q8CtH/Ufe 7TB46ozPU7Tv4zouu4wZIidtDE5gjhxy3Q8cKrF7B+AAhVWBMX0u9fZPOLd219j2EmAx C8GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=kMTpYOYi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv187-20020a632ec4000000b00533ffeaca3dsi8131416pgb.40.2023.05.24.07.09.00; Wed, 24 May 2023 07:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=kMTpYOYi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235670AbjEXOBk (ORCPT + 99 others); Wed, 24 May 2023 10:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235661AbjEXOBi (ORCPT ); Wed, 24 May 2023 10:01:38 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 798459E; Wed, 24 May 2023 07:01:37 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34OCxk8w017501; Wed, 24 May 2023 16:01:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=RAAm+AX0qyb+kRbhxWkN1xkrpeGaJzZQEwR5kRwe2Nw=; b=kMTpYOYiRB6jJbKtryLg7tWY8/FSoXts15ruhQzQ0ufCRJeoEitDNiPAhTePtqwL5Ou+ 2zlvdcpRXH8UkEcUMXwnvNAsbYsLfPJGTn+WQCUdM6KND3lZOw04C+Bsqvbv4Ziu3nEk uFAVgopKzQi09gNs+Or3Jf4yC0Q9Ym/TwemN6scyjw1NbZsRyON2iRKVEyHf063O0ghs Qo8s3Tj+/hTnXE5OLREvjYEPXBrf+FQDAV9EPtVebl5b8io7yIkyj9MgW360zTH0JNyj j581Udh60uj3NOsIzQtn4JQIjhfxdS4iCDQgr29PWbmXtMyE+vvutrRnFfOXE5NMXPuW 7g== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3qrspnsf9s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 May 2023 16:01:19 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2416910002A; Wed, 24 May 2023 16:01:18 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id EC59822A6EF; Wed, 24 May 2023 16:01:18 +0200 (CEST) Received: from [10.201.21.9] (10.201.21.9) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 24 May 2023 16:01:15 +0200 Message-ID: <18a8528d-7d9d-6ed0-0045-5ee47dd39fb2@foss.st.com> Date: Wed, 24 May 2023 16:01:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH 1/4] tee: Re-enable vmalloc page support for shared memory Content-Language: en-US To: Christoph Hellwig CC: Bjorn Andersson , Mathieu Poirier , Jens Wiklander , , , , , References: <20230523091350.292221-1-arnaud.pouliquen@foss.st.com> <20230523091350.292221-2-arnaud.pouliquen@foss.st.com> From: Arnaud POULIQUEN Organization: STMicroelectronics In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.21.9] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-24_09,2023-05-24_01,2023-05-22_02 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Christoph, On 5/24/23 08:46, Christoph Hellwig wrote: > On Tue, May 23, 2023 at 11:13:47AM +0200, Arnaud Pouliquen wrote: >> This patch revert commit c83900393aa1 ("tee: Remove vmalloc page support") > > As per the discussion back then: don't just blindly do the same dumb > thing again and fix the interfae to actually pass in a page array, > or iov_iter or an actually useful container that fits. > I suppose your are speaking about this discussion: https://lore.kernel.org/all/20221002002326.946620-3-ira.weiny@intel.com/ If I'm not mistaken, I should modify at tee_shm_register_kernel_buf API and register_shm_helper inernal function, right? Seems that Jens has also pointed out the free part... What about having equivalent of shm_get_kernel_pages in an external helper (to defined where to put it), could it be an alternative of the upadate of the tee_shm API? Thanks, Arnaud