Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5886450rwd; Wed, 24 May 2023 08:04:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Y/phH66jORxEoDbBUIOT75YckD9CQ95fMC3EsuCQ98ul0nwqp5u1dN5YaNiOQE1tmCsWO X-Received: by 2002:a05:6a00:c8d:b0:64c:9972:f74b with SMTP id a13-20020a056a000c8d00b0064c9972f74bmr3445820pfv.12.1684940648397; Wed, 24 May 2023 08:04:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684940648; cv=none; d=google.com; s=arc-20160816; b=lY9GtljqLzycgeF0qE5PS4ymYVE7LtKRqeS7Rs3pFsO6cbkNW4U1MDjfwX7kuXWBXL uooG/EeiE6EEjailFV+ovOuisUqrEBEHoMBB7ASxsl7s9lbvedDGUWogP2SRXsjWxaQN Psu5q+9/vu0cKhlsDm6PFPT9lC3abTWyp5iecIMp4dfyYUTPp08RHkfQWI0PhjDf8aEq ez/zik4QR7YZzuf8Sld56Gg36kAoZNlSBYVsfiPvvt/bXgh0ZpEpP/KICAqia5N0OsSC Ry90hdIV1VOcB1eysoLAEH4P9BxZVFTLhx4e/+bGCH4EhT+y3w2DP9OTBMhVneYDE/o+ g/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=fuxm9M1T3VcSvc5bTzwUGDZCKtGjaiDhJDWNan/MCa8=; b=M2ldB9ZCC4raJuhFDN7J5RcxKMv7TEgwDtXIOI3tjx9xtCxwkcX8zx6chyrW9gEiu7 R1tSfVmhkBi+7gt6wLL4S0lUuVMHX6cMduPU8Czm+FjSRiSJuHFiFDRwrMMceYKceju3 8DmjKOogcsr3TtdgBrZAwfp6f3Nz4FwlVQ9LT+q2iDGXr5dnoa1qbBkeLwNb+qkvyO1K idKTLxPFQrddyLdH6J2OjKaTUtLU532O7sVZJi5AzzK6TGCuh+vlRkEMU6Q7Bsd7LCiG dSC4YYf7lptMXiHbabcKnH3zfSiIO/NArG9qkVUYYv7Sury6c9OtvCtZ1i/CQBeHQ1Zo tC2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20221208.gappssmtp.com header.s=20221208 header.b=Ivj1gErG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w3-20020aa79a03000000b00640d9bf6807si5655971pfj.20.2023.05.24.08.03.54; Wed, 24 May 2023 08:04:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20221208.gappssmtp.com header.s=20221208 header.b=Ivj1gErG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236221AbjEXOys (ORCPT + 99 others); Wed, 24 May 2023 10:54:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbjEXOym (ORCPT ); Wed, 24 May 2023 10:54:42 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 285091709 for ; Wed, 24 May 2023 07:54:19 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1ae3f6e5d70so3046425ad.1 for ; Wed, 24 May 2023 07:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684940045; x=1687532045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fuxm9M1T3VcSvc5bTzwUGDZCKtGjaiDhJDWNan/MCa8=; b=Ivj1gErGOAs0CsMEmRVCQZq3pnia3PQNEWq1PjGjMt4PKgdmLMHr38KozFdZOqen1v DCSNXgshzAAG4PTXvZm6rsJSKth8Zg78NLZ99htWzKr0z2k6CFDmAaxmoIP1N35tczkM wxT6kdTUb9HlIT/cLOdadD/ILbDe/OxT0/tVOEpjNFrXM7eeNfzvlQtUVF9kd1nxmFYH eJacO5abhAMaKenGcxZ6cNrPV+w2JwrfUZuCiBat0TEEY9Q2C8Na7aVlAlY8GB+1mxci wry3jkNre1koSM0WkDatTlYH58J0VjmgiZG/dOh2buajWDqg3ppPf+UBvi31sW9iJzGx MHeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684940045; x=1687532045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fuxm9M1T3VcSvc5bTzwUGDZCKtGjaiDhJDWNan/MCa8=; b=AF7G6pX9bcQiD+r/Cvp3ymt+OTfxAmQGj92IL2tGYc3kmc4sWdFf+tt2ZPlOIbJyUO VouCGV26g3JtBmdbZmvMUFAn3vBOWeU7JhGCgb1lvYwGexXpXUIjku43b1MPj9CR0J8m p/40zXgqr/s83apFsG7ra0R89Aa70CXerB5xEadJR1zt/VrGK9IAsMnOh6w8aCg/z7lM QZfyCoLc7DqOmoQDrR9bGgTwUNAswtT2uc29GGulep52dz93V9fq3OoPrlCG6BNj3Zfr Me6Drf67+itQ72b/3PrIMUuMjV7LOdKjIgC7LQlIpUkYmVSK2LJTrMXcnwY5LQvl7wbh OQCw== X-Gm-Message-State: AC+VfDzRw9O+hkQ56OPRvR43kldE8Hi5emW2zifKa4eqKTmn1rbbNpfi ysx1moz7i24+tzth0Hq4tT9JAQ== X-Received: by 2002:a17:902:d345:b0:1a2:6257:36b9 with SMTP id l5-20020a170902d34500b001a2625736b9mr18031174plk.31.1684940045181; Wed, 24 May 2023 07:54:05 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y18-20020a170902b49200b001aaef9d0102sm8812715plr.197.2023.05.24.07.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 07:54:05 -0700 (PDT) Date: Wed, 24 May 2023 07:54:02 -0700 From: Stephen Hemminger To: Shradha Gupta Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Michael Kelley , "David S. Miller" , Steen Hegelund , Simon Horman Subject: Re: [PATCH v2] hv_netvsc: Allocate rx indirection table size dynamically Message-ID: <20230524075402.3a0e36bc@hermes.local> In-Reply-To: <1684922230-24073-1-git-send-email-shradhagupta@linux.microsoft.com> References: <1684922230-24073-1-git-send-email-shradhagupta@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 May 2023 02:57:10 -0700 Shradha Gupta wrote: > @@ -1034,7 +1035,9 @@ struct net_device_context { > > u32 tx_table[VRSS_SEND_TAB_SIZE]; > > - u16 rx_table[ITAB_NUM]; > + u16 *rx_table; > + > + int rx_table_sz; Size should never be negative, use u32 or u16 here?