Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nick Alcock <nick.alcock@oracle.com>
To:     Alexander Lobakin <aleksander.lobakin@intel.com>
Cc:     Nick Alcock <nick.alcock@oracle.com>,
        Steven Rostedt <rostedt@goodmis.org>, <mcgrof@kernel.org>,
        <masahiroy@kernel.org>, <linux-modules@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <arnd@arndb.de>,
        <akpm@linux-foundation.org>, <eugene.loh@oracle.com>,
        <kris.van.hees@oracle.com>, <bpf@vger.kernel.org>,
        Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH modules-next v10 00/13] kallsyms: reliable
 symbol->address lookup with /proc/kallmodsyms
References: <20221205163157.269335-1-nick.alcock@oracle.com>
        <20230508180653.4791819e@rorschach.local.home>
        <e6662717-61a1-3e3d-5804-66629a1691e2@intel.com>
Emacs:  is that a Lisp interpreter in your editor, or are you just happy to
 see me?
Date:   Wed, 24 May 2023 16:02:29 +0100
In-Reply-To: <e6662717-61a1-3e3d-5804-66629a1691e2@intel.com> (Alexander
        Lobakin's message of "Fri, 19 May 2023 17:50:35 +0200")
Message-ID: <87wn0xn56i.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eBcJoDpib61fYpi964k4lNHSQGtaTSMMPC89zdSKCjDKbCtwJI2Wj0fHJJQI?=
 =?us-ascii?Q?TtcDaeBHn0UbThcyks3TbMyzvSQbKxNQZNVSoNH4Byv0kafL5RoLdivL4oDv?=
 =?us-ascii?Q?/ZGoGncjtDv3jNEZVxhX9SmcOocDLJjnXuq/IotUjJF3PvFOQ66Oa5JNX+B1?=
 =?us-ascii?Q?5JPbN6czdNkfYKiulvFao37NiV8/48yCvFUnjLfOJw5YnPqp6aBuvvi6e7eC?=
 =?us-ascii?Q?zZtS+edVQ7CJZrd7uPGMHKG4u4s6BPYLbFSnQ4JiAyOxRLcBDlHaUJHb2Q7q?=
 =?us-ascii?Q?5VJzzotmQQ98xwhcz5xfbjqY2QxqlKpdyK1gJghFL49cXrJitR4UuktD3NCD?=
 =?us-ascii?Q?qZOtW8M8KMKGOq3yV2Tn4Na7iB0mfZX51hKgVr0gdX6iFesBytp2O+QU8uds?=
 =?us-ascii?Q?bJ6ba/ASm8kUIQ6WyH3+QdIvYl8AAkeXWtplu2pBIFaXxt3F/O0PRqMOOVRe?=
 =?us-ascii?Q?8J+acDxMYRguta9mJukAcARBzasAG75fEwWeN3+fxHZt7gCYfdPDYHydJToJ?=
 =?us-ascii?Q?RfrNriExQq6bQ4YM0foiISLslmQl7rfcCGjGAgihnZS0iVFk6KRW9q6KDGzV?=
 =?us-ascii?Q?f0oUA9lVCrwO8eF/Ksc0V5UA2eIpEhaXIusxJZ1caDyv7fzTCRAobcwC2O6d?=
 =?us-ascii?Q?saUzUuuC0qu1/avxXhv7r3AEE02asxGKPa4gEhwLEh4IwUU1eME4AkiYxC9r?=
 =?us-ascii?Q?ajZwChGis0HlYPjBn6d3faS7cL/+2ocMZUMIjdo5oAdoXd9UoqKzdPXABylD?=
 =?us-ascii?Q?H/81g4jDPXLIWuidxbsezuhccn4S6Jyy5nF7/QlUej/9bZtwU2DAxZYJNiBm?=
 =?us-ascii?Q?/gHXL0+ILsj/j8AnBtXsjwzZfOUum5RPs4/5cX8+LgsUgmc/TDCFHiC7Qtt5?=
 =?us-ascii?Q?4GQMoNgLUdPGLVC43QbmBPXly3h3QbqXPKafWhc0w24/N5fMNY6ALPWrc6o8?=
 =?us-ascii?Q?bKSjbrZVSXBIxdLfbNo9Lb9XK4F9XIBYMkfsXL5A/Lb0N9GCcUt6fmwY+eb9?=
 =?us-ascii?Q?QfFF2tukCnfQZCmUZ0pdlxe03dZPF/vnGJj2yZe8K8yf3uosBmipGIS7tNB7?=
 =?us-ascii?Q?6xTai9/DygNtGVy2ESYeq1WYVXzQb1pvOAh/nkYBfOqeJYQ6fHPQwHxhCj8H?=
 =?us-ascii?Q?vl3LNFVTw9DiHhrVdlhQsB8qZ0Uz2Crq4Pb4TOarJyaAUJuBn3x8Xd88TtYN?=
 =?us-ascii?Q?PR8TOCedV3X9mqVK0N5w+LFlgVW3yHjSMK9POxBVqGxuof4bmeXb/qoWMPX5?=
 =?us-ascii?Q?nUjJaVAtXZwgZhewOcJyN7roAEHiUQvrrohIH65FE5B0KIlUSNk36Prb4goN?=
 =?us-ascii?Q?Hhptz4esS2OW/d+OPU7WQFVrFSiQLkRO5bppwZIm1AdSh9Hootj+mRRozxAb?=
 =?us-ascii?Q?1QBZovI8tlkh/VVVLPb3SLHGmGTtVE2JvXa/hdqDsv2O0lQBfgFMb8nxUdXR?=
 =?us-ascii?Q?yF1GeLaOWzhn+zdR/HxWLF9kGb2eBm8SZ499vGfKus61xwYZFrV/oNgoqRGe?=
 =?us-ascii?Q?pAF31U0oEUFFB1Go4zV0aAgivUTbUGHd2aUg9FcggfxCoOBvlbQ3aKu+xLgl?=
 =?us-ascii?Q?MyWoesBtEHhHMj3fe4VnJMGvmZ4IxdYvhdnBT4qEtMJKenFcc7lW7thrm2RO?=
 =?us-ascii?Q?Hw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?vnt07pRq+c31UAOwlIRJY71HnDROMO/bXPbWWka5MWkRhDRnJNp7jdnNMp5x?=
 =?us-ascii?Q?K9bO8tRGWvgUV6MkN2BOp8n0q9NFXzXuO9frQ794725gtQaC/nSSfTIU9OfY?=
 =?us-ascii?Q?JcKOZ5kmrwkoScpXuyvugr6DysAnv+277YzPB0es2VbHryzZzr86/7/r07pD?=
 =?us-ascii?Q?/JpHBQQ5WziX4n6sfOGL6jVYVOOKKJFKycvUNTcl99AeYeNl9OL+HeSZg7/F?=
 =?us-ascii?Q?8FotfAreWhVYGe6UeK1HgQ6rPG1bFipdqecSEmmhgR3BW4LGtRIr5vtfRj/Q?=
 =?us-ascii?Q?7WFsUraT4tmD+qwDHwhm0d7wK99vaAGnjHRwEJ+WwR2QGMAa+kS7GwISCZYh?=
 =?us-ascii?Q?7u066zS4JazYA0j9HcR/aqyXPcJrKgTloTh9DTnwlvMhWPhySO865M+JMqP+?=
 =?us-ascii?Q?a7dR8QxG+vIgopsU2jJ5n084/n/lN3Itm0ky1i9NALuqgBlhVQ+OszVVF/Mm?=
 =?us-ascii?Q?Ih3chcD5Z5sqS056SjHgN/RrRT3lhGCvaxmMYKXlqlm7IwM3bpCqauEinwJk?=
 =?us-ascii?Q?79jcE44lqdjeloQrauwD/eUzFjcOUBugLpLWgzbmsErEjxrPAPmdr2EXTppT?=
 =?us-ascii?Q?oWvIcaAdncrolmbPJqXLMHqVmrrBVEHmIKbttjlL4JVw7tVweux1ZuTrGmw/?=
 =?us-ascii?Q?7+W4ATYso0hTyC7D1qCpTVbXRq8WG/17yMJzD4pQi+5RojUEuenJE4bvR5qu?=
 =?us-ascii?Q?TWYr+f+EQzW1zgk7rPumHQJ/qes2g1Le7ZCsaTgJc6fX+TSaybFzE4VqNjLW?=
 =?us-ascii?Q?GmM/9EVNGZgnVal0Zc3buU3oNbJvwkglxsqWOig7QdnBAsiR6TkW/Iux40CR?=
 =?us-ascii?Q?nhHbs3vgxmI1cA5Lvo9y00Wn00C1q2Kg/dB9DAlZ37t4LCgeB3tPgrpja1+s?=
 =?us-ascii?Q?kVBtfjfqSLrGeoK/niDI2VDYyCCnsfrka3OMfFkx3LNk8sztTKrB3tsmVwxN?=
 =?us-ascii?Q?nCGztTPMFxepPDMmYNr21A=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cbba9f5b-67a0-4b18-082b-08db5c67e894
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 15:02:35.8983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ofk++aRQJmaMNO77arAASRy1d0XdiyicRiUgJ1ofsMKOLZZf2idQjVrFFyvac6ygQZ4KTZ3HfYB2O593x7S3HQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5689
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-24_10,2023-05-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxscore=0 spamscore=0 mlxlogscore=669 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2304280000 definitions=main-2305240123
X-Proofpoint-GUID: QV19iAJ07XUTxwsPq2E2V905Xst-y96q
X-Proofpoint-ORIG-GUID: QV19iAJ07XUTxwsPq2E2V905Xst-y96q
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19 May 2023, Alexander Lobakin outgrape:
> `file name + function name` is not a unique pair: in one of FG-KASLR
> discussions, someone even wrote simple script, which showed around 40
> collisions in the kernel. My approach was to include file path starting
> at the kernel root folder, i.e. `net/core/dev.o:register_netdev`.
> I'm not sure why no comments happened back then tho. Maybe you could
> take a look, I'm pretty busy with other projects, but if you find
> anything useful there in the RFC, I could join to a little bit.

My kallmodsyms patch does much the same, except to save space we
eliminate any leading path elements we can. Keeping those still
necessary to reduce redundancy, and eliminating the TU name entirely if
not necessary, saves several hundred KiB in my measurements and leads to
a total space hit for all of this of only about 12KiB. (Downside:
slightly less clear naming in /proc/kallmodsyms.)

-- 
NULL && (void)