Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 24 May 2023 18:03:40 +0300
Message-Id: <CSULLN90KNGF.3O4NO1OTCWBIP@suppilovahvero>
Cc:     <jgg@ziepe.ca>, <linux-integrity@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <l.sanfilippo@kunbus.com>,
        <jsnitsel@redhat.com>
Subject: Re: [PATCH] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11
 only
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
        <peterhuewe@gmx.de>
References: <20230524055815.10165-1-peter.ujfalusi@linux.intel.com>
In-Reply-To: <20230524055815.10165-1-peter.ujfalusi@linux.intel.com>
Precedence: bulk

On Wed May 24, 2023 at 8:58 AM EEST, Peter Ujfalusi wrote:
> The original patch which added the quirk would apply to all AAEON machine=
s,
> which might or might not be valid.
>
> The issue was discovered on UPX-i11 (TigerLake), it is not known if the
> i12 (AlderLake) version is affected.
> UP2 (ApolloLake) does not even have TMP module (no TPM drivers probing
> and confirmed by dmidecode).
>
> Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.
>
> Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")
> Suggested-by: Jerry Snitselaar <jsnitsel@redhat.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---
> Hi Jarkko,
>
> the patch is generated on top of your
> git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : ir=
q-storm
>
> Regards,
> Peter
>
>  drivers/char/tpm/tpm_tis.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 7db3593941ea..4357d4ba8f9e 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[]=
 =3D {
>  		.ident =3D "UPX-TGL",
>  		.matches =3D {
>  			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
>  		},
>  	},
>  	{}
> --=20
> 2.40.1

Thanks Peter. I will apply this.

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko