Return-Path: <linux-kernel-owner+w=401wt.eu-S1756572AbXJJPxn@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756572AbXJJPxn (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Oct 2007 11:53:43 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755286AbXJJPxf
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 10 Oct 2007 11:53:35 -0400
Received: from atlrel8.hp.com ([156.153.255.206]:48130 "EHLO atlrel8.hp.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755132AbXJJPxe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Oct 2007 11:53:34 -0400
Subject: Re: [PATCH 6/6] Use one zonelist that is filtered by nodemask
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Mel Gorman <mel@skynet.ie>
Cc: Nishanth Aravamudan <nacc@us.ibm.com>, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com,
       kamezawa.hiroyu@jp.fujitsu.com, clameter@sgi.com
In-Reply-To: <20071009154052.GC12632@skynet.ie>
References: <20070928142326.16783.98817.sendpatchset@skynet.skynet.ie>
	 <20070928142526.16783.97067.sendpatchset@skynet.skynet.ie>
	 <20071009011143.GC14670@us.ibm.com>  <20071009154052.GC12632@skynet.ie>
Content-Type: text/plain
Organization: HP/OSLO
Date: Wed, 10 Oct 2007 11:53:40 -0400
Message-Id: <1192031620.5617.39.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.1 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1418
Lines: 37

On Tue, 2007-10-09 at 16:40 +0100, Mel Gorman wrote:
<snip>
> ====
> Subject: Use specified node ID with GFP_THISNODE if available
> 
> It had been assumed that __GFP_THISNODE meant allocating from the local
> node and only the local node. However, users of alloc_pages_node() may also
> specify GFP_THISNODE. In this case, only the specified node should be used.
> This patch will allocate pages only from the requested node when GFP_THISNODE
> is used with alloc_pages_node().
> 
> [nacc@us.ibm.com: Detailed analysis of problem]
> Found-by: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> 
<snip>

Mel:  I applied this patch [to your v8 series--the most recent, I
think?] and it does fix the problem.  However, now I'm tripping over
this warning in __alloc_pages_nodemask:

	/* Specifying both __GFP_THISNODE and nodemask is stupid. Warn user */
	WARN_ON(gfp_mask & __GFP_THISNODE);

for each huge page allocated.  Rather slow as my console is a virtual
serial line and the warning includes the stack traceback.

I think we want to just drop this warning, but maybe you have a tighter
condition that you want to warn about?

Lee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/