Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5997883rwd; Wed, 24 May 2023 09:25:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jRRwOoNd9KZAEGnOk7Nn8xYZGRQue6qEOiaQx/v7ldWt1CcST7zFr2kpg6kqPDlJUWMJh X-Received: by 2002:a17:903:48e:b0:1ae:4248:c7f with SMTP id jj14-20020a170903048e00b001ae42480c7fmr16599022plb.48.1684945558528; Wed, 24 May 2023 09:25:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684945558; cv=none; d=google.com; s=arc-20160816; b=K2V88aioinlftLTqKDqenngx+xsKjvUmFLIp1EaoTIcZlx2XuZF4482tpbEOjd9xWh xA/5zo4XWyueAH7tCu7z1Vp9wYCBjHt2J0i9qqA504vORKwrtJ8qPYBEnP89NCr9q+Be ilrpsnbypjpUtoQlO3xFKMcVJumZnNspxCiFhUTdaWBRkxBnliqUzHzlTSqethTL/Wg6 cSEXeaBh12lcaz6dpk+Q45DV4bpv7Cn2+SgT7a3HB7a5KC9pLLaV5b3Fal5V6br/MctT eVLqInDy13o39HkSiYCfVArcaSiAcQDdewtETySZ/bgCtXNhq9r389PcXinUpOoA7n2N TJlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=d4cmi5pkR7lL3VXZBUXWXTM9kMpWqhi2Jn3DsVeQ9Fw=; b=0ApZki0H01eJJYPnDw/FN/ZYHzcUSXLVvHI1EQ5RXO49NIfqSl/rbkWBQ/oJ0OwyCN Ak8Q7ioVsrI9aqLV+4RHIf8tFaKYXUp0Qca4AAD3n879SqniB2ZcFo+xAgc0N45O2cwv KpMHCxLZ+i9Y9Ebvd0NehNmzJRtIV3yaD9tfQjl31Re7Kn+jLzJfpcDBL/cNcqEx0m3z gTPnVGi5+mpiFNUfQE+tDCdPsjH9iXymyAWZcXdt6e+kx1EYN5oKB5Gho/6CpMbB62cs qwlwz6epHD5lpUtSiB/kS7ra/U/hhecLxLxd6DNmx98Cxd6xhWJe+ivOWtNsQgrcXzon lR3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nlzXFI5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a170902ea0d00b001ac6d4cc269si4675162plg.396.2023.05.24.09.25.45; Wed, 24 May 2023 09:25:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nlzXFI5c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234958AbjEXQF0 (ORCPT + 99 others); Wed, 24 May 2023 12:05:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238753AbjEXQFB (ORCPT ); Wed, 24 May 2023 12:05:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1A7E49; Wed, 24 May 2023 09:04:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8C13617B0; Wed, 24 May 2023 16:04:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4FE9C4339B; Wed, 24 May 2023 16:04:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684944242; bh=AvLEpqq/Dfm1IZH9Fj2SEDUypWc1N9U5UTURKsOgFXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nlzXFI5cSYkrBMMbmjohePIfZJEJ1wyXXh8nVwQWYHkk8no4B3DZgv+dD2ve05da8 pekgyIFhR2BvsiTbttuSUbf8SlIpeOJURyDpYVVmKCeDTjGGj1QtMuuAiz4KNIBzI1 smXEPshQji5C5rb14OqzMaF7TjOIJRvLXVEh+RS0= Date: Wed, 24 May 2023 17:03:59 +0100 From: Greg KH To: Lorenz Bauer Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Martin KaFai Lau , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, shuah@kernel.org, yhs@fb.com, eddyz87@gmail.com, sdf@google.com, error27@gmail.com, iii@linux.ibm.com, memxor@gmail.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.2 08/30] selftests/bpf: check that modifier resolves after pointer Message-ID: <2023052435-xbox-dislike-0ab2@gregkh> References: <20230320005258.1428043-1-sashal@kernel.org> <20230320005258.1428043-8-sashal@kernel.org> <2023041100-oblong-enamel-5893@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 12:03:43PM +0100, Lorenz Bauer wrote: > On Tue, Apr 11, 2023 at 4:14 PM Greg KH wrote: > > > > I didn't see anything to do here. > > > > And selftests should NOT be broken on stable releases, if so, something > > is wrong as no other subsystem has that happen. > > Sorry for the long delay in replying, I update the kernels we use for > CI only infrequently. Here is an example of the build failure I'm > seeing, from kernel.org 5.10 LTS: > > In file included from > /work/build/5.10.180/tools/testing/selftests/bpf/verifier/tests.h:59, > from test_verifier.c:355: > /work/build/5.10.180/tools/testing/selftests/bpf/verifier/ref_tracking.c:935:3: > error: 'struct bpf_test' has no member named 'fixup_map_ringbuf'; did > you mean 'fixup_map_in_map'? > 935 | .fixup_map_ringbuf = { 11 }, > | ^~~~~~~~~~~~~~~~~ > | fixup_map_in_map > > This is just doing make -C tools/testing/selftests/bpf after compiling a kernel. Great, any specific commits that fix this issue would be appreciated to be pointed at so we can apply them. thanks, greg k-h