Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756159AbXJJQRA (ORCPT ); Wed, 10 Oct 2007 12:17:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754753AbXJJQQw (ORCPT ); Wed, 10 Oct 2007 12:16:52 -0400 Received: from mtagate3.uk.ibm.com ([195.212.29.136]:33918 "EHLO mtagate3.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbXJJQQv (ORCPT ); Wed, 10 Oct 2007 12:16:51 -0400 Date: Wed, 10 Oct 2007 18:16:18 +0200 From: Cornelia Huck To: Alan Stern Cc: Greg KH , Tejun Heo , , , Subject: Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model Message-ID: <20071010181618.54060d13@gondolin.boeblingen.de.ibm.com> In-Reply-To: References: <20071009224820.GE21228@kroah.com> Organization: IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Herbert Kircher Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.0; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 27 On Wed, 10 Oct 2007 11:38:50 -0400 (EDT), Alan Stern wrote: > On Tue, 9 Oct 2007, Greg KH wrote: > > > The rules for sysfs files are the following: > > - one value, in text format, per file. > > - no action apon open/close > > - binary files are only allowed for "pass-through" type files > > that the kernel does not touch (like for firmware and pci > > config space) > > - directories should be associated with a kobject where it makes > > sense (no nesting deep subdirectories without a kobject > > present) > > You have to stretch this a little for the power/ subdirectory every > device gets. The only kobject it corresponds to is the one in the > device, which already corresponds to the parent directory. Yes, this should be "directories should be associated with a kobject or generated by an attribute group". This way you won't get deep nesting either. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/