Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230524014118.3172781-1-yukuai1@huaweicloud.com> <7075bfd8-7c52-a778-5651-71ade3cd1f03@kernel.dk>
In-Reply-To: <7075bfd8-7c52-a778-5651-71ade3cd1f03@kernel.dk>
From:   Song Liu <song@kernel.org>
Date:   Wed, 24 May 2023 10:21:40 -0700
Message-ID: <CAPhsuW5cBZUdBFM7jdfP11ev5UpQX_YCe_EmR+A1B4XgSrw+-w@mail.gmail.com>
Subject: Re: [PATCH] md/raid5: fix miscalculation of 'end_sector' in raid5_read_one_chunk()
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Yu Kuai <yukuai1@huaweicloud.com>, hch@lst.de,
        chaitanya.kulkarni@wdc.com, johannes.thumshirn@wdc.com,
        damien.lemoal@wdc.com, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org, yukuai3@huawei.com,
        yi.zhang@huawei.com, yangerkun@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 24, 2023 at 8:03=E2=80=AFAM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 5/23/23 7:41=E2=80=AFPM, Yu Kuai wrote:
> > From: Yu Kuai <yukuai3@huawei.com>
> >
> > 'end_sector' is compared to 'rdev->recovery_offset', which is offset to
> > rdev, however, commit e82ed3a4fbb5 ("md/raid6: refactor
> > raid5_read_one_chunk") changes the calculation of 'end_sector' to offse=
t
> > to the array. Fix this miscalculation.
> >
> > Fixes: e82ed3a4fbb5 ("md/raid6: refactor raid5_read_one_chunk")
>
> This needs a stable tag as well, Fixes alone is not enough to guarantee
> it ends up in stable.
>
> Song, are you picking this up?

Yes, I will test it and send it via md-fixes.

Thanks,
Song