Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 20:41:45 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Maxime Chevallier <maxime.chevallier@bootlin.com>,
        Mark Brown <broonie@kernel.org>, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next 1/4] net: mdio: Introduce a regmap-based mdio
 driver
Message-ID: <20230524174145.hhurl4olnzmfadww@skbuf>
References: <20230524130807.310089-1-maxime.chevallier@bootlin.com>
 <20230524130807.310089-2-maxime.chevallier@bootlin.com>
 <8f779d98-d437-4d8b-914d-8e315b4aca17@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8f779d98-d437-4d8b-914d-8e315b4aca17@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1tn7cgTzUxik1VbrcmBKl9brn5rIJwXCVL3tOtdBYSgUx8qNRUevzIX5MYbw?=
 =?us-ascii?Q?fUprLunGhGrWc4WJhd/KHWve8eqxAfMh8dY5euS8JubmW5wRb5VPWnBD++Ns?=
 =?us-ascii?Q?x3Vzw3w0sN0phjjEdMaF2Hh3ZZ78d6YBAauIdKxbt6r47a6IuSkG3aQJnQak?=
 =?us-ascii?Q?H67I6CGJvqvfmkztn+WeXsx+TJXxgN+VZ41EucZBh/Xq2fURx/bMl0RS+hXn?=
 =?us-ascii?Q?AkQD6k5g+HZSAK03kDJtFy9W+PYEZNBpk5EdghiV5tYZMx8Biq7o/ae5D/ue?=
 =?us-ascii?Q?U++qhl4p2TgDoZgZs7xb9ir5X5gOC3kX4xKckok8i8mLu2rvT67vz3dbUtH1?=
 =?us-ascii?Q?ApxKDuEXfZHTWClNlVxXzDYwI7mEArZUGIxTlR53yX0G6yuhvqwMiZjAVZET?=
 =?us-ascii?Q?nuULdvZd+puRwiyqyivEzhJ+7xFnZY6pnLR/57eqMAYpLBxjKoMxBsHT2I3i?=
 =?us-ascii?Q?Bu3oIo9vS7F9x8ePjKlvVm2/76b6nxR+mIDqXKDwGbZB9pYevuY19Lfz/aOu?=
 =?us-ascii?Q?8cHRWmTTyAWgGtuEg4VM8uaStkThAbnwGwVWwummonNvO4N5tqZIjZtDOhl4?=
 =?us-ascii?Q?RMlZNq9h8RyetpJGDA75KjGcW14JY1Zuowh3OZ18/09V3EVrwfO0iqLs73Gx?=
 =?us-ascii?Q?jveY981n55X2b00i1Har6u8EGcTlroSXPQdfJ+uGbmNEIBI/CWRmlXVeMjNe?=
 =?us-ascii?Q?fJSGPSyBMi8S3kwSNuF2vnN4JJxxmVzQoQDcseW/Q7w2e7ZV3E2W16Gy0+86?=
 =?us-ascii?Q?LrldjUYH0Ru4i8UOCvDHChUqm+N0CGUW6yL57ZGvngOTMdRl6sAcCYosqD6Y?=
 =?us-ascii?Q?I2rmWIh8UqKN1Quw6mZo/krSU5kY2xLXp/W4FaAsdYJJW34lfhBejZ9jenpA?=
 =?us-ascii?Q?uN/CzULVRe7ddBLjEo+kuDC0LvNfOWGGolBu9yFefT2JUT0JsFfpbidtQbSW?=
 =?us-ascii?Q?N1B/VuZkk9TngHthYK3A0dw0tCULk/O9QogKeV56ldh6jSG7aelKsn+GD08o?=
 =?us-ascii?Q?OQej8KDx749hj2WxZYnO9w7/5zaKzs1ReZbMMiUs0SuWIB0/agHmTNTrDV9y?=
 =?us-ascii?Q?RbDFqoOubzN96qp/PhBJ9Dx+O4TL25NxO82Z8Xnwa/irihQrFkAm1yxV6MVa?=
 =?us-ascii?Q?ZCSObBWHRrKaGb1F3LJ+bjya7HJ4+559Rpe7e/SiEHvIZZrpJwz4qg8BgYnt?=
 =?us-ascii?Q?KUXTqfaFhftCfMH5yel/Xf4WuEvFmeFL+b5T/6aV421U6UwEHwxYkeEwZwhZ?=
 =?us-ascii?Q?Kbq9js67ieUV0jZyOBmtlrhZIMFS0i/Sy1Ua7MlGOnrCubdlE6lO9y7/zuH6?=
 =?us-ascii?Q?iT7bX8cQTTQ4P+krwb0IbA1F6b+aPRdvS6sKjWYnRKoGgGHL/JTznggcwOXu?=
 =?us-ascii?Q?rTwOk1YYLTGZpgLXF4aIx+jMAkZDLUmK8Vn3Wbp90FDexuKTu+yMdobae6yx?=
 =?us-ascii?Q?cFs80s9nUV6xhMtj5Pg8JxySpxhEhYSZXWLh/SYAWgkWGSTcMROtsrKcGHbE?=
 =?us-ascii?Q?k8Kmf+Nz290dttpzs+vB85j6ZLln+lvTTYe7rDfhq0SvfGLPpGCndSWbRRQp?=
 =?us-ascii?Q?xCBSwQZINfZugWPkzz43UqckfGbc29DJu+3ZEik0Vnw3Ked1cVt25Swtaqe/?=
 =?us-ascii?Q?KA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 549ce354-8bfa-4604-eb50-08db5c7e270d
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 17:41:49.5968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n5/iuawBkst9NsUgwWxRgd6XRyfVNkNTejVrbrkAD16zczqNjnVqWNnJzy8LasRIe58jJS3voNf0zVR9geUdog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7693
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 24, 2023 at 07:30:51PM +0200, Andrew Lunn wrote:
> > +	mii->name = DRV_NAME;
> > +	strscpy(mii->id, config->name, MII_BUS_ID_SIZE);
> > +	mii->parent = config->parent;
> > +	mii->read = mdio_regmap_read_c22;
> > +	mii->write = mdio_regmap_write_c22;
> 
> Since there is only one valid address on the bus, you can set
> mii->phy_mask to make the scanning of the bus a little faster.

Sorry, I didn't reach this thread yet, I don't have the full context.
Just wanted to add: if the caller knows that there's only a PCS and not
a PHY on this bus, you don't want auto-scanning at all, since that will
create an unconnected phy_device. It would be good if the caller provided
the phy_mask.