Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 24 May 2023 20:57:16 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Sean Nyekjaer <sean@geanix.com>
Cc:     Conor Dooley <conor.dooley@microchip.com>, robh+dt@kernel.org,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        pascal Paillet <p.paillet@foss.st.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: mfd: stpmic1: add fsl,pmic-poweroff
 property
Message-ID: <20230524-cider-unarmored-b1141db1030b@spud>
References: <20230516132225.3012541-1-sean@geanix.com>
 <20230516132225.3012541-3-sean@geanix.com>
 <20230516-footprint-handoff-bcd553ff6146@spud>
 <9B1EE405-77D3-4980-9A13-9D4F87C1A64F@geanix.com>
 <20230523-flaccid-fossil-c9d09838dc64@spud>
 <658510B5-702B-464A-BA55-01E2B315BE39@geanix.com>
 <20230524-ellipse-dagger-72f850253ea0@wendy>
 <24418459-DE19-4575-835B-8673F279993C@geanix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="tvTbO8tm4UlrjSgl"
Content-Disposition: inline
In-Reply-To: <24418459-DE19-4575-835B-8673F279993C@geanix.com>
Precedence: bulk


--tvTbO8tm4UlrjSgl
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Sean, Lee,

On Wed, May 24, 2023 at 12:30:59PM +0200, Sean Nyekjaer wrote:
> > On 24 May 2023, at 12.08, Conor Dooley <conor.dooley@microchip.com> wro=
te:
> > On Wed, May 24, 2023 at 10:16:13AM +0200, Sean Nyekj=C3=A6r wrote:
> >>> On 23 May 2023, at 19.29, Conor Dooley <conor@kernel.org> wrote:
> >>> On Tue, May 23, 2023 at 11:55:50AM +0200, Sean Nyekj=C3=A6r wrote:
> >>>>> On 16 May 2023, at 20.06, Conor Dooley <conor@kernel.org> wrote:
> >>>>> On Tue, May 16, 2023 at 03:22:24PM +0200, Sean Nyekjaer wrote:

> >>>>>> +  st,pmic-poweroff:
> >>>>>> +    $ref: /schemas/types.yaml#/definitions/flag
> >>>>>> +    description: |
> >>>>>> +      if present, configure the PMIC to shutdown all power rails =
when
> >>>>>> +      power off sequence have finished.
> >>>>>> +      Use this option if the SoC should be powered off by externa=
l power management
> >>>>>> +      IC (PMIC).
> >>>>>=20
> >>>>> Just reading this description, this is sounding quite like a "softw=
are
> >>>>> behaviour" type of property, which are not permitted, rather than
> >>>>> describing some element of the hardware. Clearly you are trying to =
solve
> >>>>> an actual problem though, so try re-phrasing the description (and
> >>>>> property name) to focus on what exact hardware configuration it is =
that
> >>>>> you are trying to special-case.
> >>>>> Krzysztof suggested that the samsung,s2mps11-acokb-ground property =
in
> >>>>> samsung,s2mps11.yaml is addressing a similar problem, so that could=
 be
> >>>>> good to look at.

> >>> The description for the property that Krzysztof mentioned is
> >>> samsung,s2mps11-acokb-ground:
> >>>   description: |
> >>>     Indicates that ACOKB pin of S2MPS11 PMIC is connected to the grou=
nd so
> >>>     the PMIC must manually set PWRHOLD bit in CTRL1 register to turn =
off the
> >>>     power. Usually the ACOKB is pulled up to VBATT so when PWRHOLD pi=
n goes
> >>>     low, the rising ACOKB will trigger power off.
> >>>=20
> >>> In other words, I am asking what (abnormal?) scenario there is that m=
eans
> >>> you need the property, rather than what setting the property does.
> >>> Or am I totally off, and this is the only way this PMIC works?
> >>=20
> >> Indicates that the power management IC (PMIC) turn-off condition is met
> >> by setting the SWOFF bit in the main control register (MAIN_CR) regist=
er.
> >> Turn-off condition can still be reached by the PONKEY input.
> >>=20
> >> ?
> >>=20
> >> I must admit I=E2=80=99m somewhat lost here :)
> >=20
> > Sorry about that. I'm trying to understand what is different about your
> > hardware that it needs the property rather than what adding the property
> > does. If you look at the samsung one, it describes both the
> > configuration of the hardware ("ACOKB pin of S2MPS11 PMIC is connected =
to
> > the ground") and how that is different from normal ("Usually the ACOKB =
is
> > pulled up to VBATT so when PWRHOLD pin goes low, the rising ACOKB will
> > trigger power off.")
> >=20
> > Looking at your datasheet, you don't have such a pin though - just the
> > sw poweroff bit & the PONKEY stuff. My angle is just that I am trying
> > to figure out why you need this property when it has not been needed
> > before. Or why you would not always want to "shutdown all power rails
> > when power-off sequence have finished". I'm sorry if these are silly
> > questions.
> >=20
>=20
> No silly questions, maybe they trick me to come up with the correct answe=
r :D
>=20
> Basically without this, you won=E2=80=99t be able to power off the system
> other than hitting the PONKEY.
> So it=E2=80=99s a new feature that wasn=E2=80=99t supported before.
> Maybe this feature should not be optional?

Yeah, I suppose that is the rabbit-hole that the silly questions lead
down. I don't know the answer to that though. Maybe Lee does?

> If st,pmic-poweroff =3D=3D true:
> System will power off as the last step in the power off sequence.
> If st,pmic-powerof =3D=3D false:
> System will reboot in the last step in the power off sequence.
>=20
> I thought of this, as an always on system failsafe.
>=20
> /Sean

--tvTbO8tm4UlrjSgl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZG5sHAAKCRB4tDGHoIJi
0rWEAP4lWVE6G3byCCSQgC62atNFVXdqKVjP4XzjoT0ww7VJFAD9Fl9yiOYkQxHu
nrbVQIPYnPN+/L1UGV8+t49vUBeWUQ8=
=s+Wx
-----END PGP SIGNATURE-----

--tvTbO8tm4UlrjSgl--