Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8cd7bc5-86c7-f113-f7a1-aec4bbf4aeb3@amd.com>
Date:   Wed, 24 May 2023 15:54:26 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks
Content-Language: en-US
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>,
        Alex Deucher <alexdeucher@gmail.com>
Cc:     amd-gfx@lists.freedesktop.org, Leo Li <sunpeng.li@amd.com>,
        Kenny Ho <kenny.ho@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@gmail.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20230524191955.252212-1-hamza.mahfooz@amd.com>
 <CADnq5_Mz6aPFYGnr8J8C8UeTpbo7JDg+uvjqAxo7o4vmTGej2A@mail.gmail.com>
 <cede79cd-4986-ce3c-ab74-a4497e9e1230@amd.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <cede79cd-4986-ce3c-ab74-a4497e9e1230@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHRzVllkYzlHczNWQTVURHdSaFRQcUh6Y25XOUU5Mk9yVFhiVU9QNUtxMEpi?=
 =?utf-8?B?TmRFTFExelVmbHEyL2lLdkJGOERZNUx5MFJrTmpyaHpucmg0YlVjTmlQVUVx?=
 =?utf-8?B?VGppNHcycGhvQ2dwTHdVQkdMQlh3K3hEU1VMZG9oZmVyd1RmYWtxeU1DbFEv?=
 =?utf-8?B?MmpreWdMUi90dTBvdjFrTEtOYVkxZFZ4WTZQOXN0K0JyRmpPVDlJbm5WU2lR?=
 =?utf-8?B?bEJjdU5JMGRNUjZtVEozY3p6YVpjV2poQTNYeEsvc2xXa0JRTGxsSzVmSmF5?=
 =?utf-8?B?dDBPK0d6VkxWd1lnVldNcTFRYnNKZ0JQRVRycU1IdUdCTEV4MUttcS9pZWtI?=
 =?utf-8?B?MVBhV1NwNWRtT1Y2M3prUU1ydHpyVHdsSlJZVkUwa2NHUm96UEN1c2FuVWkr?=
 =?utf-8?B?WmJQU20xN3pkbHNIa25uKzJXWGM0T3pUaW9wQXoxdVZkY3JoS0MyN2c2ZGdV?=
 =?utf-8?B?TmJKQ2d3azUvbGdkZ1pDckplVVYxRTQ2TEtiRTZYd3RVd1F0dEIrNVhXbkMr?=
 =?utf-8?B?OS9NSFJCUmtselZYZTZWK3U0Nk9ObTV4NXpmNjZyTzBiQVZIMjVoSi8vQjBQ?=
 =?utf-8?B?cG1kalpOK1BadWJSQmVXS0ZFT2ZUWExLOWVBTTFKSWJSNkdubms4bU4xL2V5?=
 =?utf-8?B?RDhHSWUyK0hpQXZEZU0wOENiRHArSG9iL2pzSFp5R3NnWUNJQUFLekswbEVk?=
 =?utf-8?B?RVo5bk1kOEcraHZYL0V4cTZvK3Y2SmJqVDJ3TFBJWnAzMWFmZEpNalNkbU96?=
 =?utf-8?B?eit3VWJEZGV1KzEyNEN3NlUrQUpFelR1dmhZS1lPMHFmOHlUNkhCOU5Ia2tI?=
 =?utf-8?B?M0d1WDBXblIvbHd4MGJWNUF4OHYrSUxNUE5CQ0N4RHFpc0VKb2NZWFZQNDdw?=
 =?utf-8?B?cXZLbHdzaEtLdjhxS2VtSjUwTlRoL0MrR1l5Um9JSWp0VS92OERyWGd3KzBN?=
 =?utf-8?B?YWpHNDMwUTkraHhJR2IrWHpKWUlna3FTakx1SFplNDBiRnVFVVRBdmVEci9w?=
 =?utf-8?B?WWZxTlFhdm1JQlRrMk04Z0JLek83UTRvckdxZFJQcEV6c09xNTg5Nmc3TEFT?=
 =?utf-8?B?QitrcktMMFQ2NWJZb0dFeXRmTFlLUkJTUmtXeW45MDdRY1c0VS9kZUdZVkNm?=
 =?utf-8?B?Z3J6eU8xUU84NGNyUnc4Ym1tZ0RTMFlhckVNSGVURWFGMTliVm8yb1hXN0cv?=
 =?utf-8?B?YmxnNHV5VDZjazNjT1IrbUZNSkVaUnJ1b0F5THBBSkRDQXMwdHQrL1FqVUIz?=
 =?utf-8?B?bUVQcDlpM09haG9lb3VkYXpzd3liNVNPclVFbkhLUnNoQXJPeGZ0U3dkbWZu?=
 =?utf-8?B?ZjZlbzA2alNpOG5YeWpoL1JOak4ydEpYQjdkdGJwNG1DTmM4N1hTV3VmSFdH?=
 =?utf-8?B?ZTFSdld6WkpXem9saUpKTDNBTlFidTJGT0VZNy9ZVHZsUjlST0tEMFJwTm9I?=
 =?utf-8?B?dXl2akRsUm9qTy9oMTQ3cFMyOWE1U0h3UTJnNmZyK1RreEM2RUFLSjFLbUNT?=
 =?utf-8?B?QkpIRnFNYm9pdFNVVkoxclhZY2RnQW5wMzhyNzNBdkFvYzI5TE9NTDM4bUJt?=
 =?utf-8?B?QzhjR0M1ZnJPSmQ4TjFFNGxCUklURGo3aHNzRGhPQkRsVUpnek5iVTBaR01s?=
 =?utf-8?B?bVluZHd3ZDVQUHBKWWtJRG1ScDBvbVFSSklNZHRhanI3T09nYnZldGQ0R2Zi?=
 =?utf-8?B?REJ4c2dySjhUUERFTFU5NkI4UEZoQzlYVFBpTXd2cys1aWkzU1NRS0FDTndp?=
 =?utf-8?B?dTBJSXdOMDdSRy9tTnV2Y2FpT2Y4eDR2NTdDVWVBM2hvWUVrVWU4Zk9Cbm1i?=
 =?utf-8?B?VkVhRHJDYUZ4YjRxWVdKOURIK1JsZGZMTVdIdG15TmprNWQwMXlscTlCSENu?=
 =?utf-8?B?aEdtVjVmcDVJSWFLOWhub1AzVXRNd29LSS9MQWdVS2dvWGw1VThvMk9DWHVE?=
 =?utf-8?B?Z2tnYkVqUjZuV3JQbEd4c001L0VjMEppVWxUYURDb29qTGkwcDMyV2RYV1pR?=
 =?utf-8?B?ZGUwdHYxK2dtUjczN2NYeThKdUFhV3JaWE5LT0l0eVlUVFJKN0JwcFZVU2hZ?=
 =?utf-8?B?VzVWTkovWUZyc29vQjJndUsxMzhFR0N1ZjRqaXBFVHBzUEZFU3Y2WTBib0RI?=
 =?utf-8?Q?QmoX7vYKqXVLNz3KFLGGMiRXy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e240c499-eae0-4746-d216-08db5c90b087
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 19:54:31.1700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3CQPq8nR0hp5PAJhIfhhpRXMxDlGosqCrt7V7GZ6Pxm3k9kR09ajn+15KTAa/5JzbOucZ92cyGaZ3Eg0+3MkQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6353
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/24/23 15:27, Hamza Mahfooz wrote:
> On 5/24/23 15:22, Alex Deucher wrote:
>> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
>>>
>>> Currently, there are quite a number of issues that are quite easy for
>>> the CI to catch, that slip through the cracks. Among them, there are
>>> unused variable and indentation issues. Also, we should consider all
>>> warnings to be compile errors, since the community will eventually end
>>> up complaining about them. So, enable -Werror, -Wunused and
>>> -Wmisleading-indentation for all kernel builds.
>>>
>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>> Cc: Kenny Ho <kenny.ho@amd.com>
>>> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
>>> ---
>>> v2: fix grammatical error
>>> ---
>>>   drivers/gpu/drm/amd/display/Makefile | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile
>>> index 0d610cb376bb..3c44162ebe21 100644
>>> --- a/drivers/gpu/drm/amd/display/Makefile
>>> +++ b/drivers/gpu/drm/amd/display/Makefile
>>> @@ -26,6 +26,8 @@
>>>
>>>   AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
>>>
>>> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation
>>> +
>>
>> Care to enable this for the rest of amdgpu as well?  Or send out an
>> additional patch to do that?  Either way:
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> 
> As far as I can tell, if `CONFIG_DRM_AMD_DC` is set it will run these
> checks on at least the base driver code.
> 

It's probable best to put that into amdgpu/Makefile in that case.

Harry

>>
>> Alex
>>
>>>   subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
>>>   subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
>>>   subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr
>>> -- 
>>> 2.40.1
>>>