Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Saleem, Shiraz" <shiraz.saleem@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Ismail, Mustafa" <mustafa.ismail@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "Devale, Sindhu" <sindhu.devale@intel.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/irdma: avoid fortify-string warning in
 irdma_clr_wqes
Thread-Topic: [PATCH] RDMA/irdma: avoid fortify-string warning in
 irdma_clr_wqes
Thread-Index: AQHZjWho5Oj7NPLsJkKF1Bo/FzhlHa9p2E8Q
Date:   Wed, 24 May 2023 19:55:15 +0000
Message-ID: <MWHPR11MB002962E159ADAB9F2195FB23E9419@MWHPR11MB0029.namprd11.prod.outlook.com>
References: <20230523111859.2197825-1-arnd@kernel.org>
In-Reply-To: <20230523111859.2197825-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MGZFSQ5HrpYQrGXCnG1FM9zeCgb2QEkdDzUFIpUCb0/i1/B6m3r1zVDF6n6I?=
 =?us-ascii?Q?H0jLk0Fg4h2fCbOI4Y0jP8rtiUNx5Sg/3ttd/FmyyD4Mo32H0aN/ujkbagBC?=
 =?us-ascii?Q?N90k4fs0eU5gMxNtEKRREXmjH4ezo8GOj7apxtYvv9dZ8lfQCmLtx42QNJ9F?=
 =?us-ascii?Q?ToJyaAzKSr83LRcmQtGQsEXy8vk13YSVF3kRW5mYnlaAwaLbGqm4mobpIjqp?=
 =?us-ascii?Q?nB700eMTajwimULffxhotUlnT4xxdCqaEH8t+dt1XpGOv1m6f9LbM2ksLk8U?=
 =?us-ascii?Q?9rd8lyCmL4Zyj74Z7Ahz9GAjGcQ/SoEBZHrje8HgRvQZUWpeINwx4x1HcP78?=
 =?us-ascii?Q?4RxHGzzSQZXSdNDugtXE3W/rOyWStu2XrW3DsTH+HMOUU/n9FA+9CTlAo3Fn?=
 =?us-ascii?Q?Oy7/FyuPG+2y6Vliz3glARhxF2mPL9+0D2UsotOxWRQbwsKA/i6GXsvaEDjE?=
 =?us-ascii?Q?7vdJH1dBgUkAtsIrbWWurXaVOaJ1l7keTk02flo2Lw7F7nITT1Rogd2zEpfK?=
 =?us-ascii?Q?qZF+jpDct9g+76FrUfIEUU9ekzV0bsWoPR2CnCRjS7zzZ4nezuS7UmOwCxB9?=
 =?us-ascii?Q?896E9nHovd8ke9A7HlcMBQn2NQNwC81k7FDYSLLlfIlBXfIdypeAFYNPQGjc?=
 =?us-ascii?Q?X805c50hv7ECXN/1AkNFgjHq5BeyBLsRRxWm8BCkf49TXF4EBmr/tqBa5T44?=
 =?us-ascii?Q?7kchyRxu+RZsxhd4yCiEKz2aIOH0rjYmVpRwrlTcRO9vkXA3eXBBe40Hs7YU?=
 =?us-ascii?Q?LaIwU4vbHTMwJzLepQYmt/bPbaFNxw9w0IwZwBgc8JxHmGIWgM21qiI04Iei?=
 =?us-ascii?Q?xpqUXvm87j6XfZWvn0IMRYvLcBrW8fAy/VWWlUafBwpiR+MrRjaLm+5XfTjC?=
 =?us-ascii?Q?A1WlK0V21mIwsIgvExyECi1/nn26MWcPXINgs9HTuHroAgLXS+u5PWW5YRt2?=
 =?us-ascii?Q?E5Wn0k1piUZ2s3WWhWZuXNVvnfdLuztlwmgJRrhITyWu/sKOW8gmuh9k74GR?=
 =?us-ascii?Q?2EwQYXDJStG2s3u74Oo8q5Lrcys3EmQOIyc33fsaX/Lj2r0yGqDXVAwIclRJ?=
 =?us-ascii?Q?HcFOyWjUWxpkMKv5mrxgDtg7JaRL7fVfZWvaj99n0BlKrf0/hbBovC3eu/gD?=
 =?us-ascii?Q?A2l9wnNTOP+auHcOfCo+c3xMhs8G9lKXR6fxIK8FPUadXaKvGP8KDMNRfXZy?=
 =?us-ascii?Q?TbkDVydKuTv6pap76G5jAqXMY4sYBpWYh/38C8DxA6ffYmHZCvLcMFpk3r8L?=
 =?us-ascii?Q?6ZniA2qgxa4Fj6jpKOXjwjHKax8IAmBlP4s8/cmQZ5TQah0Vm2eUuqJxm5uE?=
 =?us-ascii?Q?CJWRH8SyCXBsTMRZqbXiwmzymqwQ8w/C0rkO22AbBa30l7BZpwxUVPCKGGZs?=
 =?us-ascii?Q?eBZlE1RRp0RyUv1hbupHdDhYJEc9zGZk5PpPBVwlrONnaw+1pJhMrcxyVEyr?=
 =?us-ascii?Q?vJ7B12az4rPF1/8X4RN4pFjMY3PiSREEMmlqzIU0voUNH8dsLTUymtQp6FlB?=
 =?us-ascii?Q?XGR1mzepFOW4o5y1m3kXFEzYZgwKtZ11I9tLSU7oBlZaBEvtxJApWctnjwDR?=
 =?us-ascii?Q?832oxslQgLm27/OLYB6ShTBufOfowAV6Pcm8yzcE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0029.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 924134a3-ae5b-46eb-5aec-08db5c90cb26
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 19:55:15.6156
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kqLxh06IlNA2Lp5eKnwlYqCYv08B0XK9MtpsPyUh7IWrcCvWrnEFQJ2cOL2V81w7gj9FbePwPxANNyelO5vuiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5803
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] RDMA/irdma: avoid fortify-string warning in irdma_clr_wq=
es
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3D3") triggers =
a warning for
> fortified memset():
>=20
> In function 'fortify_memset_chk',
>     inlined from 'irdma_clr_wqes' at drivers/infiniband/hw/irdma/uk.c:103=
:4:
> include/linux/fortify-string.h:493:25: error: call to '__write_overflow_f=
ield' declared
> with attribute warning: detected write beyond size of field (1st paramete=
r); maybe
> use struct_group()? [-Werror=3Dattribute-warning]
>   493 |                         __write_overflow_field(p_size_field, size=
);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~=
~
>=20
> The problem here isthat the inner array only has four 8-byte elements, so=
 clearing
> 4096 bytes overflows that. As this structure is part of an outer array, c=
hange the
> code to pass a pointer to the irdma_qp_quanta instead, and change the siz=
e
> argument for readability, matching the comment above it.
>=20
> Fixes: 551c46edc769 ("RDMA/irdma: Add user/kernel shared libraries")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/infiniband/hw/irdma/uk.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/infiniband/hw/irdma/uk.c b/drivers/infiniband/hw/ird=
ma/uk.c
> index 16183e894da7..dd428d915c17 100644
> --- a/drivers/infiniband/hw/irdma/uk.c
> +++ b/drivers/infiniband/hw/irdma/uk.c
> @@ -93,16 +93,18 @@ static int irdma_nop_1(struct irdma_qp_uk *qp)
>   */
>  void irdma_clr_wqes(struct irdma_qp_uk *qp, u32 qp_wqe_idx)  {
> -	__le64 *wqe;
> +	struct irdma_qp_quanta *sq;
>  	u32 wqe_idx;
>=20
>  	if (!(qp_wqe_idx & 0x7F)) {
>  		wqe_idx =3D (qp_wqe_idx + 128) % qp->sq_ring.size;
> -		wqe =3D qp->sq_base[wqe_idx].elem;
> +		sq =3D qp->sq_base + wqe_idx;
>  		if (wqe_idx)
> -			memset(wqe, qp->swqe_polarity ? 0 : 0xFF, 0x1000);
> +			memset(sq, qp->swqe_polarity ? 0 : 0xFF,
> +			       128 * sizeof(*sq));
>  		else
> -			memset(wqe, qp->swqe_polarity ? 0xFF : 0, 0x1000);
> +			memset(sq, qp->swqe_polarity ? 0xFF : 0,
> +			       128 * sizeof(*sq));
>  	}
>  }
>=20
> --
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>