Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0774d3f5-6c8a-9737-ee58-4c0bd1ada9cb@amd.com>
Date:   Wed, 24 May 2023 15:57:12 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks
Content-Language: en-US
To:     Harry Wentland <harry.wentland@amd.com>,
        Alex Deucher <alexdeucher@gmail.com>
Cc:     amd-gfx@lists.freedesktop.org, Leo Li <sunpeng.li@amd.com>,
        Kenny Ho <kenny.ho@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@gmail.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20230524191955.252212-1-hamza.mahfooz@amd.com>
 <CADnq5_Mz6aPFYGnr8J8C8UeTpbo7JDg+uvjqAxo7o4vmTGej2A@mail.gmail.com>
 <cede79cd-4986-ce3c-ab74-a4497e9e1230@amd.com>
 <f8cd7bc5-86c7-f113-f7a1-aec4bbf4aeb3@amd.com>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <f8cd7bc5-86c7-f113-f7a1-aec4bbf4aeb3@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1BaY3RHLzBOS1Rlakc0Kzk4NE56QS9NdFhiWkZtU3hpN3lDbHBFS2lsSmY1?=
 =?utf-8?B?c2ZQQzdaVVhaUnhSWnovSHNjbkxxdlBPUnNBdlZIN1lvTFN4V2Y0Z1pjTi9O?=
 =?utf-8?B?UWxPazVmdXJmV0xvZnRqd1doajdkVmR5U041VngyeDd5ZmNYYlhXTDV0L3pV?=
 =?utf-8?B?S2lwbWwwWVNvd1FZc0hmUTJhM01vT1dmcFNtUzBVS3BjZzdMdlo0Y1YwOThr?=
 =?utf-8?B?SDJpa1pSME1TZzdxVHlMVUUreVprOG5JK1pxWEVGeGNPVjBvTGxkbHppdjhl?=
 =?utf-8?B?THRJdnAwQjdhUFVqOHpUSFUrSXFIUlk1RVRJTjFHZnVXbzVISFVjTzJaYlo4?=
 =?utf-8?B?WllkbGY3VVlIZEFLL3JGMnFZRlluVlJUVTF6KzBNb0N4YkhUZDdSRjdDZHBD?=
 =?utf-8?B?Rm1LRG9uQnNhZkdhMm14TDc3UVo3NHpKRGlEUUIxcTdNUlY1WCtzSzZvek5l?=
 =?utf-8?B?M2JoWmtsTkFNc29nWmtscGNXOVI0NDUvUURSUlVRVjVTYnVzUWRoNjllajZn?=
 =?utf-8?B?Z0hic2h1SldDVVcyNUswMzcxYytxUGNtRWhzNHdtSERJckNyVjdFQ2ppZ1d2?=
 =?utf-8?B?YS9FeVRuSUNheThPRDEybGxaNE5kSG10ZEVwRENqMWloS2xXQlpIYjVPRTVR?=
 =?utf-8?B?TzcwYXVWdFFFWG9hOU8wdE1iaVp4RzEyQVNYV2F2S1ovV2NiN2JVTjF4dWVI?=
 =?utf-8?B?Zmgwb2pzZEtnWWdJME9iT2xYYTFqUi9NUm1aTzMvMytQdS90NVBNZ2RXaDhw?=
 =?utf-8?B?QnoyOStnVGFkTHEvYlJUTG82Ym50T3BwRXNiNkZ2WVM1UjArc01Hbmpaam1E?=
 =?utf-8?B?dUI1OStuZUUrdlhNQlUvVk5VdTBNcG9qM21yL1I0b2pVZlZsR2h5azhMQk9B?=
 =?utf-8?B?Wkk3T1kvemtTODRBL0JpeTFHdUk2eTVLNG1ZaTdOeEhDWS9BZDJYNWQxWncz?=
 =?utf-8?B?d0ppOHJCTHA0STBqVmNWY1pranNmcmt4cXlEZzJJY3lPWVg3MVVVUmc0akZT?=
 =?utf-8?B?NkVQZVhpRy9idjZBQ2hieTlFK2psV3dEbEg1MkV4MjNGMGFqZUs2NndaaVJP?=
 =?utf-8?B?ZHBkS3QxblJiQXR0NEpVZEpHSngvckVycHA2RS9oU21HdUF3bzh0Sm1lcnYx?=
 =?utf-8?B?ZTV3c2kxTGltVUlUaG83Ymp0VzNDcnJ2RnA0SThkUkdoUFBzeUpOVSs4SURk?=
 =?utf-8?B?WGJNbWYza3ZON3EyTUkxYnhrV1NyeFdMTUFLd09PTXJ2Wkg1WFF4MCt2eXBH?=
 =?utf-8?B?UFhUWmJBMHhLVzgraG1wL0J0anY2YVhBRVFJRWg1OEh5U284Z3FvUTIvYVhC?=
 =?utf-8?B?ZTNmS01MZTVsNGZqb25TcnVJMEMwbjVCdVhzbjhxVTBZalB5S2R5RFpxWklr?=
 =?utf-8?B?SDlycFI3MkZKSkV1TWcxUlljdk9Va01LaEZxVlVuaWhrcDN3RWxrOEt1bEwz?=
 =?utf-8?B?Mm9vM213M2JVejlpZDBsU0tna1J0WEpXbWZBMXZLZzVBbFlNcjZ0bXFFckg5?=
 =?utf-8?B?dW05dHN6ZGcxekUzd0Q1NnptdTFpUERGNjNTNzlhR3pYTkwyOTlRdkliV2Ru?=
 =?utf-8?B?WFJPSnJWeGhqRjFyRThsTDNRSzh3SEJzZlJwd2U5OHc5YWZYT2F1N1I2dGNC?=
 =?utf-8?B?WTNZU0V0QzdpR0ZBcElianRLSkJ4N3MrbHFDSEhNNjgwb05wY3pJVTEwK3VT?=
 =?utf-8?B?QnNHYXRzWVpCUktMemFvTWloaGdWckp2bkZhMmVVREg4cUJ1cERaOUcwcS81?=
 =?utf-8?B?VUJOS1NTZWZWVWpkdUlsc0piYTNjb3dENjN4NDE1T0JwbFdPUDdYdEpYRWdv?=
 =?utf-8?B?RWxmcEJVa0JrZkdPSVA0MzcwVXFkTjU5M1FvYzBESFFjTEtCNGlDYmU2Nmtu?=
 =?utf-8?B?dWFmZ08rRGFzUXBEZXV0NXY2dGJ5NWhqTXRackhSRGVyT3E4Sm1XakpRbTMw?=
 =?utf-8?B?aGkzR1lsdjk5bUFaRnNOMjR0dUJvUE5TUUZ4WFdMYnI1Nk5EeEpXQ21lbnpn?=
 =?utf-8?B?OFZHU1preWcrUUFRUmZZc3IyOGU3dzhrSWE1RUxsUERzS0QrTW54amhSclk5?=
 =?utf-8?B?Zjk5WWhuZGliVmdXdENOYzVTcnZkS0RtU01ORUpuVGRDYkdoalFqZ1c4Zk9F?=
 =?utf-8?Q?brk1Mku3kEZEmvbDF+XX4XWlX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 633df9f6-4b39-43ad-98a4-08db5c911342
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 19:57:16.7971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nhq9bjKI76o6GLYmkuGdYKHuVv+e2c5GiJaZqlfqqaMvHnOyKDIRaMO7y4EGP7Ek9mSYChtLCNDQvKYOemqKRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8764
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/24/23 15:54, Harry Wentland wrote:
> 
> 
> On 5/24/23 15:27, Hamza Mahfooz wrote:
>> On 5/24/23 15:22, Alex Deucher wrote:
>>> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
>>>>
>>>> Currently, there are quite a number of issues that are quite easy for
>>>> the CI to catch, that slip through the cracks. Among them, there are
>>>> unused variable and indentation issues. Also, we should consider all
>>>> warnings to be compile errors, since the community will eventually end
>>>> up complaining about them. So, enable -Werror, -Wunused and
>>>> -Wmisleading-indentation for all kernel builds.
>>>>
>>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>>> Cc: Kenny Ho <kenny.ho@amd.com>
>>>> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
>>>> ---
>>>> v2: fix grammatical error
>>>> ---
>>>>    drivers/gpu/drm/amd/display/Makefile | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile
>>>> index 0d610cb376bb..3c44162ebe21 100644
>>>> --- a/drivers/gpu/drm/amd/display/Makefile
>>>> +++ b/drivers/gpu/drm/amd/display/Makefile
>>>> @@ -26,6 +26,8 @@
>>>>
>>>>    AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
>>>>
>>>> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation
>>>> +
>>>
>>> Care to enable this for the rest of amdgpu as well?  Or send out an
>>> additional patch to do that?  Either way:
>>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>
>> As far as I can tell, if `CONFIG_DRM_AMD_DC` is set it will run these
>> checks on at least the base driver code.
>>
> 
> It's probable best to put that into amdgpu/Makefile in that case.

I tried the following, but it doesn't seem to work:

diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile 
b/drivers/gpu/drm/amd/amdgpu/Makefile
index 74a9aa6fe18c..d97bde0796dc 100644
--- a/drivers/gpu/drm/amd/amdgpu/Makefile
+++ b/drivers/gpu/drm/amd/amdgpu/Makefile
@@ -39,6 +39,8 @@ ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \
         -I$(FULL_AMD_DISPLAY_PATH)/amdgpu_dm \
         -I$(FULL_AMD_PATH)/amdkfd

+ccflags-y += -Werror -Wunused -Wmisleading-indentation
+
  amdgpu-y := amdgpu_drv.o

  # add KMS driver

> 
> Harry
> 
>>>
>>> Alex
>>>
>>>>    subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
>>>>    subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
>>>>    subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr
>>>> -- 
>>>> 2.40.1
>>>>
> 
-- 
Hamza