Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51354ca5-acd2-f542-95e0-85ed8418f483@tum.de>
Date:   Wed, 24 May 2023 21:53:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
From:   =?UTF-8?Q?Josef_Sch=c3=b6nberger?= <josef.schoenberger@tum.de>
Content-Language: de-DE, en-GB
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>
Cc:     linux-kernel@vger.kernel.org
Subject: KernFS: Missing IN_DELETE_SELF or IN_IGNORED inotify events
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi everybody,

I'm currently working on event listeners for cgroups for a long running
daemon. I found that the removal of cgroups that I'm currently listening
for produces neither an IN_DELETE_SELF nor an IN_IGNORED event; which is
unfortunate, since I need to maintain a map from watch descriptors to
paths, from which I would like to remove all obsolete entries.

Since this is not the documented behaviour and since I could not find
any material that would specify an intention behind this, I'm assuming
that this is a bug?

I've found that the same applies to the sysfs. Taking a look at the
kernel code, I'd guess that the issue might be in KernFS.

I've appended a minimal reproducible example.

Thanks
Josef


#include <stdlib.h>
#include <err.h>
#include <sys/inotify.h>
#include <unistd.h>
#include <stdio.h>
#include <sys/stat.h>
#include <signal.h>

void cleanup(int signo) {
    (void) signo;
    printf("Removing /sys/fs/cgroup/demo again...\n");
    if (rmdir("/sys/fs/cgroup/demo"))
        err(EXIT_FAILURE, "Could not remove /sys/fs/cgroup/demo");
    exit(0);
}

int main(void) {
    if (geteuid() != 0)
        fprintf(stderr, "Need root privileges.\n"
                "Will probably not be able to cgroup without.\n"
                "Giving it a shot regardless...\n");

    int fd = inotify_init();
    if (fd < 0)
        err(EXIT_FAILURE, "Could not create inotify fd");

    if (mkdir("/sys/fs/cgroup/demo", 755))
        err(EXIT_FAILURE, "Could not create cgroup @ /sys/fs/cgroup/demo");

    signal(SIGINT, cleanup);

    int wd = inotify_add_watch(fd, "/sys/fs/cgroup/demo", IN_DELETE_SELF);
    if (wd < 0)
        err(EXIT_FAILURE, "Could not add /sys/fs/cgroup/demo to inotify
fd");

    printf("Expecting to read an IN_DELETE_SELF or IN_IGNORED event...\n");
    char buf[512];
    ssize_t nbytes = read(fd, buf, sizeof(buf));
    if (nbytes < 0)
        err(EXIT_FAILURE, "Could not read from inotify fd");

    printf("Read %zd bytes\n", nbytes);
    cleanup(0);
}