Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e26351ed-ba64-b7e1-5165-de40622e0d30@amd.com>
Date:   Wed, 24 May 2023 16:27:31 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks
Content-Language: en-US
To:     Alex Deucher <alexdeucher@gmail.com>,
        Felix Kuehling <felix.kuehling@amd.com>
Cc:     "Russell, Kent" <Kent.Russell@amd.com>,
        "Ho, Kenny" <Kenny.Ho@amd.com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
        "Wentland, Harry" <Harry.Wentland@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        David Airlie <airlied@gmail.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        Kees Cook <keescook@chromium.org>
References: <20230524191955.252212-1-hamza.mahfooz@amd.com>
 <CADnq5_Mz6aPFYGnr8J8C8UeTpbo7JDg+uvjqAxo7o4vmTGej2A@mail.gmail.com>
 <DM6PR12MB3996C4248CBC968A7B08341583419@DM6PR12MB3996.namprd12.prod.outlook.com>
 <BL1PR12MB589849F37FBE98A3A06A316185419@BL1PR12MB5898.namprd12.prod.outlook.com>
 <3fefc712-913a-a391-bc7b-c0c75eff1c3d@amd.com>
 <CADnq5_OdWbg6zKjPrRwd2QSDnHgFuThF+OQHM=tVWj-2ySCu_A@mail.gmail.com>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <CADnq5_OdWbg6zKjPrRwd2QSDnHgFuThF+OQHM=tVWj-2ySCu_A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTVwSEZmeFEzcFNFVTYzZjR2anZwRzhVakY2b0VNaVdaOVNGbWpJb1R2Wkw2?=
 =?utf-8?B?eUQzeXlnK0hNMm1yYnFQc1VCL041ZmdCSVNxSEZMU0gzTDZCcWticVZ6Zlh3?=
 =?utf-8?B?RVNCcEQvalpSYnNFSzVQWjRJa0NDaGRxbktuUWZxcmYvWnZub3piVUtMS2dZ?=
 =?utf-8?B?ZC9rUi9OSFRrSnlDNXRrZW4xSWl5OWxaa2FjZVZhU29adzZMdU9FUGdHU1A1?=
 =?utf-8?B?UWxjWWNYSCtvT3AvdU1FVExhM3hqWXNyODlqTU04T1BiQWphWDBiRUtLOXVI?=
 =?utf-8?B?R0R3bHRxSEZibmJYQmNNNjZuck9UNm03UEd5bXBuTGdFU3I2VGNVTVFYUFdT?=
 =?utf-8?B?VzBHQXZ1YXloRVo3d1JaTFdYaDMreHBLdDZmbHVhUmFUWlpaK3FCbGpNYW1R?=
 =?utf-8?B?azFhWlRZMExJU3FKaDFVMGEwVGJqNlJ2NEphdzE5aWE5aHlnN1JXQ1lYVFM2?=
 =?utf-8?B?UkFPemxpTDBEM1BnY2tCaXhBcEJFekh0a2RMQjJVWE5yY3FlRE4zUm1xU3Uy?=
 =?utf-8?B?Q3RZWDd3ZWoyRCs4N2M2cW5PREhNMHlhL3ByYkxGMW51SXNwWXUrN0Q1N1ZR?=
 =?utf-8?B?TWlXcnQvMVlpc3dPeTIzSGNISFJWZGM3MTV4ajJweUxSMDFPVWRyQ0FldHM2?=
 =?utf-8?B?RlVoK1BCazZJS2M3dkc2MzNPdDBHaUZlbVBUWVRDd0phc1lVdld2NCtjVGJX?=
 =?utf-8?B?WndqekM2OCtDbDhyUnhKUFhWanlHVDNGUkpJb2phb1ZQV242ckt2QmxNTDgy?=
 =?utf-8?B?WWpJQlhQOHlTOU5LWDhZZnFlN1UwNWJQZUpBRjRZdElIRUZRYllnSFRsNmd2?=
 =?utf-8?B?RndaNDlLS2Rtd09WTzBMM3pkSXFONGUrRFlVR1ZYcThhMkxSaDc4anFGOURZ?=
 =?utf-8?B?am9mYnBtbm12ZG5aaUdUNGhDUXg3UFZzcWxsWTE2TXdseVMyd0hQOWZiU2RC?=
 =?utf-8?B?NWQzcThqTHdvRVdJQ2R3T2xJTTAyeE9wSlkrUkFZdlNRZGd1NmEvTmpBRW5Y?=
 =?utf-8?B?SGJuNDhUVWZDcHpIYWJEaFdXSEF6dHJLZVJmK1BSM3l0NXBBSkcvMjdVSVVj?=
 =?utf-8?B?UVowRXduOWY1MUZMR25BWkhiQjI1ZGZWRVhYaG1QMzcxZ2lWZ25kVGdJaWNw?=
 =?utf-8?B?eTFiMGhvWDRiK2YzUnhzU3JyOUpCU2hKNE1lZkpVZnJrU2Rxd3YrbU1naXNX?=
 =?utf-8?B?M3pzMzIvbE9wU0dLc2RWZkhPWXhJU2VkaDZlQW1nMXRsOUd0RDlrLzY4UG1I?=
 =?utf-8?B?RDFyZFF4Z3ZnZmd3RXNOSGhTTzNwalhlNlpRQ0tNRlRZN0w0ZXpWc2txUU5R?=
 =?utf-8?B?QmlnWFBRR0gyK1crYU43VzlYTUpBeG9QbzJnVDVySEkyeC9ySHJoRmNKVzZ3?=
 =?utf-8?B?eXN6bTJZVkpTcUJoWkJkQjVENGIyOXloSkVWcS9MclpqeFlMZ3FscUt2YnM0?=
 =?utf-8?B?d2Y0c1lScEJUQXQ0M1c1SXNqbVgzcWxoOE9YZ2E3Nm05OTRrSXc2dHlLa294?=
 =?utf-8?B?S1VtUHhrdURGejlLR0pFU2dUZ3o2Ny9EeUdYSUNNdSs0UWdZTituTW9mV2N1?=
 =?utf-8?B?NzN4VHBDeGNPVXU5VTY3WUJLc2JVQTB4dU5BQ2xqcmpjeU5wYk1OM0VyVUhq?=
 =?utf-8?B?Qm9OQmdmQzFsdi9ndFZSVUNFVjlQbjlsY09OTnNUUXZtcmdPQUZhU1ZnSlV0?=
 =?utf-8?B?N3d4TTFrNGFIbVRZSjNjanAwOU8zeUg5YVJHU3VWZmVUOG9DZjdnOGUxSUZs?=
 =?utf-8?B?M2pxQkJ1NWdoUitMbWxRaHJKblVvTjRhZ1ZDeGxDZkhwWXcrZVFEL3l0b2w1?=
 =?utf-8?B?SDZlcWVzVGwzSGJoTWdFa29SM2I2ZXZaSFh3Mm8zUVQxM3JUZFdtTDBWS0M0?=
 =?utf-8?B?dTJCeXc3QjVyaXlvV2NLSCtWYmV0cGg3RzFML3hNdlZadmVEbVhRU2RVaUNv?=
 =?utf-8?B?eitpZ3R4V0d0amU3UXV0WDcrUnpQb3lkODFMQUt3RldONlFrNEZXbVpSQU1r?=
 =?utf-8?B?QkZsZVlVUTU3SU9FUCt5NE9BUXl4MFlPMk5rK1d0WGdLeU9NZDJwOGkyMDRm?=
 =?utf-8?B?R21QMVVLOEp6Si9RTzhndTBMdC90OXJXZ29wbXFTSi8rSDNxY0JjclZiaFVx?=
 =?utf-8?Q?n1rzqK7yG/nr0lnyzzRgYdj1U?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f56a8d91-c284-43a3-2aa4-08db5c954f79
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 20:27:35.8581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t08ehKTEt3T9spON6fCn6980vD2lroDAn1GlIRiCBV2Z2S+m2yvZkes/VGoWHu1yr4K4lD2cCcXhYJChXAz+dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7832
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+ Kees

On 5/24/23 15:50, Alex Deucher wrote:
> On Wed, May 24, 2023 at 3:46 PM Felix Kuehling <felix.kuehling@amd.com> wrote:
>>
>> Sure, I think we tried enabling warnings as errors before and had to
>> revert it because of weird compiler quirks or the variety of compiler
>> versions that need to be supported.
>>
>> Alex, are you planning to upstream this, or is this only to enforce more
>> internal discipline about not ignoring warnings?
> 
> I'd like to upstream it.  Upstream already has CONFIG_WERROR as a
> config option, but it's been problematic to enable in CI because of
> various breakages outside of the driver and in different compilers.
> That said, I don't know how much trouble enabling it will cause with
> various compilers in the wild.
> 
> Alex
> 
>>
>> Regards,
>>     Felix
>>
>>
>> On 2023-05-24 15:41, Russell, Kent wrote:
>>>
>>> [AMD Official Use Only - General]
>>>
>>>
>>> (Adding Felix in CC)
>>>
>>> I’m a fan of adding it to KFD as well. Felix, can you foresee any
>>> issues here?
>>>
>>> Kent
>>>
>>> *From:* amd-gfx <amd-gfx-bounces@lists.freedesktop.org> *On Behalf Of
>>> *Ho, Kenny
>>> *Sent:* Wednesday, May 24, 2023 3:23 PM
>>> *To:* Alex Deucher <alexdeucher@gmail.com>; Mahfooz, Hamza
>>> <Hamza.Mahfooz@amd.com>
>>> *Cc:* Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Wentland, Harry
>>> <Harry.Wentland@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Siqueira,
>>> Rodrigo <Rodrigo.Siqueira@amd.com>; linux-kernel@vger.kernel.org;
>>> dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Daniel
>>> Vetter <daniel@ffwll.ch>; Deucher, Alexander
>>> <Alexander.Deucher@amd.com>; David Airlie <airlied@gmail.com>; Koenig,
>>> Christian <Christian.Koenig@amd.com>
>>> *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile
>>> checks
>>>
>>> [AMD Official Use Only - General]
>>>
>>> [AMD Official Use Only - General]
>>>
>>> (+ Felix)
>>>
>>> Should we do the same for other modules under amd (amdkfd)?  I was
>>> going to enable full kernel werror in the kconfig used by my CI but
>>> this is probably better.
>>>
>>> Kenny
>>>
>>> ------------------------------------------------------------------------
>>>
>>> *From:*Alex Deucher <alexdeucher@gmail.com>
>>> *Sent:* Wednesday, May 24, 2023 3:22 PM
>>> *To:* Mahfooz, Hamza <Hamza.Mahfooz@amd.com>
>>> *Cc:* amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>;
>>> Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Ho, Kenny <Kenny.Ho@amd.com>;
>>> Pan, Xinhui <Xinhui.Pan@amd.com>; Siqueira, Rodrigo
>>> <Rodrigo.Siqueira@amd.com>; linux-kernel@vger.kernel.org
>>> <linux-kernel@vger.kernel.org>; dri-devel@lists.freedesktop.org
>>> <dri-devel@lists.freedesktop.org>; Daniel Vetter <daniel@ffwll.ch>;
>>> Deucher, Alexander <Alexander.Deucher@amd.com>; David Airlie
>>> <airlied@gmail.com>; Wentland, Harry <Harry.Wentland@amd.com>; Koenig,
>>> Christian <Christian.Koenig@amd.com>
>>> *Subject:* Re: [PATCH v2] drm/amd/display: enable more strict compile
>>> checks
>>>
>>> On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <hamza.mahfooz@amd.com>
>>> wrote:
>>>>
>>>> Currently, there are quite a number of issues that are quite easy for
>>>> the CI to catch, that slip through the cracks. Among them, there are
>>>> unused variable and indentation issues. Also, we should consider all
>>>> warnings to be compile errors, since the community will eventually end
>>>> up complaining about them. So, enable -Werror, -Wunused and
>>>> -Wmisleading-indentation for all kernel builds.
>>>>
>>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>>> Cc: Kenny Ho <kenny.ho@amd.com>
>>>> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
>>>> ---
>>>> v2: fix grammatical error
>>>> ---
>>>>   drivers/gpu/drm/amd/display/Makefile | 2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/display/Makefile
>>> b/drivers/gpu/drm/amd/display/Makefile
>>>> index 0d610cb376bb..3c44162ebe21 100644
>>>> --- a/drivers/gpu/drm/amd/display/Makefile
>>>> +++ b/drivers/gpu/drm/amd/display/Makefile
>>>> @@ -26,6 +26,8 @@
>>>>
>>>>   AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
>>>>
>>>> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation
>>>> +
>>>
>>> Care to enable this for the rest of amdgpu as well?  Or send out an
>>> additional patch to do that?  Either way:
>>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>>
>>> Alex
>>>
>>>>   subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
>>>>   subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
>>>>   subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr
>>>> --
>>>> 2.40.1
>>>>
>>>
-- 
Hamza