Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27412rwd; Wed, 24 May 2023 13:36:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ71nw1M8ZlnQVGFPIxk5zYgKGFGt8fpAiVeytTZPCCO4o4ZcgmZNfoYhrENAyh4q/ZY1ohU X-Received: by 2002:a17:903:191:b0:1a6:7ea8:9f4f with SMTP id z17-20020a170903019100b001a67ea89f4fmr517561plg.26.1684960577078; Wed, 24 May 2023 13:36:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684960577; cv=none; d=google.com; s=arc-20160816; b=OR1pa1vDwE4JVU1Agp2XfogzRSurvxSpKoe3PCgOW7YMSEeo5LEzxrkQUlUWTzILGx OeBs/9OSQldc6myrvFsee87GF3JR+Wq++7UP0kvomD9bC9XM0srFjDWkce1pxLOp8WjE XOhZdL/j3fdc9ml3p4Sp89ISpSL0eYKKf5c1zM+PZrbuLzCK3TcAW0M7c1Q/m7eZ9hsr gGAodOAp7eTprMCLAeqISj3mc5JRqgzawcJTw2qIwDvh6hZ74p3nvvNl21wXbVfsb39c ut9pLmwoQlko0o/rg99oM/RhUeQZIIntkcVw8aPmL/RnxU2FT4GLzBSIf7hbn1+SYvxJ vilA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=h+t0pLHTzUYTGgD0HYtHAFUPzSwmA3nxfBA9XXlt8cA=; b=bdtzfe5FaVWAkMAmsN7DwdgJY3bl2+NNJwqa++GtgoMWyhgk6mvVRYowxJJASeBh2G WXcTHgpLLBAK8Ml6GyBxSEahHnycqgA+6U5exYOkHmGss1fXWPI/mctWWhGyrajflWEN lyAzTt6ifO3+MRzTB0KKZ1sRGL8EwGqIq8FOXaHFm7ccOvQ5gSQ53fNEow3z/bXn2HqQ fBdnfhH9/LYanHpj5TrTmictV4j8LMBZBiKj0RMv4e+FePAGTYhLQXRYxRVrlD0123Lj qLuMCDkz6dtLnqCCpF7DrhFckY9mCLRD80bk14X+28HhUgVs0zYp+lRMwv4Amz5swlsD oVvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=TzCo3G5k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j21-20020a170902c3d500b001a691f376e8si8863924plj.415.2023.05.24.13.35.59; Wed, 24 May 2023 13:36:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=TzCo3G5k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234091AbjEXUas (ORCPT + 99 others); Wed, 24 May 2023 16:30:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjEXUaq (ORCPT ); Wed, 24 May 2023 16:30:46 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EF4B10B; Wed, 24 May 2023 13:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h+t0pLHTzUYTGgD0HYtHAFUPzSwmA3nxfBA9XXlt8cA=; b=TzCo3G5krtm9tGsXiiydWWi/eN 2Ja6ji6ltXVTrpI214coF3MM1ptZDXWUJSJE41JNnYHtVJ9ieUlLtI5FAlR65z+v7rtG+nnL7sVID OgsTRQPWy5nbErcp48ZK3QDlsIXTKzvK4D/c+sgQMs1/DtnE+OtYs7ZJ2hnik2V3qQ9sldWrGnZNc kNw/8zRzuc33EgYPNjd4vUjA3vFIjoPVaq2qd1lutuvIqDY/uj4kLjQi5y0AeH18EeN3nOSvz9vrN bmtCvnmTI1BtCWgd2aoRQsim/rWZw4bKtcWV2HlgZrg30dettFpYIdg0ft8A5dPU7BF8PbeRzvZ48 3t6cjDNw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q1v6B-0054jl-18; Wed, 24 May 2023 20:28:45 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 0CFBB30013F; Wed, 24 May 2023 22:28:35 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id BD56A20A78733; Wed, 24 May 2023 22:28:35 +0200 (CEST) Date: Wed, 24 May 2023 22:28:35 +0200 From: Peter Zijlstra To: Kautuk Consul Cc: Sean Christopherson , Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Subject: Re: [PATCH v7 08/14] KVM: Rename mmu_notifier_* Message-ID: <20230524202835.GB3447678@hirez.programming.kicks-ass.net> References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-9-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 11:42:15AM +0530, Kautuk Consul wrote: > My comment was based on the assumption that "all atomic operations are > implicit memory barriers". If that assumption is true then we won't need It is not -- also see Documentation/atomic_t.txt. Specifically atomic_read() doesn't imply any ordering on any architecture including the strongly ordered TSO-archs (like x86).