Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp127309rwd; Wed, 24 May 2023 15:20:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ610OyBR701jHEJO0DJ2Z67nYBmbrfBRmYM/W7gAfddWVQ0UNLMjXQQ1egIy1drJF2EEWot X-Received: by 2002:a17:90a:4a07:b0:253:440b:7aed with SMTP id e7-20020a17090a4a0700b00253440b7aedmr18023168pjh.32.1684966808413; Wed, 24 May 2023 15:20:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684966808; cv=none; d=google.com; s=arc-20160816; b=iQ+2+R/+1CX7hvu58QINe9BMuvB/J6OlRriBNXGFgs0wPL7mW8ysvJtKYOkq9OtGbY NN8fn/VvaxoYDNQ1rE+r4fyT+uPJbqehseDznYgnilj66LPrMi8mN/Bt3Gjah9ktD7Xq LXKJ9tj+Gwot7iBOBdsdKKSdFnpQdZTxb/kyyScvvKWwLmseUyMHlg0LfWMVJnaY58gT sXm/06e6t6HUzJGP6+hvfXv5fayGc+vt3QEJtLv8zpu+67cZBCSBdCCEcFEuCWF7kFA9 x1BpVCl0zU/OeslGmnJRP197Aay13Taqmj6ldN4oxqsGd1ktaNs5EpvB6IaH6NYUD+Sk pM4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=BGJNYAB8T/lr+YL5tSEXLDHHn2s+eih/Ya1hsZucDVU=; b=LskhzFslE8faNp6Zn8I2TAPYpFoFWw9AvpuSS2AOoYoGn+WGxUgA8WsTrpuRGkTKBX wj3WZrPULayxMPAzlxmAivZYC9WGHn5JUeHlJDWge/aVJvZ/h2shRevfB4kni9OBz8CS 1reJ+8ChENrarifF+pAAJpkmnCks2JkJ/weuzxocxlVVaNJr6//9d/CPY9NiTxB1pQJL HMO7UE06w4MSbHEzz6hlxEBq2AdAmr9U14VZ437lbp63nF9RXBbnTQcjfyg8iK5dciIr 3qB3DVTX2qbwNfvYfRm77+jM8y6inKhxABsVdJjPlYHECt/ghHjOpXoz8VdlaW4UzA5M a7Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=YGnq6z+6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fu11-20020a17090ad18b00b0025546028cbesi26917pjb.31.2023.05.24.15.19.54; Wed, 24 May 2023 15:20:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=YGnq6z+6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235902AbjEXWD3 (ORCPT + 99 others); Wed, 24 May 2023 18:03:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjEXWD1 (ORCPT ); Wed, 24 May 2023 18:03:27 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B111C10B for ; Wed, 24 May 2023 15:03:26 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2af2e908163so17943031fa.2 for ; Wed, 24 May 2023 15:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1684965804; x=1687557804; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BGJNYAB8T/lr+YL5tSEXLDHHn2s+eih/Ya1hsZucDVU=; b=YGnq6z+6UdWriHJovvH32ejeIEdFSsUsF0YwCxsLX4Eaj2Mn7bQfdQ240fsbxanWfx eSodL/Nfer1LbYRRoDsr7hr8HNFON59XtBDlNUiJBYgB1wf5lz58i466bC8N1WBde64j wnL1YisuMgB17ECW/zH39qJdHs/r7jZIaHHfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684965804; x=1687557804; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BGJNYAB8T/lr+YL5tSEXLDHHn2s+eih/Ya1hsZucDVU=; b=Sw9dAdfD7QFgP7CW0Fe6fwW/PniTAPizqWz4+ORpo6g8u3FGuYF3w3epAIYAEyGZRD nAieE7PVL56xdoSKDr8k9y2LGvis5jzNbrCT6D01HcXDEQ6H9oHlZtxEF0G1b1QCExF9 Zw0dEtEqbVEjaxw5TpUxAhdR8sEVN98sHLO+yU2HCjOG7hjqSAPbGWeG9dcAUSoLULEf gUmbma8dcNn3b7kQ5VJsCMuk3vZ6tmTT02/cz/eSV/39WpcNGP7Mb4/AnKfJOOytjQ94 l2FeIchnizJrac6hrbV8YwbDsfcWugSqeg6rFNP6AAzUR0U+RjKE5rMc7lfYZAAd7AiS 1PrQ== X-Gm-Message-State: AC+VfDxDBsb8b0mKLiMa5SWqBZv6J3+ywvCakK+cxEh+2WTrQIeV/hDf PK8P4pdltvFTVwqCzuVeM/T0Ekzzlt/FQcUdJOdaymqC X-Received: by 2002:a2e:9001:0:b0:2b0:3046:9c6 with SMTP id h1-20020a2e9001000000b002b0304609c6mr332038ljg.9.1684965804376; Wed, 24 May 2023 15:03:24 -0700 (PDT) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id y14-20020a2eb00e000000b002af0464353bsm2177846ljk.106.2023.05.24.15.03.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 15:03:24 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-4f3b4ed6fdeso1509101e87.3 for ; Wed, 24 May 2023 15:03:23 -0700 (PDT) X-Received: by 2002:a17:907:268c:b0:96f:65db:d6d2 with SMTP id bn12-20020a170907268c00b0096f65dbd6d2mr16749757ejc.14.1684965423649; Wed, 24 May 2023 14:57:03 -0700 (PDT) MIME-Version: 1.0 References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-2-mcgrof@kernel.org> In-Reply-To: From: Linus Torvalds Date: Wed, 24 May 2023 14:56:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection To: Luis Chamberlain Cc: david@redhat.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, lennart@poettering.net, gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, lucas.demarchi@intel.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 2:52=E2=80=AFPM Linus Torvalds wrote: > > Stop adding horrific code for some made-up load that isn't real. Even if you trigger some "worst case 3x memory use", that is _temporary_, and will be free'd in the end. The patches to "fix" this are worse than the disease. Linus