Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp127880rwd; Wed, 24 May 2023 15:20:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ66GCvrkjN4tPEOC6kBtrL/+/NXoEZKJBpW9+oqa9d3y4xzYnymtdHpjmjc74UF/Utf5uT3 X-Received: by 2002:a05:6a00:124f:b0:64a:fa71:a98f with SMTP id u15-20020a056a00124f00b0064afa71a98fmr5341549pfi.13.1684966842154; Wed, 24 May 2023 15:20:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684966842; cv=none; d=google.com; s=arc-20160816; b=vXvcUos9elt5K8CAoY6waCv0eZ5KhLVCmxTGewYlGRLHO0AccMff3ZekKU2VrEB2ar kp3KPted1j930jUeh1+Da4pzQqCz1399AZLGbhYiLQ5sZL1gjwL1QMncDNEymKVxXvnf 8/RtuXwdvzi/YcV1ukG9JRsMiXLJgh7Es548GbqjNd3k5axhQ5h/XiDTSlv5P+LjaRcQ UW+5YOVQAvWUc/Uc3qsPGaGdTRbSsx5wxhEQxqcnAMpzlUptnwh1yPtGLVI1ie9z1zGY oAeYfH0oaViCiWqHDNICXeLD82vBZ31YKtxHv5xl1kaKfJ+VRUW4oAbZ7kz5bCiP4AUz 2Q3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/JToQHdkxgbDyu1xaJQwVWxSodxYnloGI/u4TaisGIw=; b=i/kP2v7iz3E+Tr1Ch/P27MYZrfZbgy0Pnl5CUM7z6tFI4GWbr36ZFWPefLUJdEQrX0 sIFLZBljKzp/VivIY22hfTcuAGSTKQjrBlTNOU/jIUUm95IHgyr2HahxmHiFE4lsrJKz lHyt6WKcTXtS8xR2ZNWNm9oIsirEfnpOBndpoUH68Zp3M76y9GTJI4xMSXy4COl6lVpO pHVe4b+bH1snS9Y4Zstx08Gx+JJv+AqK9fwg8fWjBss+3qVvt3jgjglzsviL68IkpfZP GbWT1wW6wLky7ADF+OKAIGahZfiEdsZewdH/YikknxDkZl5ZkSr4PGsCWte/4JvZ7TWF 8OJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=c9zMLElg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y24-20020aa79af8000000b0064d35afbf07si9052396pfp.152.2023.05.24.15.20.11; Wed, 24 May 2023 15:20:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=c9zMLElg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236412AbjEXWII (ORCPT + 99 others); Wed, 24 May 2023 18:08:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233881AbjEXWIH (ORCPT ); Wed, 24 May 2023 18:08:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BBB7122; Wed, 24 May 2023 15:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=/JToQHdkxgbDyu1xaJQwVWxSodxYnloGI/u4TaisGIw=; b=c9zMLElgRCGRia6SL8BuLKzB7B Mq+Qz2ZTPnhGMkg0GqFoMp8NImins+kYcs+UlKaemxvTM9avgqVIft1UaVmAM9iPgY6bsqW2N9UcD GitGvwsNHQxiFG9f8hEtykExK9rUUHyTd6y3HFt/7lsJPwgsvGCa2SPXxLfuONcbljL0O7kn/HK/a ujZGfNbX5tv7OqaDvhqDQ3rikEiwcj6GKTPRRcHz0XKhM/FS9p0K7wsuioA/p6BK5z/Kjw8r8SKhY NE6gzr+49AfB4wU6dqYtEyGR/xflH8FHzNBLCEoBJwdnh+rP+Y15Z/R63lCDLuDRK2sjFFjjui8Ga jgjZVgVw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1weA-00Em4l-06; Wed, 24 May 2023 22:07:54 +0000 Date: Wed, 24 May 2023 15:07:53 -0700 From: Luis Chamberlain To: Linus Torvalds Cc: david@redhat.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, lennart@poettering.net, gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, lucas.demarchi@intel.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com Subject: Re: [PATCH 1/2] fs/kernel_read_file: add support for duplicate detection Message-ID: References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 02:56:47PM -0700, Linus Torvalds wrote: > On Wed, May 24, 2023 at 2:52 PM Linus Torvalds > wrote: > > > > Stop adding horrific code for some made-up load that isn't real. > > Even if you trigger some "worst case 3x memory use", that is > _temporary_, and will be free'd in the end. > > The patches to "fix" this are worse than the disease. Fine with me, we can punt back and wait and hope udev fixes this. No one can tell me I didn't try. Now let's hope userspace will try an alternative. Luis