Subject: Re: idio{,ma}tic typos (was Re: +
	fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree)
From: Pavel Roskin <proski@gnu.org>
To: Josh Triplett <josh@freedesktop.org>
Cc: Morten Welinder <mwelinder@gmail.com>, Alexey Dobriyan <adobriyan@sw.ru>,
       Al Viro <viro@ftp.linux.org.uk>, linux-kernel@vger.kernel.org,
       davej@codemonkey.org.uk, Pierre Ossman <drzeus@drzeus.cx>,
       akpm@osdl.org, linux-sparse@vger.kernel.org
In-Reply-To: <470D1535.6030708@freedesktop.org>
References: <20071010104540.GA6366@localhost.sw.ru>
	 <118833cc0710100635x205503a2peb73d24384538afa@mail.gmail.com>
	 <470D1535.6030708@freedesktop.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Wed, 10 Oct 2007 15:02:27 -0400
Message-Id: <1192042947.29176.2.camel@dv>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1025
Lines: 24

On Wed, 2007-10-10 at 11:08 -0700, Josh Triplett wrote:

> Sparse has a notion of "integer constant expression" already, which it
> uses to validate expressions used for things like bitfield widths or
> array sizes.  I could easily have Sparse warn on any use of an integer
> constant expression as an operand of || or &&.  However, I can imagine
> that that might lead to some false positives when intentionally using
> an integer constant expression in a condition and expecting the
> compiler to optimize it out at compile time.

I can imagine 0 or 1 being used, maybe -1, but hardly anything else.
Maybe you could add the code printing the value and then get some
statics on the actual Linux kernel to see which values are common and
which are not?

-- 
Regards,
Pavel Roskin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/