Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <82a3de3f-acef-c8d9-000c-8a54c2276b77@intel.com>
Date:   Wed, 24 May 2023 15:22:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] igb: Fix igb_down hung on surprise removal
To:     Grant Grundler <grundler@chromium.org>,
        "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>
CC:     Pavan Chebbi <pavan.chebbi@broadcom.com>,
        "Neftin, Sasha" <sasha.neftin@intel.com>,
        "Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
        "Ying Hsu" <yinghsu@chromium.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230518072657.1.If9539da710217ed92e764cc0ba0f3d2d246a1aee@changeid>
 <CALs4sv2+Uu=Bry=B3FYzWdNrHjGWDvPCDhTFcNERVpWTjpmEyA@mail.gmail.com>
 <CANEJEGuzoBa_yYHRCa0KygUe=AOhUkSg4u6gWx+QNCuGtKod2Q@mail.gmail.com>
 <52cfebaf-79f6-c318-c14b-3716555d0e8f@intel.com>
 <SJ0PR11MB5866456B9007E3DC55FD8728E5419@SJ0PR11MB5866.namprd11.prod.outlook.com>
 <CANEJEGsOU3KkG5rQ5ph3EQOiBvPXmhUk7aPvM3nj5V5KudP=ZA@mail.gmail.com>
Content-Language: en-US
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <CANEJEGsOU3KkG5rQ5ph3EQOiBvPXmhUk7aPvM3nj5V5KudP=ZA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzlNb2doTEpXSGNGTHQ0YzNaMGZvcm9WeTdZMXhBRThidTBEU01yTW5mVmpJ?=
 =?utf-8?B?RHdjOENPWTZRVnZBSkFtcXpPcjVFaU5FZzVoWXl1MDI5YWlhbUlpbnJPSDR6?=
 =?utf-8?B?eDFQVmJKY1NXbVlXQlBYZ0pIMzJHVy96S3FLVzRobmtEVUYreXJRMGtFRDZ0?=
 =?utf-8?B?azRDOWpUek52dXU3dHJvV1BpdUNXUmJKenAxM0UvTFNTWHQyMWhYUThBR0py?=
 =?utf-8?B?MFJVc0NmTjYwbW93enRPVjgzTTZsY2FpMGtCaFBuelpOc3YzTEE1SU9WS1Nr?=
 =?utf-8?B?QWtwNmNJemRNaUFmaW5Ta29hRmd4OFhEclJyTEp2Y29ZQ20xbHlrbGJYK1hq?=
 =?utf-8?B?VVRySTRnYUdUVkY0L1J1bHFmU0RjSCtJclQ4M2kzdFNTdnhWQWJXeVdEbXFJ?=
 =?utf-8?B?SHVSQ2tTRDBza2xqSWJFTXgyMmhtQzZOTHpiL3djTUdIZjd1eVJuZFBZTWVZ?=
 =?utf-8?B?UjN6aW1ib3pIbTlUYUR0SHAyOEpoYy93OUw0MGZkdi9lQjIxVjdBZlFkNHdQ?=
 =?utf-8?B?Q0RxbXlOWUcvVTBhV2ozSldEK3ZpaHNCTEU3WVhzNmNNNEVKemVqYVU5MXl0?=
 =?utf-8?B?N3JTT1p0SWZuQ2ZpWGFaV0dCcG53V0VLYkZwWGE5VGlISEIrSVdMbFR3MEo4?=
 =?utf-8?B?K2RUbFhvOEw4VWIyWGRaZGZZSmR2NnNiZTNZelVLVUs3WnA4eThDbVR2YVAv?=
 =?utf-8?B?SElVbVd3Y1VLSzFyMytaVDlOaXlmbzhBazFmQ1k1VzdlcWdmZmFiMFoyUGQ0?=
 =?utf-8?B?c0h1VndTYndWcUFFSzlPR2hJdzVPQUdMR0h2STlIQU9hSnNrQUxzWVFDaEFB?=
 =?utf-8?B?TlVUSW8rUndJY0RxQWZDWXBuT0FrcjErSVU0alNpZElNWGxlOHhvL1dHMkIx?=
 =?utf-8?B?NjEzMFUrZm14dXBzYWRNTkFiSmYvS21QYjI1RERKR2R1ZEZpZnBMMmtuVGtE?=
 =?utf-8?B?TnFMZVl4VzNheHdQSHNNSGRsRGRCa3NpeG9RQlR0YTA3ZlhHWUxKUEZBTXRx?=
 =?utf-8?B?ZXZtNHZ6N2EwZEJ6cTFtcERQSzI0dmEzNlBWd1BZdlNCZlpGTTgyWmtFZmpw?=
 =?utf-8?B?amVTTWY2S0MzbzVEUWthV2Vjd0V5eEd2NjA4VUVzd0kyVjh1T25aRDRrNjlk?=
 =?utf-8?B?aDFwVGdwVDB0WCt6dERYNEMrR0Z4emRzaGRHQjFPcmZuMTZPenZ6Q3E5eHZv?=
 =?utf-8?B?eW9aOWJrejdWWnE1d05xL2d0T0g0REJJMDdTa3BPZVFBTnU2NmJxbTVkY0Nr?=
 =?utf-8?B?ZVdlSmhWWVN3ZE90VW8rU1NsNVhZR2NxL2REY3NuUWtJQXptMzBjTCtRNS9E?=
 =?utf-8?B?eDZxdVB2dFpGUnJYZ1RpSjV5YWxiMTlOWWhYZ1VWNHlIQndiMUIzZnBrTWtW?=
 =?utf-8?B?MElseUlkQ2tQQXF3QXNOeVIzaWhsb3gwU1J1RW44TTRIV0F6Tzk0VUkvUFhu?=
 =?utf-8?B?cFFJT2lWVWsyaVk4UGlJblhCYjdlVXQ0SHo4bDN1Ni8yOHdNaVBJNEtjTldJ?=
 =?utf-8?B?bWM3aHRXUFBUOU9vK1RaWDVXVHNDMWpkODRwWlhocHZtU2xOalJ3WndScGxr?=
 =?utf-8?B?blJZNFhHcVBINGN6a09IcWxyckRVNXJRRXNQazB2T1BCZ3d0azdrOStCYkFn?=
 =?utf-8?B?NHNGbzhHWVNCU2NqcjNqWnpjNFBobTFMVmpIZE8wWm5VMGZDbW1HN2h2di8x?=
 =?utf-8?B?NHhYV0Ztd1ZOeVkvT1lYZDh2QUFuUG1HaE5JNXZNNnlNb0NaOFc3K0EvR1FD?=
 =?utf-8?B?emNGNTk4MGFVVldYUzR3clJ5TkZ1L0V0N3lVS0w5SXR1b3RXNEttZXZrcTRv?=
 =?utf-8?B?Y0RQR1N6QmkrS3grWi9WMUJQa280UjNRUFF1U2JaakI0bk0xeWtjTGJQelN1?=
 =?utf-8?B?UlA1MVMyc044NUtUZmV0dUJOQU9vRmZUQ0ZPWHBDS0ljcVk0TmZnaVQ0YUdX?=
 =?utf-8?B?c3I4eGJhTytSRUtUY0VJcEpkQWh6U0lqV0t0cDRtSDJIaWpVZUZtTHNBVVUv?=
 =?utf-8?B?NjM4RDBVeUZmK2xGKytCOEUzQnk2SDhmU1hZS0JhVFEzbXpYMzVuMzhXUHhM?=
 =?utf-8?B?ZktMd1BmVG9iZzk1dmpsVVVsRmF3dElQRFlPT3Jkd0YvQnhwT0UrV3lxV0oz?=
 =?utf-8?B?WldjNEpTRVpybGR3cnZJNlMrRUZ6R0x1MWJPbHRDOVRzYW5yOUJJOVFtbTJJ?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a7d1dace-7573-4c16-4b28-08db5ca5681b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 22:22:49.1348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cBNu8/sl/qL9wnFaIbyCDve4Lnm0LIYYG3YMvT6XURYIqMzJrRkfVQoGpBRGmvnf0KZlphRfd2yDCSSsmEk2ygPsuIxpAIs9rfOb2KmyIHI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8374
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Grant,

On 5/24/2023 2:01 PM, Grant Grundler wrote:
> On Wed, May 24, 2023 at 5:34 AM Loktionov, Aleksandr
> <aleksandr.loktionov@intel.com> wrote:
>>
>> Good day Tony
>>
>> We reviewed the patch and have nothing against.
> 
> Thank you for reviewing!
> 
> Can I take this as the equivalent of "Signed-off-by: Loktionov,
> Aleksandr <aleksandr.loktionov@intel.com>"?

Unless a tag is explicitly given, I don't believe one can be inferred.

> Or since Tony is listed in MAINTAINERS for drivers/net/ethernet/intel,
> is he supposed to provide that?

Assuming there's no comments/issues brought up, I'll apply it to the 
respective Intel Wired LAN tree for our validation to have a pass at it. 
Upon successful completion, I'll send the patch on to netdev for them to 
pull. Hope that helps.

Thanks,
Tony