Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp485012rwd; Wed, 24 May 2023 22:40:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ74S0eLbKTeBuCHLbXADvAPkw4RpovEv0738OdYgX5LrQl7g+zRl200eF+4/NZWBepQ/Xuc X-Received: by 2002:a05:6a20:3d8a:b0:103:b585:b587 with SMTP id s10-20020a056a203d8a00b00103b585b587mr1987009pzi.13.1684993233479; Wed, 24 May 2023 22:40:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684993233; cv=none; d=google.com; s=arc-20160816; b=rRxZTr0SKDehG/h6UrisUfGtS3aLt/jzbpnX0yBhP3EeIotUnQGY1a1THNrtTGpPsN rA+bxTm+wrC4ZwHXd5MPFt8JRl1lmM7PY0s9j1MCHp+y9Zx7DZRlGNeMv2No1t+kwSB4 1s1hAQDUm+PyK4Z9Z1lhP9RBlIQFT7vIPcOwA34j6lbPMh5XuTxQQZQHZ4xzxfaMFE/U IqtHTkrsmvOnuKu4H2hvIw96TnL/A4fOITvpufZ0rczrfyuueGqh5t832JpDjAUmoODD G46P1Nsyd5NI5g6aYkZfbnlHCRW6x/vlpZAmU6PwD2WeKS39W+yceeKLCzNAlqw9I3VV DHvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UROUuATZxgOXUb8JJ+HqYVuxFFmdjwuqqFkEOBHnsjw=; b=l7bWlIgWGVqqMkMqSKLZG4kU03uTja5P5IB5W+ZkWmQdtsXqkdFjy7Tn/1R6RAVJsb iptd3jx4Q7+V98rVRN7nJpc9JkP9Pw0mgjBUxmgdZx9TA9xyW953fmU+6kEbCu+kgyLR ARK2UmLCrDdLjexRjMaebdYBIQl3joZziqpewpGNAfk1N4+58LFZsbln6lVeLnyy2c8G QJL4zFjCSvHCkey4WsfOzDqMOJ697My3eLjfmtYpc2PRpavkOP6JBK2a0MkIHXsCIl+R rDVa5nlNdPrWfYJrWOkz/4APu2yM2kFeHo6LW0IiOKnUKsmLPF3QurZRmAKuhNbPUFlV Ghow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HgYj11H+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i11-20020a056a00004b00b006436b625317si665258pfk.122.2023.05.24.22.40.21; Wed, 24 May 2023 22:40:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HgYj11H+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240063AbjEYE5G (ORCPT + 99 others); Thu, 25 May 2023 00:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233778AbjEYEzV (ORCPT ); Thu, 25 May 2023 00:55:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 638BE19A8; Wed, 24 May 2023 21:52:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 059D7642B1; Thu, 25 May 2023 04:51:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D09DC433A1; Thu, 25 May 2023 04:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684990315; bh=vqN46RB7k0amDHt8lyz2DGuXkSMhCOcUBmnoXjeu9Gk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HgYj11H+SrBzPjJk7gdM7kulvt+wzB9LkdFuXtHr4uaFyRXnhQ1Axpzya2knYhi5r ppX/avnvcymQdW8COD3QLuq/U12xQiIsbpSrSl7uDJ6YA2XllIVvFtBBEQJH1nHAxD SKO0FPj3Ax725dHl8WvlEAheX+MBbnrpRZjQqI5HfyiUunMBHt2nUHI+aNoOJewxS/ ItjSX8Un9o234EKSktpeatVsH1psOOysHJ0wahzgjY5EmGNXBbkH0DP5v8jMWmLIpp Cl+XF0snhlCGjECWEW9rOPvr39KRhgEfUHiIBGz9cRQA2CcZD4tKPF5v3RPuiO6H8S kaaLLak6bv2fw== From: Bjorn Andersson To: Gokul krishna Krishnakumar , linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Konrad Dybcio , devicetree@vger.kernel.org, Andy Gross , Satya Durga Srinivasu Prabhala , Sibi Sankar , Guru Das Srinagesh , Rajendra Nayak , Melody Olvera , Elliot Berman , Trilok Soni Subject: Re: (subset) [PATCH v6 1/1] soc: qcom: mdt_loader: Enhance split binary detection Date: Wed, 24 May 2023 21:54:33 -0700 Message-Id: <168499048178.3998961.10672158686017676650.b4-ty@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230509001821.24010-1-quic_gokukris@quicinc.com> References: <20230509001821.24010-1-quic_gokukris@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 May 2023 17:18:21 -0700, Gokul krishna Krishnakumar wrote: > It may be that the offset of the first program header lies inside the mdt's > filesize, in this case the loader would incorrectly assume that the bins > were not split and in this scenario the firmware authentication fails. > This change updates the logic used by the mdt loader to understand whether > the firmware images are split or not. It figures this out by checking if > each programs header's segment lies within the file or not. > > [...] Applied, thanks! [1/1] soc: qcom: mdt_loader: Enhance split binary detection commit: 210d12c8197a551caa2979be421aa42381156aec Best regards, -- Bjorn Andersson