Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp488632rwd; Wed, 24 May 2023 22:45:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ZZMSf7OsADhE9aQOztdXS3BMiipU5sa2wvbC0J79+6LrKmyKFNPjQF13AIhTPOnp6L84V X-Received: by 2002:a05:6a00:2da8:b0:64f:5406:d59e with SMTP id fb40-20020a056a002da800b0064f5406d59emr6131642pfb.17.1684993525281; Wed, 24 May 2023 22:45:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684993525; cv=none; d=google.com; s=arc-20160816; b=b04pH1L7LOvDU7JZW+W2tmh2uIfawIbW7MPs6eRdqYtwmaw/ZVkbEHB0eQUEuxHDBs UEN1eBLZLtHAgdRnVQWF2RJeC/amUEqtgNviOe5W3G6+RTHzBjsUeha5ASP3k4k+ygC+ rLldTre5ztj8Z1ROPc6+Zj7+cW18tumrUxbRq0e7xiOqWEAFxOMz+N5AA3u9J4QtY5jB hGFzdhEpAb+FjjJ2SKnhI8Th9ktpAqBio0/HCoGUSVeryyx6JHBr5nrQXwaMXyp+y+l+ AR4OaNasqBPUln9AYWIVSHepasEChXeIBlVtLoS7mw05RJTsxVXVwT6wEnntN5iAT+rc pxeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oCdqZSsjEhQUEcvKQ/XSVRMOkUJJERbnSe/KSFQ/mgI=; b=fwSL3SZfwvP3RljCe6wEyeDGlVYfesayILxv8GzQ1yTAS9uWDCdaQ43z032VCwiPt7 pFcuS5eQXFIR7clc0i5WB1halp4DksrPeL7bOmoj1fGrewvtiXN3L31/N17jvs3u2sLN aGl65CIzxc+zPj9x8ry7CSxnSBLHpc90TNqJuOzdNXkOZ0ONcfCmPJ/AuWXEBCWfhVuJ hUUennVpb5YPq862ZmNBNnkTx7j2KnKFL8PtoebjWQWYjmhA8T9/PlXVoH3FLTJJi0VT kla2TmbZAIgjODlgvFLVXVl8IQmPOyBO4Bj9x2ANd9PD555e/hOuHcXt2Lc7kZvcxfe/ ktyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ID5Orvp1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p189-20020a625bc6000000b0064f50a4a515si724229pfb.37.2023.05.24.22.45.13; Wed, 24 May 2023 22:45:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ID5Orvp1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240249AbjEYE5y (ORCPT + 99 others); Thu, 25 May 2023 00:57:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237808AbjEYE4M (ORCPT ); Thu, 25 May 2023 00:56:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0BE6E4D for ; Wed, 24 May 2023 21:52:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5CBB464298 for ; Thu, 25 May 2023 04:52:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 667ADC4339C; Thu, 25 May 2023 04:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684990327; bh=y2L/IIIbUSQAirgDGHF3NbV/KKuT0WS9p4HR8mVBkSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ID5Orvp1ODegRGJbUG8c0Cm5CDTwM7ob6aTRO9UcmEw0rkVGLsEhVxexdPXfHu2n9 0158iHwyq1xRryFlewp5ZX8pdUtnEmNCNasp+DgGR8u1kn937xGb1M1dOw0icJNHYq V8/Dvt3r0qCoUlo6k69kHda5aeKNj16ZKZ2e4uKI/jHk7osGCZyJ1vCql0L4O3j1UX adpecbYUzYfYrD5m/mz4081E21uUqpS/+y+etWfv9txsGYpw+oRtue5aJO8VBJli/I QxmWTrdvoAsEOF0dL82GgpbsgqlYI3hBrDQd5lEIdbOl4BZpO14UYXlE0r/u3uRmO/ UUg4XZLJZnbyg== From: Bjorn Andersson To: jiangshanlai@gmail.com, Tejun Heo Cc: kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: Re: (subset) [PATCHSET wq/for-6.5] workqueue: Ordered workqueue creation cleanup Date: Wed, 24 May 2023 21:54:45 -0700 Message-Id: <168499048181.3998961.3057649391948254093.b4-ty@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230421025046.4008499-1-tj@kernel.org> References: <20230421025046.4008499-1-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Apr 2023 16:50:24 -1000, Tejun Heo wrote: > When multiple work items are queued to a workqueue, their execution order > doesn't match the queueing order. They may get executed in any order and > simultaneously. When fully serialized execution - one by one in the queueing > order - is needed, an ordered workqueue should be used which can be created > with alloc_ordered_workqueue(). > > However, alloc_ordered_workqueue() was a later addition. Before it, an > ordered workqueue could be obtained by creating an UNBOUND workqueue with > @max_active==1. This originally was an implementation side-effect which was > broken by 4c16bd327c74 ("workqueue: restore WQ_UNBOUND/max_active==1 to be > ordered"). Because there were users that depended on the ordered execution, > 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered") > made workqueue allocation path to implicitly promote UNBOUND workqueues w/ > @max_active==1 to ordered workqueues. > > [...] Applied, thanks! [14/22] soc: qcom: qmi: Use alloc_ordered_workqueue() to create ordered workqueues commit: 56310520308ab863030e9baa9a8f63bb31c94e27 Best regards, -- Bjorn Andersson