Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f02c78e2-34b9-4985-640a-279dae1004a9@amd.com>
Date:   Thu, 25 May 2023 10:46:01 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v4 3/4] perf/core: Remove pmu linear searching code
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     peterz@infradead.org, namhyung@kernel.org, eranian@google.com,
        acme@kernel.org, mark.rutland@arm.com, jolsa@kernel.org,
        irogers@google.com, bp@alien8.de, kan.liang@linux.intel.com,
        adrian.hunter@intel.com, maddy@linux.ibm.com, x86@kernel.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com, maz@kernel.org, oliver.upton@linux.dev,
        kvmarm@lists.linux.dev, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230504110003.2548-1-ravi.bangoria@amd.com>
 <20230504110003.2548-4-ravi.bangoria@amd.com>
 <20230524214133.GA2359762@dev-arch.thelio-3990X>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20230524214133.GA2359762@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXN1d2thRmNIWlRLYzRjMjB3YWZuU3ZDRHg2R2p2Wm1ELytyWTZLb0dsTlFD?=
 =?utf-8?B?clB5aGRvR0xJR0pOMVJZMUZnNTJIOUFvMFBKOWp5MFpSdXRLTzF4UkpGRmkv?=
 =?utf-8?B?SnVMekQyYXZpN1RURWkwVUxEV0VlNDlCcDE2M3hMK2hrSjFuN0hkOEk5L1Ew?=
 =?utf-8?B?TzgvVzJ3N2JtL2hsemJuYVM3NkVpcDBTSk9QZTNoVk5FeTlQbnptOE9US2x0?=
 =?utf-8?B?QmQ5bTFkcTFuSTljN2RkUW9qOUJJZ0RzVXd2VHhsV0MzQTV4NEs2SDJSaEho?=
 =?utf-8?B?dFNYZkFnWTJDUmJmYXR6UW5TZ1VTRnQ1KysrV21xNVJoOFBoNnhtaGs3bEZS?=
 =?utf-8?B?cG5UZWtvUGJUR2tSdDB3YWNjMmVtRFdPeWRRbG02Q1pCRUxYR3dKL1pQejJJ?=
 =?utf-8?B?Zk5NMzIwZnUzS0RjdS9adDJrZHQ0cmJFZ3FrVVA4OEZ0TzF3R1ZZSmMzS3R2?=
 =?utf-8?B?OU1lbFBLUm8wcENsMmhnTjI2SE4xUTlmdzUrT3pYdkRDMkJKUlpyRFErRU4r?=
 =?utf-8?B?ZmJxVlFUWUROVVNjdzQ4Z3YrUHorai9CTW1rWExKOWFBVlUrOGRXZ3dBMTJq?=
 =?utf-8?B?RDQ5NS84S3NoSkx5L0hJMC9pbFp4Y3hTWnd4R2xEUEhobDZaZGcrNVF6SWdr?=
 =?utf-8?B?YmZjcWNZbDNmc0QvNFIrSXhiV0lMZ3VoQWZQd3ZzSFdnYmw5RXBHWGxNUTRJ?=
 =?utf-8?B?QTkzNkpvRWRYdzc5eUZBb053ODJjTWVXR01RVDR4MzVhYjFKclJpSGdVL2Vh?=
 =?utf-8?B?Y2IweHpNTlZQeVg3YVBJTm9zZmxrc2MvVW5BQW11V2Z2bDgzcHZrS1VFMHlY?=
 =?utf-8?B?cDFsaEdrNWdBN1VNVnRSQUpJM1NEN1VFVnpvZlV1cFd4K2xUQ2NGS2R5aTlF?=
 =?utf-8?B?N29rbDRWdnJ4Y0QzWk9WNGZrRXJvN1dlN2N2aDA3dWx6akJhb25lMjc4NTNE?=
 =?utf-8?B?K3dsSkovZ1dna2VTVUxEdXRoNkwvby9JSGZjQ25LQmlhcTB4YzFQbGhEbEo2?=
 =?utf-8?B?Mkd4U21TbVU1TVUvUVlYdmM0K1Q0bDNFWlpVYVZ5ZnlQWm9YaFB1amxuUkMz?=
 =?utf-8?B?QnM2K2k1bmtXZFRrVlFuQlg0b25VTkk5WXFuWVN0bUdoemtGa2VYREFTVm5q?=
 =?utf-8?B?bHJJaWM0ZTZKaC80TjNWOVYzTk1VSGtqODV3M2s2WTZWOFNYT25oNU1EcE4r?=
 =?utf-8?B?MGVyYlZ3UVU1d0dUVWxmUEJGajlLTzM4VTdaOHBiclhyQ2ZscHg1UHBadDNn?=
 =?utf-8?B?ZEhNOVhYM3JuZmlPMkNUU1NuYVBKdTBPQ2phUFRnMnExK01oVytsVHN0T2Nz?=
 =?utf-8?B?V2FXaGVYMkpsZ3czUlB5YWlpcmtpZFdJQWFSekxCZFVtVU1CYklMVnpCSTdJ?=
 =?utf-8?B?blJpbU1QRlhCbVFIUHRWK2tLQk9vTXhlVFg3dnZyM2dDOWZyZWcyNm16SW5h?=
 =?utf-8?B?V0FFWjR5bFIvMjYxUjJMOGZIRWV5TTNqRnlZeXBDUXNSRmhxN2RJazlWekMw?=
 =?utf-8?B?MjU5WEhBcmxmWFhLRmk5RHh1NVBpK0FYZzdRL2hCejIycGlmbmV2MzZDN1k4?=
 =?utf-8?B?ZndTMWNiUTNhR0w3S0xZOU5NOUV4NW9KaGtOMEFER2RYZGd3NjU5KzVLKy95?=
 =?utf-8?B?S0Y1UjFGakwxU1R5OG1JcExZdkVJT3YxeVZQM29RR1dvQ2w3TUorNkR5cDBL?=
 =?utf-8?B?VmVRUzVMeUlaNTRldDNyc3JJdzVhR3hQNHNmM1hpUDR2d0FIMFdxV2JQZUR0?=
 =?utf-8?B?Y1k5Qy9udDlSVDdHNFRqc3RaVGhrV01zUkMzRUNBVkR4Q1V1aXRMVmM3N2hr?=
 =?utf-8?B?U0hnR2J1NzhncW4xL09hYVFMSDZ4YXhJWW44NFNWZlNMSE9GNTBKb0pUeXFy?=
 =?utf-8?B?WkpBUVJLRWU5TG5XUmcvWDhScXZTRHBWcmxvRmVkOWlxWWpiUHd1cHMxVktG?=
 =?utf-8?B?RzM1aUFuRGt3a2grQ1BnZEp1N1VTUHNNNkZITlJGY1BWbHpyU0MraHBtMHlN?=
 =?utf-8?B?amNDSUVqTzRkNTEzdmtaTTg5UmVXSDdXcUZlYkEzejc0R1QybStXZnRld1o2?=
 =?utf-8?B?Sm9UMDQrdnNBSTRUbE1hYmtCWHdST2VhbFprVndwSTd0d0dVczJUTVFUYUdx?=
 =?utf-8?Q?l91LcKrGSAFAgyJFeIxObilBb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e00d1c7e-ac10-47f5-bd7c-08db5cdf510a
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 05:17:21.4454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A+R5Zw9rZqQ1TTt8kh5v1cYp110+zGR71xh5BEhIuztJU6DrTTm00KUJzjRnuFqz6Bx5J2WMx7BJRDp7ky+1YA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6978
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Nathan,

On 25-May-23 3:11 AM, Nathan Chancellor wrote:
> Hi Ravi,
> 
> + arm64 KVM folks
> 
> On Thu, May 04, 2023 at 04:30:02PM +0530, Ravi Bangoria wrote:
>> Searching for the right pmu by iterating over all pmus is no longer
>> required since all pmus now *must* be present in the 'pmu_idr' list.
>> So, remove linear searching code.
>>
>> Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
>> ---
>>  kernel/events/core.c | 37 +++++++++++++------------------------
>>  1 file changed, 13 insertions(+), 24 deletions(-)
>>
>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>> index 0695bb9fbbb6..eba2b8595115 100644
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -11630,38 +11630,27 @@ static struct pmu *perf_init_event(struct perf_event *event)
>>  	}
>>  
>>  again:
>> +	ret = -ENOENT;
>>  	rcu_read_lock();
>>  	pmu = idr_find(&pmu_idr, type);
>>  	rcu_read_unlock();
>> -	if (pmu) {
>> -		if (event->attr.type != type && type != PERF_TYPE_RAW &&
>> -		    !(pmu->capabilities & PERF_PMU_CAP_EXTENDED_HW_TYPE))
>> -			goto fail;
>> -
>> -		ret = perf_try_init_event(pmu, event);
>> -		if (ret == -ENOENT && event->attr.type != type && !extended_type) {
>> -			type = event->attr.type;
>> -			goto again;
>> -		}
>> +	if (!pmu)
>> +		goto fail;
>>  
>> -		if (ret)
>> -			pmu = ERR_PTR(ret);
>> +	if (event->attr.type != type && type != PERF_TYPE_RAW &&
>> +	    !(pmu->capabilities & PERF_PMU_CAP_EXTENDED_HW_TYPE))
>> +		goto fail;
>>  
>> -		goto unlock;
>> +	ret = perf_try_init_event(pmu, event);
>> +	if (ret == -ENOENT && event->attr.type != type && !extended_type) {
>> +		type = event->attr.type;
>> +		goto again;
>>  	}
>>  
>> -	list_for_each_entry_rcu(pmu, &pmus, entry, lockdep_is_held(&pmus_srcu)) {
>> -		ret = perf_try_init_event(pmu, event);
>> -		if (!ret)
>> -			goto unlock;
>> -
>> -		if (ret != -ENOENT) {
>> -			pmu = ERR_PTR(ret);
>> -			goto unlock;
>> -		}
>> -	}
>>  fail:
>> -	pmu = ERR_PTR(-ENOENT);
>> +	if (ret)
>> +		pmu = ERR_PTR(ret);
>> +
>>  unlock:
>>  	srcu_read_unlock(&pmus_srcu, idx);
>>  
>> -- 
>> 2.40.0
>>
> 
> My apologies if this has already been reported or fixed already, I did a
> search of lore.kernel.org and did not find anything. This patch as
> commit 9551fbb64d09 ("perf/core: Remove pmu linear searching code") in
> -next breaks starting QEMU with KVM enabled on two of my arm64 machines:
> 
> $ qemu-system-aarch64 \
>     -display none \
>     -nodefaults \
>     -machine virt,gic-version=max \
>     -append 'console=ttyAMA0 earlycon' \
>     -kernel arch/arm64/boot/Image.gz \
>     -initrd rootfs.cpio \
>     -cpu host \
>     -enable-kvm \
>     -m 512m \
>     -smp 8 \
>     -serial mon:stdio
> qemu-system-aarch64: PMU: KVM_SET_DEVICE_ATTR: No such device
> qemu-system-aarch64: failed to set irq for PMU
> 
> In the kernel log, I see
> 
> [   42.944952] kvm: pmu event creation failed -2
> 
> I am not sure if this issue is unexpected as a result of this change or
> if there is something that needs to change on the arm64 KVM side (it
> appears the kernel message comes from arch/arm64/kvm/pmu-emul.c).

Thanks for reporting it.

Based on these detail, I feel the pmu registration failed in the host,
most probably because pmu driver did not pass pmu name while calling
perf_pmu_register(). Consequently kvm also failed while trying to use
it for guest. Can you please check host kernel logs.

I'm sorry but I neither have Arm board to try myself not I'm familiar
with the Arm architecture. So I'll need your help to diagnose it.

Ravi