Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>
CC:     Will Deacon <will@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>,
        "Ranganathan, Narayan" <narayan.ranganathan@intel.com>
Subject: RE: [PATCH v7 2/4] iommu: Move global PASID allocation from SVA to
 core
Thread-Topic: [PATCH v7 2/4] iommu: Move global PASID allocation from SVA to
 core
Thread-Index: AQHZjZxI9J7I1OJPuUGsmbdFIDhk/q9qiCNQ
Date:   Thu, 25 May 2023 06:27:40 +0000
Message-ID: <BN9PR11MB5276F7D03C5595F03A9A14858C469@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230523173451.2932113-1-jacob.jun.pan@linux.intel.com>
 <20230523173451.2932113-3-jacob.jun.pan@linux.intel.com>
In-Reply-To: <20230523173451.2932113-3-jacob.jun.pan@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ypGpL+FS0LuzdsxGkhiHkj/1DQKzamOIqZtrMJbZEWXXXVsSz4iY4jPOHwDN?=
 =?us-ascii?Q?rqEGJeEXPUTLp6iX31XE8C+M0LtOHrxPmizLq0Nhh9uLtO9fZdQXioUx8fRt?=
 =?us-ascii?Q?BS0Rc7ndkgp4M+IM7Y5Op5t4wha0DgxGXBjyB2Xj2PIJYqgdWxJ0gBgMkAXT?=
 =?us-ascii?Q?GdOfi2SUg2mM0j7pvs8MmUcdedx9+YtqcNPBYtQRoSNA6Ia+Ei3RwbqW2+kr?=
 =?us-ascii?Q?dRxRVfRkETJhTf2RoWLDFqC0pz03wLf/cVCmMICnngJ07kpeCWH6K7m/1+Op?=
 =?us-ascii?Q?VhaoyjQr/t0AwAOrOYuhCElpjxlBkW+aVSNgfesmV01ZGHDmVIy8YxluoD9M?=
 =?us-ascii?Q?p6U0o+435aIqV2cMgn9h1G2+1ww5G2XtqECEumfQsQ/rgYQtLzVZIFJ5ZHvF?=
 =?us-ascii?Q?Sb3yXDofrOXEfsw535HBmxQkRhgUGko55VUEtVR9sfWWCmwR5QcfuB2CqgpK?=
 =?us-ascii?Q?DO4i547WCJuYicJuLb3STuir4erwJezYSOh4Bo70rfCP3T09pZvGlwLaLryF?=
 =?us-ascii?Q?Pbk6uxPKhXLF/XNs3gmITi8L6QZU+o9qtJh4GSxFkC0bjdSWrARPNRao5nts?=
 =?us-ascii?Q?sMgO2d1MT68aTtWRMm46aRreCxICCIP/WCPKrSvQkbqQyXzb7K6ZDDmO7vXq?=
 =?us-ascii?Q?336d+gkqzZfeCT1/MdkU0bQvQZmBeBiXqgb81PDKCZU9kQPN7cdVWFInSu9A?=
 =?us-ascii?Q?1s8WTuGcn/mJKr6jca03k8KJR4K8ZEzBNGfeNnFGn2wUlryFlhaCJrcmEtlt?=
 =?us-ascii?Q?LuO+GGjNeGY0LuLXkh/fBRBhidG3DxBcqu/FRfITLJjXgPQXqmrO00qv8y4w?=
 =?us-ascii?Q?7rKZS/7Z/raGTmys5CGmS/yzsTMJKnWLqY6VZ9p9LKzPdG/rBPZw0k6b76PP?=
 =?us-ascii?Q?Fib7S0+b87xPsaXgoeXOnNT9KQNwcHIVgDX6Qgm552XrGZb4t7pT7A/DFTeO?=
 =?us-ascii?Q?SzgqeKyl16ijuAXN+QK5qZrN67Er2eLeMPFjkF2Mda3VaGgMbxl4JpKRDbfc?=
 =?us-ascii?Q?iT/9F0uzp0E7XOQeLdO1LOmrpfpDT8QqelUki+lCv0IOn9IiC1/Wp+2nqk2O?=
 =?us-ascii?Q?1YUf3u+/ceUiUa4WwcJMmRcK0pzxplJDPZf5ZDBqK7kfav2f41gP/zg02tz1?=
 =?us-ascii?Q?ad2O6wSZU3brcGBCSlwYQrP0tzA9JeqXwGN/djvkjUqRhTLAxjrgnC3MfyGw?=
 =?us-ascii?Q?ElFuX/pRwUC8olWuTADjBXwQJxWssd+AZ4oAVxvmyBAePYU/TGtqYgCB3BTw?=
 =?us-ascii?Q?Js7RNHsGpjjXQfv7OQWwXLDECuWQHrqZjDUh1WqEH5ZuNGFzU4bua0oGH3gf?=
 =?us-ascii?Q?t0aD6Xbrl7O7hRSuj1qqoyK5iiIRs9vK/N2nS+15J2F3LkBO/3Px5Qy4chnv?=
 =?us-ascii?Q?4wkIwkTf1GAecd3P1+YrUvW9Q6QQvnxO8B6zoJPdA3fvZ3wUSPQ0MBRvJCyJ?=
 =?us-ascii?Q?vre0qJsNZUumZkzoW7VwOb1fv3AwGOUVkkDYc8ejxD6gcm9wgNB5tJEMnvKN?=
 =?us-ascii?Q?YH1jXVoH+0SQWEbAS6zy4vp7L5nHEXD7uj/PpbleRj6NhxIupUODk4KoDScf?=
 =?us-ascii?Q?nXMyJ8MBqQxvJhL5JmrEszmwDu2iLb/Ny3sLfiUT?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4638e807-cd85-4241-4659-08db5ce92409
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2023 06:27:40.4464
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: klzl5FcftKPOEUNgN+k1pr0xbGSZl/OvS9S1Uiw8cIky40UQl+Hmc7crh0bSe25fNbA5hEXedQ5yFNZMah6TAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5520
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Wednesday, May 24, 2023 1:35 AM
>=20
>  /* Allocate a PASID for the mm within range (inclusive) */
> -static int iommu_sva_alloc_pasid(struct mm_struct *mm, ioasid_t min,
> ioasid_t max)
> +static int iommu_sva_alloc_pasid(struct mm_struct *mm, struct device *de=
v)
>  {
> +	ioasid_t pasid;
>  	int ret =3D 0;
>=20
> -	if (min =3D=3D IOMMU_PASID_INVALID ||
> -	    max =3D=3D IOMMU_PASID_INVALID ||
> -	    min =3D=3D 0 || max < min)
> -		return -EINVAL;
> -
>  	if (!arch_pgtable_dma_compat(mm))
>  		return -EBUSY;
>=20
>  	mutex_lock(&iommu_sva_lock);
>  	/* Is a PASID already associated with this mm? */
>  	if (mm_valid_pasid(mm)) {
> -		if (mm->pasid < min || mm->pasid > max)
> +		if (mm->pasid > dev->iommu->max_pasids)

">" should be ">=3D"

> +ioasid_t iommu_alloc_global_pasid_dev(struct device *dev)
> +{
> +	int ret;
> +	ioasid_t max;
> +
> +	max =3D dev->iommu->max_pasids;
> +	ret =3D ida_alloc_range(&iommu_global_pasid_ida,
> IOMMU_FIRST_GLOBAL_PASID, max, GFP_KERNEL);

max is inclusive. Here should minus one.

otherwise looks good to me,

Reviewed-by: Kevin Tian <kevin.tian@intel.com>