Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fe5e2b36-6a8e-656c-a4a6-13a47f4871af@prevas.dk>
Date:   Thu, 25 May 2023 09:04:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH V3] soc: imx: support i.MX93 soc device
Content-Language: en-US, da
To:     Peng Fan <peng.fan@nxp.com>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <20230515063730.2042715-1-peng.fan@oss.nxp.com>
 <33d57180-aa13-4178-86e1-c4cf6ef29a6e@prevas.dk>
 <DU0PR04MB94170FE393AEE4A86ACE386588469@DU0PR04MB9417.eurprd04.prod.outlook.com>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <DU0PR04MB94170FE393AEE4A86ACE386588469@DU0PR04MB9417.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW5EczhDbEtDSjVQSWlvZ2tLVFo2NGxXbHY4ZEg2WmR3aTl0YnpaN2dVVlpE?=
 =?utf-8?B?VmZKVzk4ZzFRcWdUT2o3Yzd2c2lGdzhDMEszNmZ2WGdwRkpacXBlKzRueHZ6?=
 =?utf-8?B?UmNISjRwN004dVdKeFdoOGNsc2RUU3VGbTc2bnBLSkgzSmJFKzRJQVBmOWla?=
 =?utf-8?B?VWprSG5xNTFKVWIreDZNemVUZlJ3cWFUTHRnK3MzeS9TMVJrZTVKVGJnN3dk?=
 =?utf-8?B?ekJkTTNoN2lWR0lJS09ZWnJBUjR6UkpWR1VOajB0cGRzSUV6VlNQejlYZUNH?=
 =?utf-8?B?cno0Y1o0c0c5dS9mNHhqOHlmbG94S2YyNE1UOVlhMytkUjhJUTV5TldVb1dn?=
 =?utf-8?B?ejFOdEVGUDF0aUUwTi9SOTN0K0pLZzZTRkg1UTFSU1BMTWtRZTAyNkhkMFRM?=
 =?utf-8?B?QmFHazRybkJRZExQOVkwei9KVWpKSnNqV2s2cFc4YXBEc25rTkZVTEV2SnNk?=
 =?utf-8?B?VlVLejI3UVhnQlpNTVdJOWhtVWJIWGZ2Qzl1dTRJK0ova2hXazhPQ011Ulds?=
 =?utf-8?B?SFRVM1JNRTJ6MDBFWXlhalBUZVBXa0lQbnhTbnNmUnUraUgrVFJHWEpWTThE?=
 =?utf-8?B?THhpdzN1Q3VBWHQ1Z2RkQ0Q3K1RZVXdTQ0ZFb1FvdmhsZkhGMHBiQkFMS0dJ?=
 =?utf-8?B?amhockR5VkcvYXFXWFRPOTZWM3BSc1IvbXh5WHl5VldMUHJrNUpLMnBQV2xx?=
 =?utf-8?B?TDZNbVdBcmduZ3lhY04wNENmTE0yVTBaNVEwRmVDQzBPRHFFOWUzS1A0dGNK?=
 =?utf-8?B?YTcvUFA3cEhpRVh6ZmtLcXJhOE5VVDRVVUllYXBOb08yVWJVazBVLzlGdDNT?=
 =?utf-8?B?cWtVVFdiMGpuMnBvSVArd09HR25xZjZmcWRLaSsrQU9HY2grMjZZN05HQW1J?=
 =?utf-8?B?Q0J1d2t5d1RwRitLVWs1aFNMaENsSHMxbEZlY2t4WVlIZXRpQWdLekhkemFW?=
 =?utf-8?B?WDMzcVp3UklPb0lkd1VXczhzZjFZanJxaHI3Y3JjUUNqMExZM243anhGU1pL?=
 =?utf-8?B?ZmRTdEVlUndCdmJmYmdZR3BsN0taVWx6U2tLZ2FnU282L1pPYWRpcGwwdGIy?=
 =?utf-8?B?RVQ0MUI4THVUcm5qTHZNcFR0MFljWkJTKzZWODRReTNXbW15NVZOZFFNMnpY?=
 =?utf-8?B?cVM0SXBiN3FJbjlzZEVXOCtrZVlObnR6TVpHbVNMZ3BldVdZYm1sS3BvcEZn?=
 =?utf-8?B?V016ZURBSmFEZ3l0WktHOUwvdnZQNzFJcFlRditBVk11Zm5NUlI4U1RPMFJS?=
 =?utf-8?B?WTZ4aWp1RU0xcUw2UFZwSmpiWHpNcWh4NHFaMGpraUhWNUJIdVNsdUFuLzcy?=
 =?utf-8?B?MjRUUWxySXRXWVNwdUNFbVViNXlaRUtwM1pYdVNQKzZBY0Rub2MvbGV4Vys1?=
 =?utf-8?B?T1JlLzk1dCt6Y0V3M0xhZkNuaXg2bEpYbUVUZDhrMjNOTjMxc210SXd6R0xn?=
 =?utf-8?B?UDZhY0pkNFRtRHRqSmFOOWphbHVCZkh0eTViT1BMSmNRWVFzYzRQNzNpRWFq?=
 =?utf-8?B?ZitBdlNaWkpGODhYaDE0YkJNaE0vM2hubEpyZDQvNno1VENWS1pPRmhRYUww?=
 =?utf-8?B?ZkRETHIvSzhJRVd3MGVIRHJ3OXNXSmJmMUZzY1VVa01VcGhVUk13N3NROWsw?=
 =?utf-8?B?YnI5c0RhMW9MSTYydnRKN1lTSFYvR3dkc0ZzU0U2K2ZwSGJ6VEdNa2FuWklt?=
 =?utf-8?B?MFhUbTFMbTZhR0FLaTU3T1hUQ3lxT1pIZXJxTWJGSDVYQzVyNGhHN0pQVFNM?=
 =?utf-8?B?eXdWYmRyOGR6RGU0WVpBdjM4bkFVUUNVZjd0VERlL2tzYkdlV2FDQnRpZkR5?=
 =?utf-8?B?ZnRVeE93c3VINFJUTG50MnNIajlDSHM3c1Nua05OOVJZbEJEZnB6SUNZRk1z?=
 =?utf-8?B?WG1MOStuTm50cEJISGNEc2FJOXlvV0xpT1hMUFgvQS9KMkJObGpsTkJDQXFj?=
 =?utf-8?B?TWUyc1NvWFpBMWRzdnZGU0FYRGRlTHFTWFY3ZlgyUHdtL2JpdlFNeWxNWkV2?=
 =?utf-8?B?cm0yQU9nYnJMTElTZHVUNFJoU3RPYTRkai9ZaWhENjNpN3ZMTW1ZUEUrN2t5?=
 =?utf-8?B?STNwWHNUQzhjOUkrL2FjZGk4MkpEcHlVdVNxa0JONi96UzNRM3FRSm5qSVZp?=
 =?utf-8?B?ckpiQWY4Y2QvWGM5SlNxemNOYktGazd6K2lxVWFjOFlSckRPWDU2QTFqbHZt?=
 =?utf-8?B?THc9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: c368c0df-0820-4148-dd6c-08db5cee50a6
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 07:04:42.9788
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yXnXGhfp7uX/T/EXj8TqPrR1bBVRI6vJ9PJlTRtvAcXeinF36z0k3+uKmIYxrRGsFg/w+3a6k5FzsyNY1EaWHVRJGN000R8Kff8FmJnAL9Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR10MB8227
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/05/2023 02.01, Peng Fan wrote:
>> Subject: Re: [PATCH V3] soc: imx: support i.MX93 soc device
>>
>> On 15/05/2023 08.37, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> i.MX93 Device Unique ID(UID) is in eFuse that could be read through
>>> OCOTP Fuse Shadow Block. i.MX93 UID is 128 bits long, so introduce
>>> soc_uid_high to indicate the higher 64bits.
>>
>> So apparently, the imx8mp also has 128 bits, at least according to the
> 
> It is 64bits. The RM maybe wrong.

OK. I assume you've raised a ticket internally with the documentation
team to get that fixed?

And while you're at it, could you draw their attention to the lower bits
as well:

0x420[10:0] UNIQUE_ID[42:0] 43
0x430[15:11] UNIQUE_ID[47:43] 5
0x430[23:16] UNIQUE_ID[55:48] 8
0x430[31:24] UNIQUE_ID[63:56] 8

I mean, it's a really amazing piece of hardware that manages to cram 43
bits of information into a 32 bit word.

>> reference manual, which mentions a "UNIQUE_ID[127:64]" at offset 0xe00 -
>> 0xe10 (i.e. bank 40, words 0 and 1).
> 
> Which chatper?
>>

In my copy, which identifies as "i.MX 8M Plus Applications Processor
Reference Manual, Rev. 1, 06/2021", it's in Table 6-35, page 823.


>> obvious follow-up question is: Are the currently exposed
>> (lower) 64 bits unique among all imx8mp SOCs, i.e. does those 64 bits by
>> themselves actually work as a uid?
>
> Just as what the driver indicates, UID is at register address 0x420
and 0x430.

So, for the record, for the iMX8MP, the SOC UID consists of precisely
those 64 bits found in those two words. And no two iMX8MPs ever produced
will have the same value. OK. Except:

> For bank 0x40, I could not reveal information if RM or Secure RM not say
> something.
>
> You could raise tickets in community.nxp.com to ask people follow up
> on RM issue or else.

Very interesting, though, that somebody else tried to do just that
(https://community.nxp.com/t5/i-MX-Processors/Question-about-UID-UNIQUE-ID-of-i-MX8MP/m-p/1582383#M200077)
and have unambiguously been told by "joanxie" from  NXP TechSupport

  refer to the reference manual, lower 64bits from
0x420[10:0]-0x430[11:31]and higher 64bits from 0xE00-0xE10

and later

  the higher 64 bits thus bank 40 word 0 and bank40 word1.

and again

  since this soc uses 128bits as UID, try to use 128bits

But you are clearly stating the opposite, that bank 40, words 0 and 1,
do not form part of the UID, a statement supported by the experimental
fact that those words are not locked down from the factory.

Apart from the still unanswered question about what those two words then
actually contain, represent and/or are used for, this leaves me with yet
another question:

- What's the value of asking questions at community.nxp.com if the
answers one can expect to get are not rooted in reality?

Rasmus