Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 09:23:04 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Judith Mendez <jm@ti.com>
Cc:     Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Schuyler Patton <spatton@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v7 2/2] can: m_can: Add hrtimer to generate software
 interrupt
Message-ID: <ZG8M2EDSG/NtiTwF@corigine.com>
References: <20230523023749.4526-1-jm@ti.com>
 <20230523023749.4526-3-jm@ti.com>
 <ZGyfAhp8op4GMElN@corigine.com>
 <8985ea03-a7dc-a0bc-a238-3099caadf740@ti.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8985ea03-a7dc-a0bc-a238-3099caadf740@ti.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rFnSqE1yBiIyV89lxHWSoukKXT/Wc5U0ZYn7gCbYCNtIfY73vQ+4lwkL36we?=
 =?us-ascii?Q?Hn/JRltrhHWJdyVOfy02JfStNe3061eZpXKlBm1SddpztUBgYDPJUW5eObu/?=
 =?us-ascii?Q?OcxYwHtxdxxZjg6iRiO0sBShkM0VK0Qw2AxUl/tyy9mDQT0OBSIIL/Xv1e4p?=
 =?us-ascii?Q?bhaD0DNj5CyyE7s4c/5cphTwitHnl9z+UKudL4BOlkjI+rXpwt1lcm/Av3kQ?=
 =?us-ascii?Q?c5XO5YSoZWpATezTfsCvQTy4MWzgtmhVMnUmwQMIzf0bKSAouI6J+VBiWqQx?=
 =?us-ascii?Q?cakicJKtJtFQgSxbHgoby3p2MURfkeUiuXK5C+8XaurG6DinabGWviDFldJt?=
 =?us-ascii?Q?7foHlWZ/QCrM3WPfNI/e9BbCgLfMM6Zavgm1NJhBNhf9FCMa6FxQj/hAXBgT?=
 =?us-ascii?Q?iEkgziPvb+6qLtKYEZA40L9rae+slBPsjAJkgNgyE9tnJP1eWlrkyQgbnl5v?=
 =?us-ascii?Q?VqBCua38u7fA0jYkYxHMCCWQa88YWJw8vBMV6GOxKhBSN5Jzt/UV3woNk0c0?=
 =?us-ascii?Q?rsB1uiCg8LPzq51tV6JuhqUtYVEul7w7Za40l/B/0QfkhfUPPluPPApYEnMa?=
 =?us-ascii?Q?djzka9bsF5HsJ+30XuUHv9X5Lh9N2U23MDe92MabWHwqglW9F2MAZEBQyM3J?=
 =?us-ascii?Q?Ltv6OQp3moLpIug0x4LA+fYy3kssbVTxt28lwxsqoHfLyxyqCMf5nKIIvmCy?=
 =?us-ascii?Q?at8kxeVdKrjeana9BSIHTzUtNXddhjA3UgwCNgOS0wFB/iFzXZ81KMWMnaqy?=
 =?us-ascii?Q?PkaR1Le6tbTnyJhhKAQ59u8BW7+lRy6SB5igcphYggAkgjh0EzLDQG5p+PiC?=
 =?us-ascii?Q?7UnAXB+VYD6wlsBeTe6J8AW/b2LZO5/8fSNvRFpVmlUrFMzCQAYs/HE+8d2z?=
 =?us-ascii?Q?4r3jsfqk1+jRZTYhBBaoHyeeKZyf8L+/TTXn1D54qNY0N2PzObUIzvXjr9bb?=
 =?us-ascii?Q?NSary6pjU9qysvcDqS3f+auoryzCyTX84Oe+WhxnzVGMVWyh+UOrMShBgL59?=
 =?us-ascii?Q?70za5KOvqois6sZ6NgaJ8Nqb0cf9HzRQqIfOjs5RpjM/+iUtx9lZlu06ClRv?=
 =?us-ascii?Q?guqNAh3OeawZBd0UjOGpScNu0XueTWPWyhim/mUCYxVaaaIAZGiyWklKx28C?=
 =?us-ascii?Q?QHBPnkaLeU+5VG6YAz25KpoUDsqIXHZwDtyub3sR4cVSNEOFW6N1qnpKwb9r?=
 =?us-ascii?Q?5oTVNvqTjVtXnBBFuRBJ4wIy0Da3p5i6/fI7sOKuKO70+nrBVHN8CN9ru4I+?=
 =?us-ascii?Q?WJLeKHJJmBC+2HYi3zwkgYAoYt2svtyV/MbuVbVRolKYCy/KIzLns+alu1Tm?=
 =?us-ascii?Q?NacoRgxpmX7rpJXSyRNJInBPvV2XaOGw9bXSPK4kMI4HfKxPNM3t2TH1H4FF?=
 =?us-ascii?Q?cY7gUPlTEHBvuty+rwJJh2aKCgHUc0fifyE16wq/LUvkmnO5t/sjb0vm5vwU?=
 =?us-ascii?Q?QOKRZk+B5r+d3XAStbFcc3S9sAQoWNzT8ThgXYVcLNcRAz8ZUyC4IJH5cg/r?=
 =?us-ascii?Q?qa/Q2a8KzCr7E01jjVt2BTBrYxTDG9RsRjtMm+q7abOJdlCftwoiPu4cMdPC?=
 =?us-ascii?Q?qejgXVTLWlHXpT2UmP4ZKZexuiKrco3BGsXjVNzhwxUkj3lEOxVJ7mLBbms3?=
 =?us-ascii?Q?G61IpisRvbBF6yV5rllZsvnBYfYC9BcbOZJDxrGZNs/VPAbshtM3HRXQT5yX?=
 =?us-ascii?Q?NoNzQQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da8b8678-d339-4ac6-ea5e-08db5cf0e5b5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 07:23:12.0376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GWajdZrPI6M+6PPig4Ei/XgAq0n2RbpvNIys3IFYqNmTtEYwbfzMZvqMarDRGuy4vankqhhSk3LCFK59qBGsmnWtjAYCRxRsKQoX6cgWoOY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4949
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 24, 2023 at 04:29:01PM -0500, Judith Mendez wrote:
> Hello Simon,
> 
> On 5/23/23 6:09 AM, Simon Horman wrote:
> > On Mon, May 22, 2023 at 09:37:49PM -0500, Judith Mendez wrote:
> > > Add an hrtimer to MCAN class device. Each MCAN will have its own
> > > hrtimer instantiated if there is no hardware interrupt found in
> > > device tree M_CAN node.
> > > 
> > > The hrtimer will generate a software interrupt every 1 ms. In
> > > hrtimer callback, we check if there is a transaction pending by
> > > reading a register, then process by calling the isr if there is.
> > > 
> > > Signed-off-by: Judith Mendez <jm@ti.com>
> > 
> > ...
> > 
> > > diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> > > index 94dc82644113..b639c9e645d3 100644
> > > --- a/drivers/net/can/m_can/m_can_platform.c
> > > +++ b/drivers/net/can/m_can/m_can_platform.c
> > > @@ -5,6 +5,7 @@
> > >   //
> > >   // Copyright (C) 2018-19 Texas Instruments Incorporated - http://www.ti.com/
> > > +#include <linux/hrtimer.h>
> > >   #include <linux/phy/phy.h>
> > >   #include <linux/platform_device.h>
> > > @@ -96,12 +97,30 @@ static int m_can_plat_probe(struct platform_device *pdev)
> > >   		goto probe_fail;
> > >   	addr = devm_platform_ioremap_resource_byname(pdev, "m_can");
> > > -	irq = platform_get_irq_byname(pdev, "int0");
> > > -	if (IS_ERR(addr) || irq < 0) {
> > > -		ret = -EINVAL;
> > > +	if (IS_ERR(addr)) {
> > > +		ret = PTR_ERR(addr);
> > >   		goto probe_fail;
> > >   	}
> > > +	if (device_property_present(mcan_class->dev, "interrupts") ||
> > > +	    device_property_present(mcan_class->dev, "interrupt-names")) {
> > > +		irq = platform_get_irq_byname(pdev, "int0");
> > > +		mcan_class->polling = false;
> > > +		if (irq == -EPROBE_DEFER) {
> > > +			ret = -EPROBE_DEFER;
> > > +			goto probe_fail;
> > > +		}
> > > +		if (irq < 0) {
> > > +			ret = -ENXIO;
> > > +			goto probe_fail;
> > > +		}
> > > +	} else {
> > > +		mcan_class->polling = true;
> > > +		dev_dbg(mcan_class->dev, "Polling enabled, initialize hrtimer");
> > > +		hrtimer_init(&mcan_class->hrtimer, CLOCK_MONOTONIC,
> > > +			     HRTIMER_MODE_REL_PINNED);
> > > +	}
> > 
> > Hi Judith,
> > 
> > it seems that with this change irq is only set in the first arm of
> > the above conditional. But later on it is used unconditionally.
> > That is, it may be used uninitialised.
> > 
> > Reported by gcc-12 as:
> > 
> >   drivers/net/can/m_can/m_can_platform.c: In function 'm_can_plat_probe':
> >   drivers/net/can/m_can/m_can_platform.c:150:30: warning: 'irq' may be used uninitialized [-Wmaybe-uninitialized]
> >     150 |         mcan_class->net->irq = irq;
> >         |         ~~~~~~~~~~~~~~~~~~~~~^~~~~
> >   drivers/net/can/m_can/m_can_platform.c:86:13: note: 'irq' was declared here
> >      86 |         int irq, ret = 0;
> >         |             ^~~
> > 
> 
> Maybe a good solution is to initialize irq=0 here.

If it is valid for mcan_class->net->irq to be 0 in this case,
then, yes, I agree.

> > > +
> > >   	/* message ram could be shared */
> > >   	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "message_ram");
> > >   	if (!res) {
> > > -- 
> > > 2.17.1
> 
> 
> ~Judith