Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 10:42:02 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Thomas Bogendoerfer <tbogendoerfer@suse.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Asmaa Mnebhi <asmaa@nvidia.com>,
        Liming Sun <limings@nvidia.com>,
        David Thompson <davthompson@nvidia.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] net: mellanox: mlxbf_gige: Fix skb_panic splat
 under memory pressure
Message-ID: <ZG8fWujTDjxRXZKn@corigine.com>
References: <20230524194908.147145-1-tbogendoerfer@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230524194908.147145-1-tbogendoerfer@suse.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GvU5ETckDjjuLpO1FuZjOjGDmP2wnUi9AW5ARzvaqecTfq9IVP+JL26mpJNC?=
 =?us-ascii?Q?0rAvvOjT2URKF/qPhC6Zf1IIAPk9Jt0WCQELH+ilTjQDADw6kiJSp62oGXV/?=
 =?us-ascii?Q?CRvkqNFTQMGCYsJfHzPm7Pr4OraVUvOmWr4/FW6h9OFrqwdfea8WwQj2y5iA?=
 =?us-ascii?Q?5ea4G58DcWiJPp9pT2j8XT21shrsqCKd1kbL9ssF/yyTJOVTvvhMhkkiWPfZ?=
 =?us-ascii?Q?yEcM77JrLU1hJqS/A/GjX0mn9qpQ9+hIifLPz3aSe6kQ9cXmyK0gnlJMeM+B?=
 =?us-ascii?Q?k1n3cHes53nk61KrcpN1NKUbD6gFDNtx8tvF2LD6dpcFBcG8Xw2ZWKG65Fi0?=
 =?us-ascii?Q?yo0Ulg4PMK7v9V9qn3l0akLG22D1Tu4bsXWR/O0kBlqduZHOKRMd7KFEANlf?=
 =?us-ascii?Q?aHupc60h3mghH3bEtTiBkF8E9BhZDN5NJSHyHMQgFxCSlnfWb9D+W5tsJsgX?=
 =?us-ascii?Q?55FznSKfQ+USNBcTIEmENXZBD19wDpoFJlbt+JeeYsng+GoUg2cslOqTIMWx?=
 =?us-ascii?Q?0hWIjJ9NLrWiZr+JKkBgPvu+adv/e5+8CaEQtZhNJbKhcVY2NScaeC4lztpF?=
 =?us-ascii?Q?mt42wpDP30MfU6f5HwuUgXu04ovo99x2WsOr7xkGs6slBGXvhcIcyd3IcwR/?=
 =?us-ascii?Q?4an69+dS6iFPMQFdPIbIZ3Opb8glrVJBbZz1oKugL85DIL00tWD58tEPmXYO?=
 =?us-ascii?Q?086hGpKaFlGjJwt71wETAyM5lYzqVxeU3T+3CwMEOoZM68gclcVOhJirEtE0?=
 =?us-ascii?Q?yVKEfA1mXmj0ZEX/qKgyyhyOhtI7bQL4wmvBS5M62PjO9Rq5HKaYWRUGeYNZ?=
 =?us-ascii?Q?RgG1+CGCc/lY8To6ZR/JnDn/qOnSXNvAfpYQaMYZteUOrnjrQCP6qeEgffrD?=
 =?us-ascii?Q?iwBDocpmbL2a4un8mTBTLnpv1x1gv9Zp17qTkWwkavbSZRQ5dtOt9kCHEYRo?=
 =?us-ascii?Q?Nb7pCXoQRbjmq5zyURmFUCIoL75/ykrWygDdgiUU/IexR2+kQj/LlIlnUXWq?=
 =?us-ascii?Q?mspoK3TKa3z1uFX3Y5klBVYdhg+oTCkUH3GnVjFL7WTMuqbLu97CWqBKoU3P?=
 =?us-ascii?Q?3aJoLw6HUkm7tco3w78ltyRdWOP4p5hGTp/whsIYf7N59DtT9UBNH4K1lzb9?=
 =?us-ascii?Q?tnYt1SinRlV+wz4sAz8kqvFm27C7NPFP0JoDLdxOFjr8VUxw8aHFzQiTdIhB?=
 =?us-ascii?Q?zkXxshj817goX3X4lbt8FKHFb7FyUnu7dBaeSj9kyCBOpQchbQi1PqOizZ8E?=
 =?us-ascii?Q?uCft+NxYt+TK32JgK7Xx1UL+AZi0rnCgRmCK4e5Y4m0XeTg2XWPVGapVys9r?=
 =?us-ascii?Q?PSNUKycz3OF/RjSFF7tDapfllWPM52BpM3eFlN+z8U7djA4CgIbubT4kstx5?=
 =?us-ascii?Q?/ruwb5EVSca5aV3506HcTeO7GcR0YMhCKiwkXFUsxkla/T3wzSsaV7uPYNLt?=
 =?us-ascii?Q?YVBtijG0yTMzE4ao13diJqDE8+LMI9R6tMgkI4YuOoHqGuOYcwck8GnHcYRZ?=
 =?us-ascii?Q?51csqt+y1cQNL70H40rDdCFbh+SMAS2w4oVyJmwHahKbCR8/D1R0U+IhTP1K?=
 =?us-ascii?Q?c46HWybYpCriAeY2ezaShFXLS04+9INzQRpwx7/wykq8d4jWXm4aArkgx4GI?=
 =?us-ascii?Q?1y5x1iJ0EyO+jaVfoxJ+Hoe4XdzDMaBrnfsZTcOJHXgWlhznPfo/B5hkrKmM?=
 =?us-ascii?Q?oUVdOg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0e5aa48-8cd4-4f8c-d1fe-08db5cfbed85
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 08:42:09.9168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3DMcaAAy1KS3q9zCda2VgigGu9EQg2qe+25dnpjgMjj0Kix/RLbKJQ4kIceelT/qAZTY0j4vvctWynWp3f46iHhWLH9YS0uFGVFAb+GV2N0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB4619
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 24, 2023 at 09:49:08PM +0200, Thomas Bogendoerfer wrote:
> Do skb_put() after a new skb has been successfully allocated otherwise
> the reused skb leads to skb_panics or incorrect packet sizes.
> 
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>

Reviewed-by: Simon Horman <simon.horman@corigine.com>