Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   wei.fang@nxp.com
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
        netdev@vger.kernel.org
Cc:     linux-imx@nxp.com, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()
Date:   Thu, 25 May 2023 16:38:24 +0800
Message-Id: <20230525083824.526627-1-wei.fang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AGBoNAp+b2hqC4LKEV4SzoL1KwjsAxYgh5ncttlvJ259Y2tBC1QjCT7JYDL9?=
 =?us-ascii?Q?gE+HJ8nnBjdoaFUAFQcIkMk748xhUfmIhryTQ8zfUX0vHe4leFOybS+ds21c?=
 =?us-ascii?Q?sUDp4OzCi8T4Mzdu7YCvlw/URgMgcTpovU3fPs8svLwL5m05/sscWjCs6Zlf?=
 =?us-ascii?Q?OslqClsCYWDvIvZOW55Ac+eyB6uEjF2r+EZhzTEbmCAeW5xHDWWoj1CxOKYG?=
 =?us-ascii?Q?ykJcQIFsVq7XsGL8JhBWOEngU91VmGsquoA9I9ZMNsPXdbUesGL5D/6IB+kz?=
 =?us-ascii?Q?HxRapP6aluIPlZwngrTPcyK7jXwFCZivTaYxMiiaF6/63wNsQ0CKd1XgaP1p?=
 =?us-ascii?Q?FUxZBvOq2Pf7puikHpRWRxiLSqAXYV/PKpcXM47MO/FrWpTDAmviOdntfQvB?=
 =?us-ascii?Q?oRuKY5nruOJSq3GObgOm22kU6LuhJ+qyD8iF17FmqWZQ9ppfNWxuaP6SmzXi?=
 =?us-ascii?Q?6p1xnXIBV0L8GTzNAzvje74gAU4Ob9GYyRbAmw9glgIZhbqdCIRbf4glWoHV?=
 =?us-ascii?Q?BM4pHdtCJGnLA+L6Ek+M0a4Ml2dA5L/iuvm+airYrAlCRe/eL0kMUUtiyfq6?=
 =?us-ascii?Q?IvAtuQypRd2nx3DGN8+xjl0LUeeh2YKijvBLrLLJW9MSkQ+N7WN/jW/mhGBN?=
 =?us-ascii?Q?mO1e29wPY/qgT/6SMY8xrQHad8SZrRv6MeOjVJGg1ZG2abl4yINeTnHi7dRn?=
 =?us-ascii?Q?Xe6KGyBjXULKCqr6kkBJQCqsmyDyFlPMR07Gqv1sD/T6Ulma17OTlPpCfbcq?=
 =?us-ascii?Q?BJyCR86nRP+QHLpeGss2z/8QuTHkqQRthh+8jfvTgM6sIWAVySs/FVz/uzc0?=
 =?us-ascii?Q?9G6EEeWF8Q5j+CQX3BcZtqvWHflAOd9/xjujbJG1MvLzxUQxYJGu5rHtKROM?=
 =?us-ascii?Q?eIxsmNI86SgaM7sBOR8XumTDb5cRWvIZYOI3jDr7kGpWnRJerlJUALyRBNr1?=
 =?us-ascii?Q?F3U9eDdAWx0emsXbHpoZPhVSwNLdWAdk271GJ+7L8ByUGDV5XPvQgNpRQ6Ee?=
 =?us-ascii?Q?SxkHVz0R6i8z04vaPDMyYZPbEEIQNPsmQQTzl5zwzpG74siYTv4rpLelgeZT?=
 =?us-ascii?Q?qT/hhmf+GGtyEA04IlhPXCBTkeej17RZTYXa93y76fTik1YWFi6bbB+MaQmj?=
 =?us-ascii?Q?WvF0TTXeozCFvJQKtXTwDXGeC6Ne17kSF0juNn8ie+8n652PvzYRZNyUS8R6?=
 =?us-ascii?Q?PJT/RyJLi0c7SOajdkbEgkSZ72FUgcvfi1XuJef6/NgEheCwcUohaIvjPwlU?=
 =?us-ascii?Q?1ILE57g+1j+76gMKPx4OBO4CflGO73+fQI21p3BubRJIXUTtKP/eWl722Fyz?=
 =?us-ascii?Q?FC54nBvn/B+Wih2GVxry8TiLXOmM4Yrx+8xuiWzx27j+krPD1OeNLdNM9PaZ?=
 =?us-ascii?Q?qmh9HEEpLnzvDT1HpnyFJJ+p0NTWdTpXmvo9pMuk9FTKD//klGZHEFADFltS?=
 =?us-ascii?Q?YJ65NOq/n6k31d4h8BPStowQHn2ea4eqCit7q/Vf6yxC9/3vGJiZwWCm8h4q?=
 =?us-ascii?Q?X36JdN5HYSCbC8CvVmn/E586IsU71oVOt+/6m24/d+OoYAUYTY/i+vcqE5Co?=
 =?us-ascii?Q?hZXNXEzfVglZzBNz4WbHijVGN4zZh29zoLBAC1jj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53721ba4-b7d8-4b4d-d9ed-08db5cfc0b58
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3139.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 08:42:59.6962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8aw33zlaR3e8GX+XapoJbOrkdxo3a+a80A9k380aM7UVOR9JBHPZhCpplI5fVy2jqmEZwm5He/3H4I5+bIcRkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8558
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wei Fang <wei.fang@nxp.com>

Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(),
so remove it.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/fec_main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3ecf20ee5851..26fb00e0590b 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3770,7 +3770,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 				   struct xdp_frame *frame)
 {
 	unsigned int index, status, estatus;
-	struct bufdesc *bdp, *last_bdp;
+	struct bufdesc *bdp;
 	dma_addr_t dma_addr;
 	int entries_free;
 
@@ -3782,7 +3782,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 
 	/* Fill in a Tx ring entry */
 	bdp = txq->bd.cur;
-	last_bdp = bdp;
 	status = fec16_to_cpu(bdp->cbd_sc);
 	status &= ~BD_ENET_TX_STATS;
 
@@ -3810,7 +3809,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 		ebdp->cbd_esc = cpu_to_fec32(estatus);
 	}
 
-	index = fec_enet_get_bd_index(last_bdp, &txq->bd);
 	txq->tx_skbuff[index] = NULL;
 
 	/* Send it on its way.  Tell FEC it's ready, interrupt when done,
@@ -3820,7 +3818,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 	bdp->cbd_sc = cpu_to_fec16(status);
 
 	/* If this was the last BD in the ring, start at the beginning again. */
-	bdp = fec_enet_get_nextdesc(last_bdp, &txq->bd);
+	bdp = fec_enet_get_nextdesc(bdp, &txq->bd);
 
 	txq->bd.cur = bdp;
 
-- 
2.25.1