Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fbfc6917-d938-a055-2f58-e70a6d454ea2@quicinc.com>
Date:   Thu, 25 May 2023 14:20:37 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v3] usb: common: usb-conn-gpio: Set last role to unknown
 before initial detection
Content-Language: en-US
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
CC:     <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1685004036-17273-1-git-send-email-quic_prashk@quicinc.com>
 <2117b7c4-d164-de17-5a2d-ef3d51304983@collabora.com>
From:   Prashanth K <quic_prashk@quicinc.com>
In-Reply-To: <2117b7c4-d164-de17-5a2d-ef3d51304983@collabora.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 25-05-23 02:15 pm, AngeloGioacchino Del Regno wrote:
> Il 25/05/23 10:40, Prashanth K ha scritto:
>> Currently if we bootup a device without cable connected, then
>> usb-conn-gpio won't call set_role() since last_role is same as
>> current role. This happens because during probe last_role gets
>> initialised to zero.
>>
>> To avoid this, added a new constant in enum usb_role, last_role
>> is set to USB_ROLE_UNKNOWN before performing initial detection.
>>
>> Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection 
>> detection driver")
>> Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
> 
> I'm sorry to make a call for v4, but you have to mention that you're 
> touching
> the cdns3 driver in the commit description, if you want to keep the entire
> change set in one commit... otherwise you'll have to split it in two, 
> one adding
> the new entry to the enum and fixing cdns3; the other setting the last 
> role to
> unknown in usb-conn-gpio.c.
> 
> I can suggest text for keeping that in one commit, but the choice is yours;
> 
> "While at it, also handle default case for the usb_role switch
> in cdns3 to avoid build warnings."
> 
Yea that's right, will add it in next version. Thanks for the suggestion.

Regards,
Prashanth K