Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 11:08:52 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     wei.fang@nxp.com
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
        netdev@vger.kernel.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: fec: remove last_bdp from
 fec_enet_txq_xmit_frame()
Message-ID: <ZG8lpJvFnZlA3w2q@corigine.com>
References: <20230525083824.526627-1-wei.fang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230525083824.526627-1-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z+IvTaqmm9sSA8Ibb1+m+uyxRLw+KjJOht8YdbwYViasNp2TG2Qds3QszYua?=
 =?us-ascii?Q?qbNLMWqaG9dfAnhtKhWQu2g/p9QdAV0cQqgUPAFma0xT7yQ2VPgevni9y7Sq?=
 =?us-ascii?Q?tY7MuSK3CrG28LwDYxS+CP4H0bu9Zm+80lbaOtMhvPxqnU6HNroBVcng6d4j?=
 =?us-ascii?Q?yBjZbbYGOcuL+/dd0BA/Uoo7FlotfxORcUrleFJ7lkI6P0rQXae/lfTmOXfb?=
 =?us-ascii?Q?FXb4V/AixeXI+PZ8mTkXe5Pf781zue4AVz4DxR6QZVnGBRw23GFc9fWhbs6J?=
 =?us-ascii?Q?vxUJihLgabIRSsqeOrr9PXnLb4ZjUIe2hmHiYKlN1Kb4U0TKcTHhQcVPbAjf?=
 =?us-ascii?Q?hllPHObPr3Qf+kZ46yR/UvLmDoyfDyXyLvlBlVPHHdDg8mnWjMJsqbO7pVsx?=
 =?us-ascii?Q?Xdv4eLy7Jq48NOpXoeGE1xNyZLQgfPPNoky9dxdayjnfpu1ifjDny6BoODK1?=
 =?us-ascii?Q?rzxetE7l8dCtnAbSIH8nuVpT67i4FuccUjq33Av6sbinK8yLn7iv8b4Wn21s?=
 =?us-ascii?Q?/+pgsqdMUsuNaL8FlkHodYqUVJHtTKlVVb6Cd3ZkCPFPaUEYnW7y2IP7gX0q?=
 =?us-ascii?Q?oqm77AdEMInCdY+sdqFyW81EUnaFkdEAhMdWK5mGNLKu9+ihrOI80JbE9OC4?=
 =?us-ascii?Q?NJ9gXEVuAjPWcipQz4FIK+eV82JUcD/3/0zcGPc+apNgI5c07Lvqzv0xN9V5?=
 =?us-ascii?Q?9RKrorstvPhT/0w1cB9QeFmvYrHk4zr/1CDEKSLHMrxg84gWY9poN6lQ3B79?=
 =?us-ascii?Q?d4S+U8XXuVsf0kfAbi6dBFEy3QqfzdnP7Ve7nInMVA829zfsQMCA+sEywogb?=
 =?us-ascii?Q?5wQnq20wjYRf0I8dG+28Z9/O3nIKayd7pH/HywmqzYfxN4eoJ7ueiV5GHu2B?=
 =?us-ascii?Q?LRyfM3gLFg70oXWoYNOW/oXNrfsFRCOvXv3GabH3XBkZj9ASARozAW3/Q+Ek?=
 =?us-ascii?Q?lpRBl5i2zzoIK7CfNN+69jOv+k43ZrEpzVl/AeSOiEBe1iU2oyEB3+JV5XMO?=
 =?us-ascii?Q?cxwL+NP9cJFGRSRVKgwjB+v4U6J7p3pmJm3VPElsUy62S9akmNsUZC+9MNzW?=
 =?us-ascii?Q?xq4tRr2J9VZ971zOhQRZ+qkn1BmU72I7T6wwSHQqSHTOaQtNwTMATUvlrycj?=
 =?us-ascii?Q?GiEuBRH0RTDmzl7uA2ZozeX5gxa/81+13LAjkqLWykKZguuNrPDlPK+EVmtm?=
 =?us-ascii?Q?SXfDT/jmEXGvgJFIgsyfvXm14ocG375jRtuJop2T7fBSLIj1Mu/9hz7+wnu0?=
 =?us-ascii?Q?TBvw6ItkNqw7OAj+MRIymtdpHVQn3P3WxqK2/7no8MNa+y4/cP+0HZU2zeCn?=
 =?us-ascii?Q?6rYPyEjCE57iloOfBW2dZuT9W/uBcyYpy/li1ysYMMxS2lp0oTf4OWD1lVIh?=
 =?us-ascii?Q?XXugHZ0KKpVkbRgULo5rf8fNeY/iIq4Xov+W5e6w4Pd0DXf4Spm/655FOzq7?=
 =?us-ascii?Q?yjZvtar33Tyeh7h5Sc02X2oFbv0fr3Y4CC58d7sxlyte4scXhj+U19m81TrK?=
 =?us-ascii?Q?LkMW9NZgZ2e8gpAd1U5dOEaaMP+/zo1X56TCgrV7Zj/mKrtekqrO6a8Dg2tV?=
 =?us-ascii?Q?4B2AJRwvuqks7CcN+PUKu5mUlOHWvBPP0/iHk564dFl2TbyXjP0FEXtCOCgH?=
 =?us-ascii?Q?Pi2Zd0fjuH9J7P/nTD6bAKhmDFCuUDH05bnt4X+eOroT2fpl1/2ATasgAqTA?=
 =?us-ascii?Q?B7XOfA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 412eda92-8fee-4b40-ae25-08db5cffac8c
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 09:08:58.7850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pd6/w36dpnejak8MgGs51kpgYpuAe14PJKBDyPnnEApJSn2hyDN0vBNsIBRxwdo/i6opsEn4BibKHa7Jhl7l3rWApaf+Xs2X3PCokgocG5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB5097
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 25, 2023 at 04:38:24PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(),
> so remove it.

I think it would be useful to describe why it is useless.

F.e. because it is set to bdp, which doesn't change,
so bdp can be used directly instead.

> Signed-off-by: Wei Fang <wei.fang@nxp.com>

-- 
pw-bot: cr