Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp709169rwd; Thu, 25 May 2023 02:49:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Uhc1g5x4o116US6WvUf6AzZR4LMbdXeNltbFd9ZAA6Xu1HNcq+BU+qO4KAMby6aE6qog6 X-Received: by 2002:a05:6a21:9994:b0:10a:be5c:6e3d with SMTP id ve20-20020a056a21999400b0010abe5c6e3dmr2820850pzb.13.1685008145736; Thu, 25 May 2023 02:49:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685008145; cv=none; d=google.com; s=arc-20160816; b=kPynMedxvR4MtnP8ovDesciBBzvh8c+lAUPkKRxx/1j3CJaA3ywjb8+/K57sjwGC9e EmoCz9VeENlvfL5h3cZFzLDjWEZZ3uTqrwniKQ5eL7NgAbyar8xOdIU1tNM3+heufKX/ Hr0JyxoVdBdiV5ulKV9WQ5YOGPyJgylDzEYIMyKjW9v1Lo7m6G96chdjZ05eLrVkgL3z PLmLyZ80+wFpHx0a2n/INtnie1Fbw4xLhYWmIyAnfE1oEyRJVgmzkxvQA226AwcBIj/R kPBP2ezsDDE+inbICHoBFuZpagAmJBjALsTJ5GB9hRnq0Yx0SEQMbBEJusDIjt1KTX24 ma1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I5oO1kYNE9YxQL1kRyl5TeIb0Whiv9SASuKrYcI+4Rw=; b=Taa7uGVAQGnwNFyv85Ma05RU5vLaoYD5OddAj0IH1y+uNp4UUy2qg5jnldn7AEhPSU 8B3Pf6URJwyosV2y++lbnATIYOd3k1j3bYSvFX6xXPgkO5m76IlRQB8RqGFoNTxy0ROV XkKVUEpnjYhjn9myGGGyRxMhLTu6uMaH2wg3G/3Z0PZDwDGxKRCZHodCRSXWXs2Spwci I2ITt/5B7YZVzWQW/ZO8FMzc9GBPJg7TOQ4Q62TtE/8q6kG/XDlTjEjYFmXsZxcDFfd2 +d9XqsqgNo6w7ubsoD/8J6eeYPWxWATRMaS6l9dC1VGMyqzX9QaSBGU1dt9JqN2e6h99 ypFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=k7MzC2bW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v3-20020a655c43000000b0053f0cdab80csi805106pgr.338.2023.05.25.02.48.51; Thu, 25 May 2023 02:49:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=k7MzC2bW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239801AbjEYJkR (ORCPT + 99 others); Thu, 25 May 2023 05:40:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240762AbjEYJje (ORCPT ); Thu, 25 May 2023 05:39:34 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DDE1E43 for ; Thu, 25 May 2023 02:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I5oO1kYNE9YxQL1kRyl5TeIb0Whiv9SASuKrYcI+4Rw=; b=k7MzC2bWdWGnYPFe3s/UOdXynQ ogKLXdVFzRcqdoM6gzeNj3sex6GLjvuL+IKmPmE/wHnovyC369Td6EcTl2wQ3N1czpwwUHyWwSHi8 dPfq6UpBondbKh6XgINXqqv4EEvKEDPr22ByFCnZu8FKVhOW1m7PwB0gIBZCV/lKmmP1KShwISrMt 4YF846REwk/fLsfAPU9cNlKrzbINM/9AYnhucdb5i5d/eKyriuLqkQNxppW8VnH25iIIh4yrDO55F UNtwaOjVZXKVB9j62gheHfYaGeii/2+RnY8VViZF/Q4PrKy3JicOZLMTX4BNIAPr7EooIg6vTvHd1 n5qNDLsg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q27QW-00GAiX-2v; Thu, 25 May 2023 09:38:32 +0000 Date: Thu, 25 May 2023 02:38:32 -0700 From: Christoph Hellwig To: Mariusz Tkaczyk Cc: arnd@arndb.de, andriy.shevchenko@intel.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH v2 1/2] misc: enclosure: remove get_active callback Message-ID: References: <20230524111231.14506-1-mariusz.tkaczyk@linux.intel.com> <20230524111231.14506-2-mariusz.tkaczyk@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524111231.14506-2-mariusz.tkaczyk@linux.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 01:12:30PM +0200, Mariusz Tkaczyk wrote: > + /* The value of ecomp->active may have been updated by edev->cb->set_active(). */ Please don't write overly long comment lines.