Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp709274rwd; Thu, 25 May 2023 02:49:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6eKsPickRxFupT7unXM85P935FDKk/+sBCw6MNtCxkR8OtlCHrpx1jbdTwZYj+OqZ81pVp X-Received: by 2002:a05:6a00:1596:b0:64d:4412:9923 with SMTP id u22-20020a056a00159600b0064d44129923mr8404390pfk.3.1685008151034; Thu, 25 May 2023 02:49:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685008151; cv=none; d=google.com; s=arc-20160816; b=UrGgoDVfNA6Wvd5Cv5qIvzcCbufEepybyiDDKBLN+3H6/ZQicb1tRuc3dQHg8Rc53G OLoMK+tcFtg9zY7bHQCAktG85JsBI51HbIQma9uy2js/4/8c/GDXYQzpZhXfYxQivtDQ YnP4fHmsVRm4lg52L8i3qvyWB2CSaaOYWHOUa+LkiWjnFh7myzXmUhn+SiXogYyEzhef /tGDcDIKfdJf27KtrT2u8vNIdEuB2QnBgT2/g9zVjvHle4wQq/R3/wSAOzxeYn7kdHhG Ae2UF+6Q1Fyy1/x0jzuSBmn14lbMbIZQwf0Y31moH5CNkRVZMC8fp4VOMAbe5VRHj9e2 GJrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VpuaHp/o7Il2YlDzKUSM0hdJY8pqkR5NkWfsD7YnoUo=; b=HmaY0Ml1sH8Lo+/1F86yox7DctkyhnPJiP+dZaAsI9aXB1jVFdd4SajOvCmN7j31uP eb1AjgPqhWlVnxlaRFy78mHS+C0WFp1x/Iw3q/92zvsdUp3c+/FsQw1EmDS+UOlCjoDm o2HxI2Pag1TMQGYuAPZ62SuNMnUJAZx3K9aK8iL3tHOJ7we2x3JPJlAcHsgELeZkGAHC uynvdnaYSH80GXmfTQjsqunFmxWoY54qwDF3/u5zCawoqFspQRR6IlBr/d5a0eVMwiPR FZTkITlbXfjlR5Ve2QzfHD8kL0VVzpGdkwxkqCF/X+slm8TXPEPZgbiTyi3PzWOKGNmR 40Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="w/Eh+TLC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k76-20020a62844f000000b0064378fd1d54si1082669pfd.258.2023.05.25.02.48.56; Thu, 25 May 2023 02:49:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="w/Eh+TLC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240648AbjEYJk2 (ORCPT + 99 others); Thu, 25 May 2023 05:40:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240828AbjEYJj4 (ORCPT ); Thu, 25 May 2023 05:39:56 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEC7DA9 for ; Thu, 25 May 2023 02:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VpuaHp/o7Il2YlDzKUSM0hdJY8pqkR5NkWfsD7YnoUo=; b=w/Eh+TLCuq0AR7mLIO7A9SXEhT api7vTY9f/uYb1qQjLYvTx+fwtAa/kVVrlyC634jAdFrpHNw0KlPpzCNfkgGS46H5jFM50IxCXoz0 dRF9mMWQJ+iBtc70LzJ3h8K4PO8Owettk6K8PSgAj5vDd6AGJs07J2HHSoeN+TBoa0lAfcQlpuL0X wxdpYdCgB88QFPnjahz1vqPYTyOYP2a3P402+jmX2ixDvwll9PvVnQ2kf0Y9DpfJ5aeMUglV4rGJs GqvIKXbLBO4AY+JuieWaimRiJFXXYe4RZUfRAIcW3RL+NXaCwUKVSwLY5y78+j5vwQB8hoJwwyKvb N6hoP2aA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q27RY-00GApj-2N; Thu, 25 May 2023 09:39:36 +0000 Date: Thu, 25 May 2023 02:39:36 -0700 From: Christoph Hellwig To: Mariusz Tkaczyk Cc: arnd@arndb.de, andriy.shevchenko@intel.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH v2 2/2] misc: enclosure: update sysfs api Message-ID: References: <20230524111231.14506-1-mariusz.tkaczyk@linux.intel.com> <20230524111231.14506-3-mariusz.tkaczyk@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524111231.14506-3-mariusz.tkaczyk@linux.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 01:12:31PM +0200, Mariusz Tkaczyk wrote: > Use DEVICE_ATTR RW and RO macros. Update function names accordingly. > No functional changes intended. The subject looks a bit, I'd say something like: "enclosure: use DEVICE_ATTR_RW* macros" instead. The actual changes look good to me: Reviewed-by: Christoph Hellwig