Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a2e6371-97a5-397d-ca1a-247b610b49d3@suse.com>
Date:   Thu, 25 May 2023 11:31:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0
Content-Language: en-US
To:     Ross Lagerwall <ross.lagerwall@citrix.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        Juergen Gross <jgross@suse.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Peter Jones <pjones@redhat.com>,
        Konrad Rzeszutek Wilk <konrad@kernel.org>,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20230524160558.3686226-1-ross.lagerwall@citrix.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20230524160558.3686226-1-ross.lagerwall@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEtDVGVVUW9iR1pjZ3V2NnlscnF5aU1vZENWaThjSEtXOGRFZlhLb0pjUjV1?=
 =?utf-8?B?KzkyanQvK0N4L091ZkJUeDY1MnRjd3B4dllmRWxYT3BHNldsVExsVDArbUMz?=
 =?utf-8?B?aHAvVnlXendpMW02cTNrU3FrTUJIZnVHM0JSY2pyUERIRE1LdlJyQzRvSGxH?=
 =?utf-8?B?SmY1SjQ1M05DMnpoQUVMbjdZZzhyZXQrd2l0K3FGeVJUU2VDdW80ak9jYnk4?=
 =?utf-8?B?T2N2ZXJONXk0L2pFclltSkdsdFNIUmR3RVprbERnR0NPcUk1WHZOYTY3OTgx?=
 =?utf-8?B?OGdNc000MU9qUHhiRnlScEF1U3lmdEltSkhSUmxpbGZTdHo0emZCNGNBUEFt?=
 =?utf-8?B?TUc4NlRvSm9kMDNNU3JZUFhmM2t3OTZPTVZ6NWVmREo5d0I1TDk2RWdDem5v?=
 =?utf-8?B?a21MMHl3Ynd3R21tbFB0ejNLSS9MbjFpcHFnTkFiQjlVOUpzRWZQR0dvVFpH?=
 =?utf-8?B?c2NjdkdOY3R3bFV4eGNCOE5RVUVkUnZFQ2s4TTNUcVFYWkpPYmpnSm8vZC9W?=
 =?utf-8?B?aWRORmovb0dJdnh1TGNNWGZSeXFVUGNNNFFMOEtORjNKd3hqczQ1OFhTSzNC?=
 =?utf-8?B?cFVsOGozRWZYVks4Zk9GNTY1K1lIQUk0YWFhc3lyNHloM1UrVnpRVFhuNUFD?=
 =?utf-8?B?empzYjR6cXV0M0JkRUFxaENzVFJSY1ZJNkd4NEhaYXZHbksyM29tSDJwWGF6?=
 =?utf-8?B?NVFHMng4NkhqcDBmYXY5N2VDRkYyVnN5MjVWeVMvL1AwZVJPZ3BNUkJvc1pi?=
 =?utf-8?B?bU4vQUJqZXdjUVJlZ0JUZHZZakkydXRmWnlrWitaamZiTlBlRFZvSjhZdVYx?=
 =?utf-8?B?Q25LR2JsbFRwb24randhUCtacUozQXljNk9rMXZ2UlRYVW56WDVmaXYyLzZX?=
 =?utf-8?B?amZRcW5LVmhNSnlmVWhXZmI5SXhsaGpaNm5GcTExWHRNejZjdjg1N0JwY2xS?=
 =?utf-8?B?Qld5aFZGcnhqelpoNzd5QzhwSmlTbGgvL2s2enpJSWJUaUpaTFlLZFhManhq?=
 =?utf-8?B?MWZ5ZEwrazRuUjl6bVNqSEhwdURTRUVNeGhGUGN2bWo5aVJFL2ZXRXh5Rjlu?=
 =?utf-8?B?OERLMFFmVUp3YVdaTWsxZkZ3ZVNwd0hlQkM1bEZXVTlsZjMvV0VSdXFLa3dy?=
 =?utf-8?B?R3lNWlJjNUQwRG5UZS9xMXAvRWxNNlp1NDk5YmZ3aG5MK1BTTGhnNjdXS01T?=
 =?utf-8?B?aFFRSUw5WStqWnVRL0lLakZ4SitoOGJuYjY0V29NbXNjMFgrbmkvTVhQOW02?=
 =?utf-8?B?VjRxTVZGVTFZOHpCcStxMS9vY3A2dkVUM09jZVRZR3VoMU0vSCs1bVNEdzYv?=
 =?utf-8?B?clU3aDNtbE8ya2RDNWNoeVVwT2g5R252MlJZRE9OUFR4ZUUvV0RLTU00WjZK?=
 =?utf-8?B?NXorWU5TWjhnT2g0WnAvRkZjY3ZxK295Q3lDbUJsU2xydWhneUF2MHNIK0Jw?=
 =?utf-8?B?L0pLbTQ4MHI2bFB2L2MrMGllZjdJL1p2K1c0bWlvMnJMQ1dkSnMyVWRMS2R0?=
 =?utf-8?B?ZXg5dmdUSWFWWXBXSVNTektNdkJmODMxN0o4NVU0VnZQOURrQ0tXQ0kzcUdx?=
 =?utf-8?B?K2MrdU1WeG00MWFDekNFVzEranY3YUIrS2ZTR1JpZy92UVhtazBJMmpZWE43?=
 =?utf-8?B?YzMxWXNadkcrZkZHbnk2T2x2RXdqa3JUTkhQa2lFOFRJSzRDWHRPaTJOOWVM?=
 =?utf-8?B?YXVlTWpwRUtieWZjaStVMlJGRWZaV2Q0R21udVA0azNwbURRMW9laWRLdmNC?=
 =?utf-8?B?ZEpsTndZZXdxVFU1WElabHRqRzV0SHN2TURqSk9nSU80N0x1dExnODVkSmFS?=
 =?utf-8?B?RysxSlAvRkRkelEwcnJPVElFaTY2QmFzMnM1bENmTmtVcVJGYkdkQWRKRElH?=
 =?utf-8?B?NHI5MWJsZ3gwTEtlT0JRU0RMbm9leGw1N3VUczREZUd1a1ZZT0xYQm1iOWZL?=
 =?utf-8?B?em5lMFRNcmJ1bWdha1orN2t5eldMc2xJWjI4TGh2d011YTVQOERJUDZqWVdo?=
 =?utf-8?B?Q0QvRk9EUGlIZnkxVnhQQklTZ0VBUXQrTnI0QWlHbk85UkwzMEY0NDFRb3FC?=
 =?utf-8?B?WE9wNW1TMGM4amRzMXFGaFpSUGRmcE1lQjllbUpMbDJuV1pYeEJZUktUcnFq?=
 =?utf-8?Q?gD6dYKjhKf+m8RZZXaDhFUrfq?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47cefac9-c554-4532-8a88-08db5d02cf2f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 09:31:25.2392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a0UNId4DA3RnHWL+Rod/craTmySJkpdzQiaqLPiEc+4IpH+YaslOVGIrWKDJu0hJtk9ee3p3vMB1UemOe7xzpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7043
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.05.2023 18:05, Ross Lagerwall wrote:
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -772,8 +772,14 @@ char * __init xen_memory_setup(void)
>  	 * UNUSABLE regions in domUs are not handled and will need
>  	 * a patch in the future.
>  	 */

I think this comment now wants to move ...

> -	if (xen_initial_domain())
> +	if (xen_initial_domain()) {

... here. And then likely you want a blank line ...

>  		xen_ignore_unusable();

... here.

> +		/* Reserve 0.5 MiB to 1 MiB region so iBFT can be found */
> +		xen_e820_table.entries[xen_e820_table.nr_entries].addr = 0x80000;
> +		xen_e820_table.entries[xen_e820_table.nr_entries].size = 0x80000;
> +		xen_e820_table.entries[xen_e820_table.nr_entries].type = E820_TYPE_RESERVED;
> +		xen_e820_table.nr_entries++;

Surely this can be omitted when !CONFIG_ISCSI_IBFT_FIND?

Jan